From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94B32C43334 for ; Tue, 5 Jul 2022 06:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JJmfKb97+s4hBOEinH+flDhbT6hCGDSsvtddkerD6QQ=; b=z/nZUYeJyil7zy PHxQn27nop2S1h9sA5bCPPdKfTXmp8u7o4OiyPjZd8/RtIP8NzAO3LMur5BDE2P6OLpr7gDs8z5iE gtsE4mYaKJLhoVRQdLwBH83HGp0LJDqb/k4ZctcfqmBNWRLRS8vupp2yyRxAfw1S5RVCZLB2DNchE H2wDVMamAvDKlWU2tK0KTZU/wKjGw/P82cdaJ2bU4hMWSSP36Q54MyVnpFi1BYko6icXeJpHdY/5s wD1TQ8dnw0qpltVbnP6wcheyah/TF7UKljnasVttOd2YNQ55NMTWEWd6N4JuEt/9+7rMZbUtMcBgi GgomANTJPsO8hpG0/O3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8cJ9-00F9sq-Gs; Tue, 05 Jul 2022 06:45:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8cIv-00F9mw-O4; Tue, 05 Jul 2022 06:45:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDB8961531; Tue, 5 Jul 2022 06:45:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C812FC341C7; Tue, 5 Jul 2022 06:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657003500; bh=WL2ZjfUm1JPUj/hXx9GP7t66KvqlfcwU00enUOuINVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ROkX858tmIqxpm5qUaJ2mSUbcqNCDVCEl3Con5a2RmhoqVNGf9efznpsRqSnwfgRj qVtQX1eV0TxtgfI9yHScf/OxpbW23xJeRlohdUPin+1o3e0Z6Zw+iULuKVkNwxEPSA F+klU3hX1e/TRBahQw6GZYpm2WNlZ/KFDj58cga9ADMIg8J7rLVYq5OPP1WYM8TLIi N3HmY0Sxk3dh0yJIT3OCwtyzZDy57OmjsA1ogR29qs4P+XAyWvl/lHJCyXnW1ccU/O N+8tUWtWnCt1006ny35PSh6j/cDhbW63nlMuCMsJhZWJtzbj0WV2PbMTGBJnAGCdH8 PY2V9re7uZwXA== Date: Tue, 5 Jul 2022 12:14:54 +0530 From: Vinod Koul To: Neil Armstrong Cc: kishon@ti.com, linux-phy@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] phy: amlogic: Add G12A Analog MIPI D-PHY driver Message-ID: References: <20220616133811.1674777-1-narmstrong@baylibre.com> <20220616133811.1674777-3-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220616133811.1674777-3-narmstrong@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_234501_944666_501A345A X-CRM114-Status: GOOD ( 28.08 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 16-06-22, 15:38, Neil Armstrong wrote: > The Amlogic G12A SoCs embeds an Analog MIPI D-PHY used to communicate with DSI > panels. > > Signed-off-by: Neil Armstrong > --- > drivers/phy/amlogic/Kconfig | 12 ++ > drivers/phy/amlogic/Makefile | 1 + > .../amlogic/phy-meson-g12a-mipi-dphy-analog.c | 177 ++++++++++++++++++ > 3 files changed, 190 insertions(+) > create mode 100644 drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > index 486ca23aba32..e4d1170efd54 100644 > --- a/drivers/phy/amlogic/Kconfig > +++ b/drivers/phy/amlogic/Kconfig > @@ -59,6 +59,18 @@ config PHY_MESON_G12A_USB3_PCIE > in Meson G12A SoCs. > If unsure, say N. > > +config PHY_MESON_G12A_MIPI_DPHY_ANALOG this should be sorted alphabetically, so before PHY_MESON_G12A_USB3_PCIE > + tristate "Meson G12A MIPI Analog DPHY driver" > + default ARCH_MESON > + depends on OF && (ARCH_MESON || COMPILE_TEST) > + select GENERIC_PHY > + select REGMAP_MMIO > + select GENERIC_PHY_MIPI_DPHY > + help > + Enable this to support the Meson MIPI Analog DPHY found in Meson G12A > + SoCs. > + If unsure, say N. > + > config PHY_MESON_AXG_PCIE > tristate "Meson AXG PCIE PHY driver" > default ARCH_MESON > diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile > index c0886c850bb0..91e3b9790c03 100644 > --- a/drivers/phy/amlogic/Makefile > +++ b/drivers/phy/amlogic/Makefile > @@ -4,6 +4,7 @@ obj-$(CONFIG_PHY_MESON8B_USB2) += phy-meson8b-usb2.o > obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o > obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o > obj-$(CONFIG_PHY_MESON_G12A_USB3_PCIE) += phy-meson-g12a-usb3-pcie.o > +obj-$(CONFIG_PHY_MESON_G12A_MIPI_DPHY_ANALOG) += phy-meson-g12a-mipi-dphy-analog.o > obj-$(CONFIG_PHY_MESON_AXG_PCIE) += phy-meson-axg-pcie.o > obj-$(CONFIG_PHY_MESON_AXG_MIPI_PCIE_ANALOG) += phy-meson-axg-mipi-pcie-analog.o > obj-$(CONFIG_PHY_MESON_AXG_MIPI_DPHY) += phy-meson-axg-mipi-dphy.o > diff --git a/drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c b/drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c > new file mode 100644 > index 000000000000..adfcca38a952 > --- /dev/null > +++ b/drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c > @@ -0,0 +1,177 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Meson G12A MIPI DSI Analog PHY > + * > + * Copyright (C) 2018 Amlogic, Inc. All rights reserved > + * Copyright (C) 2020 BayLibre, SAS 2022 now? > + * Author: Neil Armstrong > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define HHI_MIPI_CNTL0 0x00 > +#define HHI_MIPI_CNTL0_DIF_REF_CTL1 GENMASK(31, 16) > +#define HHI_MIPI_CNTL0_DIF_REF_CTL0 GENMASK(15, 0) > + > +#define HHI_MIPI_CNTL1 0x04 > +#define HHI_MIPI_CNTL1_BANDGAP BIT(16) > +#define HHI_MIPI_CNTL2_DIF_REF_CTL2 GENMASK(15, 0) > + > +#define HHI_MIPI_CNTL2 0x08 > +#define HHI_MIPI_CNTL2_DIF_TX_CTL1 GENMASK(31, 16) > +#define HHI_MIPI_CNTL2_CH_EN GENMASK(15, 11) > +#define HHI_MIPI_CNTL2_DIF_TX_CTL0 GENMASK(10, 0) > + > +#define DSI_LANE_0 BIT(4) > +#define DSI_LANE_1 BIT(3) > +#define DSI_LANE_CLK BIT(2) > +#define DSI_LANE_2 BIT(1) > +#define DSI_LANE_3 BIT(0) > + > +struct phy_g12a_mipi_dphy_analog_priv { > + struct phy *phy; > + struct regmap *regmap; > + struct phy_configure_opts_mipi_dphy config; > +}; > + > +static int phy_g12a_mipi_dphy_analog_configure(struct phy *phy, > + union phy_configure_opts *opts) > +{ > + struct phy_g12a_mipi_dphy_analog_priv *priv = phy_get_drvdata(phy); > + int ret; > + > + ret = phy_mipi_dphy_config_validate(&opts->mipi_dphy); > + if (ret) > + return ret; > + > + memcpy(&priv->config, opts, sizeof(priv->config)); > + > + return 0; > +} > + > +static int phy_g12a_mipi_dphy_analog_power_on(struct phy *phy) > +{ > + struct phy_g12a_mipi_dphy_analog_priv *priv = phy_get_drvdata(phy); > + unsigned int reg; > + > + regmap_write(priv->regmap, HHI_MIPI_CNTL0, > + FIELD_PREP(HHI_MIPI_CNTL0_DIF_REF_CTL0, 0x8) | > + FIELD_PREP(HHI_MIPI_CNTL0_DIF_REF_CTL1, 0xa487)); > + > + regmap_write(priv->regmap, HHI_MIPI_CNTL1, > + FIELD_PREP(HHI_MIPI_CNTL2_DIF_REF_CTL2, 0x2e) | > + HHI_MIPI_CNTL1_BANDGAP); > + > + regmap_write(priv->regmap, HHI_MIPI_CNTL2, > + FIELD_PREP(HHI_MIPI_CNTL2_DIF_TX_CTL0, 0x459) | > + FIELD_PREP(HHI_MIPI_CNTL2_DIF_TX_CTL1, 0x2680)); > + > + reg = DSI_LANE_CLK; > + switch (priv->config.lanes) { > + case 4: > + reg |= DSI_LANE_3; > + fallthrough; > + case 3: > + reg |= DSI_LANE_2; > + fallthrough; > + case 2: > + reg |= DSI_LANE_1; > + fallthrough; > + case 1: > + reg |= DSI_LANE_0; > + break; > + default: > + reg = 0; > + } > + > + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL2, > + HHI_MIPI_CNTL2_CH_EN, > + FIELD_PREP(HHI_MIPI_CNTL2_CH_EN, reg)); > + > + return 0; > +} > + > +static int phy_g12a_mipi_dphy_analog_power_off(struct phy *phy) > +{ > + struct phy_g12a_mipi_dphy_analog_priv *priv = phy_get_drvdata(phy); > + > + regmap_write(priv->regmap, HHI_MIPI_CNTL0, 0); > + regmap_write(priv->regmap, HHI_MIPI_CNTL1, 0); > + regmap_write(priv->regmap, HHI_MIPI_CNTL2, 0); > + > + return 0; > +} > + > +static const struct phy_ops phy_g12a_mipi_dphy_analog_ops = { > + .configure = phy_g12a_mipi_dphy_analog_configure, > + .power_on = phy_g12a_mipi_dphy_analog_power_on, > + .power_off = phy_g12a_mipi_dphy_analog_power_off, > + .owner = THIS_MODULE, > +}; > + > +static int phy_g12a_mipi_dphy_analog_probe(struct platform_device *pdev) > +{ > + struct phy_provider *phy; > + struct device *dev = &pdev->dev; > + struct phy_g12a_mipi_dphy_analog_priv *priv; > + struct device_node *np = dev->of_node; > + struct regmap *map; > + int ret; > + > + priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + /* Get the hhi system controller node */ > + map = syscon_node_to_regmap(of_get_parent(dev->of_node)); > + if (IS_ERR(map)) { > + dev_err(dev, > + "failed to get HHI regmap\n"); > + return PTR_ERR(map); > + } > + > + priv->regmap = map; > + > + priv->phy = devm_phy_create(dev, np, &phy_g12a_mipi_dphy_analog_ops); > + if (IS_ERR(priv->phy)) { > + ret = PTR_ERR(priv->phy); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "failed to create PHY\n"); log the error ? > + return ret; > + } > + > + phy_set_drvdata(priv->phy, priv); > + dev_set_drvdata(dev, priv); > + > + phy = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + > + return PTR_ERR_OR_ZERO(phy); > +} > + > +static const struct of_device_id phy_g12a_mipi_dphy_analog_of_match[] = { > + { > + .compatible = "amlogic,g12a-mipi-dphy-analog", > + }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, phy_g12a_mipi_dphy_analog_of_match); > + > +static struct platform_driver phy_g12a_mipi_dphy_analog_driver = { > + .probe = phy_g12a_mipi_dphy_analog_probe, > + .driver = { > + .name = "phy-meson-g12a-mipi-dphy-analog", > + .of_match_table = phy_g12a_mipi_dphy_analog_of_match, > + }, > +}; > +module_platform_driver(phy_g12a_mipi_dphy_analog_driver); > + > +MODULE_AUTHOR("Neil Armstrong "); > +MODULE_DESCRIPTION("Meson G12A MIPI Analog D-PHY driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.25.1 -- ~Vinod _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic