* [PATCH] thermal: amlogic: Rename Uptat to uptat to follow kernel coding style
@ 2025-03-25 19:30 Enrique Isidoro Vazquez Ramos
2025-04-18 10:15 ` Daniel Lezcano
0 siblings, 1 reply; 3+ messages in thread
From: Enrique Isidoro Vazquez Ramos @ 2025-03-25 19:30 UTC (permalink / raw)
To: glaroque, rafael, daniel.lezcano, rui.zhang, lukasz.luba,
linux-pm, linux-amlogic, linux-kernel
The variable Uptat uses CamelCase, which violates the kernel's coding
style that mandates snake_case for variable names. This is a purely
cosmetic change with no functional impact.
Compilation tested with:
- checkpatch.pl --strict passed (no new warnings/errors).
Signed-off-by: Enrique Isidoro Vazquez Ramos <kike.correo99.f@gmail.com>
---
drivers/thermal/amlogic_thermal.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index 3c5f7dbddf2c..5448d772db12 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -7,10 +7,10 @@
*
* Register value to celsius temperature formulas:
* Read_Val m * U
- * U = ---------, Uptat = ---------
+ * U = ---------, uptat = ---------
* 2^16 1 + n * U
*
- * Temperature = A * ( Uptat + u_efuse / 2^16 )- B
+ * Temperature = A * ( uptat + u_efuse / 2^16 )- B
*
* A B m n : calibration parameters
* u_efuse : fused calibration value, it's a signed 16 bits value
@@ -112,7 +112,7 @@ static int amlogic_thermal_code_to_millicelsius(struct amlogic_thermal *pdata,
const struct amlogic_thermal_soc_calib_data *param =
pdata->data->calibration_parameters;
int temp;
- s64 factor, Uptat, uefuse;
+ s64 factor, uptat, uefuse;
uefuse = pdata->trim_info & TSENSOR_TRIM_SIGN_MASK ?
~(pdata->trim_info & TSENSOR_TRIM_TEMP_MASK) + 1 :
@@ -121,12 +121,12 @@ static int amlogic_thermal_code_to_millicelsius(struct amlogic_thermal *pdata,
factor = param->n * temp_code;
factor = div_s64(factor, 100);
- Uptat = temp_code * param->m;
- Uptat = div_s64(Uptat, 100);
- Uptat = Uptat * BIT(16);
- Uptat = div_s64(Uptat, BIT(16) + factor);
+ uptat = temp_code * param->m;
+ uptat = div_s64(uptat, 100);
+ uptat = uptat * BIT(16);
+ uptat = div_s64(uptat, BIT(16) + factor);
- temp = (Uptat + uefuse) * param->A;
+ temp = (uptat + uefuse) * param->A;
temp = div_s64(temp, BIT(16));
temp = (temp - param->B) * 100;
--
2.39.5
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: amlogic: Rename Uptat to uptat to follow kernel coding style
2025-03-25 19:30 [PATCH] thermal: amlogic: Rename Uptat to uptat to follow kernel coding style Enrique Isidoro Vazquez Ramos
@ 2025-04-18 10:15 ` Daniel Lezcano
[not found] ` <CANfmkGDVks5tqgDw0ZvNMxT_vfD8rUKyZZJ4LUK6k637wt7=-A@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lezcano @ 2025-04-18 10:15 UTC (permalink / raw)
To: Enrique Isidoro Vazquez Ramos
Cc: glaroque, rafael, rui.zhang, lukasz.luba, linux-pm, linux-amlogic,
linux-kernel
On Tue, Mar 25, 2025 at 01:30:44PM -0600, Enrique Isidoro Vazquez Ramos wrote:
> The variable Uptat uses CamelCase, which violates the kernel's coding
> style that mandates snake_case for variable names. This is a purely
> cosmetic change with no functional impact.
>
> Compilation tested with:
> - checkpatch.pl --strict passed (no new warnings/errors).
>
> Signed-off-by: Enrique Isidoro Vazquez Ramos <kike.correo99.f@gmail.com>
> ---
Applied, thanks
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: amlogic: Rename Uptat to uptat to follow kernel coding style
[not found] ` <CANfmkGDVks5tqgDw0ZvNMxT_vfD8rUKyZZJ4LUK6k637wt7=-A@mail.gmail.com>
@ 2025-04-30 9:26 ` Daniel Lezcano
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2025-04-30 9:26 UTC (permalink / raw)
To: Enrique
Cc: glaroque, rafael, rui.zhang, lukasz.luba, linux-pm, linux-amlogic,
linux-kernel
On 28/04/2025 20:47, Enrique wrote:
> Hi Daniel,
>
> Thank you for applying my patch! I’m trying to verify where it was merged.
> Could you confirm if it’s in the `staging-testing` branch or another tree?
>
> Commit hash: 84fe0cc6fddb6afcdca838d80756080f84cf9ecd
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/commit/?h=thermal/linux-next&id=b8e05d5de934c037594f4ad3550b8228da1b9c2d
> Best regards,
> Enrique Vazquez
>
>
> El vie, 18 abr 2025 a la(s) 4:15 a.m., Daniel Lezcano
> (daniel.lezcano@linaro.org <mailto:daniel.lezcano@linaro.org>) escribió:
>
> On Tue, Mar 25, 2025 at 01:30:44PM -0600, Enrique Isidoro Vazquez
> Ramos wrote:
> > The variable Uptat uses CamelCase, which violates the kernel's coding
> > style that mandates snake_case for variable names. This is a purely
> > cosmetic change with no functional impact.
> >
> > Compilation tested with:
> > - checkpatch.pl <http://checkpatch.pl> --strict passed (no new
> warnings/errors).
> >
> > Signed-off-by: Enrique Isidoro Vazquez Ramos
> <kike.correo99.f@gmail.com <mailto:kike.correo99.f@gmail.com>>
> > ---
>
> Applied, thanks
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-30 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-25 19:30 [PATCH] thermal: amlogic: Rename Uptat to uptat to follow kernel coding style Enrique Isidoro Vazquez Ramos
2025-04-18 10:15 ` Daniel Lezcano
[not found] ` <CANfmkGDVks5tqgDw0ZvNMxT_vfD8rUKyZZJ4LUK6k637wt7=-A@mail.gmail.com>
2025-04-30 9:26 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).