From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: pwm-meson: remove not needed check in meson_pwm_calc
Date: Thu, 4 May 2023 11:11:36 +0200 [thread overview]
Message-ID: <ZFN2yNr5GwVwwcHI@orome> (raw)
In-Reply-To: <20230504064730.gaguyecx4q7duatk@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1181 bytes --]
On Thu, May 04, 2023 at 08:47:30AM +0200, Uwe Kleine-König wrote:
> Hello Heiner,
>
> On Thu, May 04, 2023 at 07:35:55AM +0200, Heiner Kallweit wrote:
> > duty <= period implies that duty_cnt <= cnt. We verified before
> > that cnt <= 0xffff, therefore we can omit the check here.
> >
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > ---
> > Note: Applies only after "pwm: pwm-meson: fix handling of period/duty if greater than UINT_MAX"
>
> Do you know there is git magic to express this that (at least some of)
> the build bots understand? Look at git format-patch's --base option.
I think --base is really only applicable if the base patch is applied to
a well-known tree, otherwise the commit is unknown.
For things like this it's easier to just send them out as a series,
which implies the dependency. Obviously sometimes you get situations
where you send out a patch and only then realize there's cleanup you
can do, so mentioning this is usually enough. Most bots will end up
building this after I apply as well, so we'll get the coverage either
way.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-05-04 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 5:35 [PATCH] pwm: pwm-meson: remove not needed check in meson_pwm_calc Heiner Kallweit
2023-05-04 6:47 ` Uwe Kleine-König
2023-05-04 9:11 ` Thierry Reding [this message]
2023-05-04 9:42 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFN2yNr5GwVwwcHI@orome \
--to=thierry.reding@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox