From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v3 5/5] meson saradc: support reading from channel 7 mux inputs
Date: Wed, 28 Jun 2023 13:06:00 +0300 [thread overview]
Message-ID: <ZJwGCNA+ZURri24i@smile.fi.intel.com> (raw)
In-Reply-To: <20230627224017.1724097-6-gnstark@sberdevices.ru>
On Wed, Jun 28, 2023 at 01:37:18AM +0300, George Stark wrote:
> Add iio channel for every channel 7 mux input.
> Meson saradc channel 7 is connected to a mux that can switch channel
> input to well-known sources like Vdd, GND and several Vdd dividers.
...
> +static enum meson_sar_adc_chan7_mux_sel chan7_mux_values[] = {
> + CHAN7_MUX_VSS,
> + CHAN7_MUX_VDD_DIV4,
> + CHAN7_MUX_VDD_DIV2,
> + CHAN7_MUX_VDD_MUL3_DIV4,
> + CHAN7_MUX_VDD,
> +};
> +
> +static const char * const chan7_mux_names[] = {
> + "gnd",
> + "0.25vdd",
> + "0.5vdd",
> + "0.75vdd",
> + "vdd",
For the sake of robustness you can assign like this
[CHAN7_MUX_VDD_DIV2] = "0.5vdd",
> };
...
> - if (chan->type == IIO_VOLTAGE)
> - return sprintf(label, "channel-%d\n", chan->channel);
> + if (chan->type == IIO_VOLTAGE) {
> + if (chan->channel <= NUM_CHAN_7)
I believe you can get rid of this conditional and make diff less ping-pong-ish,
see below.
> + return sprintf(label, "channel-%d\n", chan->channel);
> + if (chan->channel >= NUM_MUX_0_VSS)
> + return sprintf(label, "%s\n",
> + chan7_mux_names[chan->channel - NUM_MUX_0_VSS]);
> + }
if (chan->type == IIO_VOLTAGE && chan->channel >= NUM_MUX_0_VSS)
return sprintf(label, "%s\n", chan7_mux_names[chan->channel - NUM_MUX_0_VSS]);
if (chan->type == IIO_VOLTAGE)
return sprintf(label, "channel-%d\n", chan->channel);
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-06-28 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 22:37 [PATCH v3 0/5] meson saradc: add iio channels to read channel 7 mux inputs George Stark
2023-06-27 22:37 ` [PATCH v3 1/5] meson saradc: move enums declaration before variables declaration George Stark
2023-07-02 9:14 ` Jonathan Cameron
2023-07-04 0:39 ` George Stark
2023-06-27 22:37 ` [PATCH v3 2/5] meson saradc: move meson_sar_adc_set_chan7_mux routine upper George Stark
2023-06-27 22:37 ` [PATCH v3 3/5] meson saradc: add enum for iio channel numbers George Stark
2023-06-27 22:37 ` [PATCH v3 4/5] meson saradc: add channel labels George Stark
2023-07-02 9:16 ` Jonathan Cameron
2023-07-04 1:32 ` George Stark
2023-06-27 22:37 ` [PATCH v3 5/5] meson saradc: support reading from channel 7 mux inputs George Stark
2023-06-28 10:06 ` Andy Shevchenko [this message]
2023-07-02 9:21 ` Jonathan Cameron
2023-07-03 19:39 ` Martin Blumenstingl
2023-07-04 8:08 ` George Stark
[not found] ` <6ee38b3a-8e2f-15d6-f7bd-06ef567d2b68@sberdevices.ru>
2023-07-05 8:04 ` Jonathan Cameron
2023-07-02 9:11 ` [PATCH v3 0/5] meson saradc: add iio channels to read " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJwGCNA+ZURri24i@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gnstark@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).