From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EC8BC46CD2 for ; Sat, 27 Jan 2024 18:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NwzlzWdX7M27jHvD3tTiB02u9vr+QO7UBai/164RIvU=; b=ow4jJxwDFGc77q JgSGk/ED5mY8t/YZC/TSzqoipllx86tm2vLbTDIf+unEngwzupl1RWdkJHshtl7qGuv+2khGaKauT e13S3SZqn0mx+wiMAiz7gnXeq5zBzEr38SscreYmlbKEiyejJknvyFlJtE6TQN8nv/3fImqF+fr3x x249ao5U4eUTtYRz9+226HVyrvXWYj20jaFsRvxIRm0bMG6wPx65ULF2Hi9t8JAjeVNnvRPJVG07l 9TlMDv03sdj5q9+w9oDvCqAhZrm1mUfMdF9UqtTwO9MYxkld0V3zzeAZfOXSV20R+X1Qi7TBsyq5n WB1jSCE8jM1zCQ59Dxvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTnhJ-000000080xa-0Rkd; Sat, 27 Jan 2024 18:46:33 +0000 Received: from mgamail.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTnhG-000000080wi-2zSh; Sat, 27 Jan 2024 18:46:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706381190; x=1737917190; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EYPyaz87RkOJljahQF8funE2XdsGXXg6gukJ+v+90GA=; b=Wb9Ewt5uzMlHwOUQEMD4+2k7ervB3L2rZNZ1hFes6snsoLS13GCbi701 CbZjjKQO6r9kfprjBtKJnyOTR6tfc/C4jvo9Wb9++wyFGQTgRGX7r4tq6 ECNmy4IuQeH4h9v4r3iRo0MD5wYMPdn3mW6PcmdSMQFWqrdjnpXnNv07J x7fwe/C8lEslklDFgv3Bg7Yku0rz9OmAD4zFVrj3fVvUNAnYBYLb9zf4U DmS1Mu19jwK1XxE4mMD+iVL9/hjv56Fjtsg1MfLp4ikJVb24OZoTioI+T SVdHoqvyyOZeLJaxeMTREHiwgiayAvrkXqZo3c7R8daJr9L5M7gSzvIrG A==; X-IronPort-AV: E=McAfee;i="6600,9927,10966"; a="466977476" X-IronPort-AV: E=Sophos;i="6.05,220,1701158400"; d="scan'208";a="466977476" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2024 10:46:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10966"; a="910649621" X-IronPort-AV: E=Sophos;i="6.05,220,1701158400"; d="scan'208";a="910649621" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2024 10:46:16 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 4755F11FB1F; Sat, 27 Jan 2024 20:40:25 +0200 (EET) Date: Sat, 27 Jan 2024 18:40:25 +0000 From: Sakari Ailus To: Randy Dunlap Cc: Ricardo Ribalda , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Laurent Pinchart , Hans Verkuil , Hans Verkuil , Kieran Bingham , Bin Liu , Ezequiel Garcia , Philipp Zabel , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , Andrzej Hajda , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 03/17] media: media-entity.h: Fix kerneldoc Message-ID: References: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> <20240126-gix-mtk-warnings-v1-3-eed7865fce18@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_104630_823413_97269A15 X-CRM114-Status: GOOD ( 26.33 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Randy, On Fri, Jan 26, 2024 at 05:51:06PM -0800, Randy Dunlap wrote: > > > On 1/26/24 15:16, Ricardo Ribalda wrote: > > The fields seems to be documented twice. > > > > Signed-off-by: Ricardo Ribalda > > --- > > include/media/media-entity.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > > index 2b6cd343ee9e..c79176ed6299 100644 > > --- a/include/media/media-entity.h > > +++ b/include/media/media-entity.h > > @@ -337,10 +337,6 @@ enum media_entity_type { > > * @info.dev: Contains device major and minor info. > > * @info.dev.major: device node major, if the device is a devnode. > > * @info.dev.minor: device node minor, if the device is a devnode. > > - * @major: Devnode major number (zero if not applicable). Kept just > > - * for backward compatibility. > > - * @minor: Devnode minor number (zero if not applicable). Kept just > > - * for backward compatibility. > > * > > * .. note:: > > * > > > > I'd say that this is correct based on > https://patchwork.kernel.org/project/linux-media/patch/20231223050707.14091-1-rdunlap@infradead.org/ > > > Hans, can you please explain this message from you, on 2024-Jan-22, that > I cannot find in the media patchwork: It's in linuxtv.org Patchwork here and also in the media stage tree (as indicated by the state) but not yet in master AFAIU. > > > Subject: [git:media_stage/master] media: media-entity.h: fix Excess kernel-doc description warnings > > > > This is an automatic generated email to let you know that the following patch were queued: > > Subject: media: media-entity.h: fix Excess kernel-doc description warnings > Author: Randy Dunlap > Date: Fri Dec 22 21:07:07 2023 -0800 > > Remove the @major: and @minor: lines to prevent the kernel-doc warnings: > > include/media/media-entity.h:376: warning: Excess struct member 'major' description in 'media_entity' > include/media/media-entity.h:376: warning: Excess struct member 'minor' description in 'media_entity' > > Signed-off-by: Randy Dunlap > Reviewed-by: Laurent Pinchart > Signed-off-by: Sakari Ailus > Signed-off-by: Hans Verkuil > > include/media/media-entity.h | 4 ---- > 1 file changed, 4 deletions(-) > > --- > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index 2b6cd343ee9e..c79176ed6299 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -337,10 +337,6 @@ enum media_entity_type { > * @info.dev: Contains device major and minor info. > * @info.dev.major: device node major, if the device is a devnode. > * @info.dev.minor: device node minor, if the device is a devnode. > - * @major: Devnode major number (zero if not applicable). Kept just > - * for backward compatibility. > - * @minor: Devnode minor number (zero if not applicable). Kept just > - * for backward compatibility. > * > * .. note:: > * > > > > Thanks. -- Regards, Sakari Ailus _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic