From: hkallweit1@gmail.com (Heiner Kallweit)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 00/12] i2c: meson: series with improvements
Date: Wed, 8 Mar 2017 21:49:15 +0100 [thread overview]
Message-ID: <a809a238-11fe-410b-fee8-a941109d49b9@gmail.com> (raw)
In-Reply-To: <1488965640.2514.14.camel@baylibre.com>
Am 08.03.2017 um 10:34 schrieb Jerome Brunet:
> On Wed, 2017-03-08 at 07:41 +0100, Heiner Kallweit wrote:
>> This patch series includes several improvements for the i2c-meson
>> driver.
>
> Heiner, Could give us a some details about how you tested this series (platform,
> board, i2c devices, exemple of transfers, etc ...). The more details you give,
> the easiest it is to be confident about the patches.
>
Sure. System is Odroid C2 and I test with a DS3231-based RTC module connected
to I2C-A (driver rtc-ds1307). Bus speed is set to 400 kHz.
That's the debug messages (with the patch series applied) from the interrupt
handler when booting the system and setting the system clock from RTC.
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 1, ctrl 05869031
meson-i2c c1108500.i2c: irq: state 1, pos 0, count 2, ctrl 07869251
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 2, ctrl 07869051
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 1, ctrl 05869031
meson-i2c c1108500.i2c: irq: state 1, pos 0, count 8, ctrl 078698b1
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 1, ctrl 05869031
meson-i2c c1108500.i2c: irq: state 1, pos 0, count 7, ctrl 078697a1
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 1, ctrl 05869031
meson-i2c c1108500.i2c: irq: state 1, pos 0, count 7, ctrl 078697a1
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 1, ctrl 05869031
meson-i2c c1108500.i2c: irq: state 1, pos 0, count 7, ctrl 078697a1
meson-i2c c1108500.i2c: irq: state 2, pos 0, count 1, ctrl 05869031
meson-i2c c1108500.i2c: irq: state 1, pos 0, count 1, ctrl 07869141
> Personally, I don't have test case representative enough to test this series
> thoroughly.
>
>>
>> Heiner Kallweit (12):
>> i2c: meson: use min instead of min_t where min_t isn't needed
>> i2c: meson: remove member irq from struct meson_i2c
>> i2c: meson: use i2c core for DT clock-frequency parsing
>> i2c: meson: use full 12 bits for clock divider
>> i2c: meson: set clock divider in probe instead of setting it for each
>> transfer
>> i2c: meson: remove variable count from meson_i2c_xfer
>> i2c: meson: improve interrupt handler and detect spurious interrupts
>> i2c: meson: explicitly ignore messages with length zero
>> i2c: meson: don't create separate token chain just for the stop command
>> i2c: meson: remove meson_i2c_write_tokens
>> i2c: meson: improve and simplify interrupt handler
>> i2c: meson: use state in meson_i2c_prepare_xfer
>>
>> drivers/i2c/busses/i2c-meson.c | 157 ++++++++++++++++----------------------
>> ---
>> 1 file changed, 62 insertions(+), 95 deletions(-)
>>
>
prev parent reply other threads:[~2017-03-08 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 6:41 [PATCH 00/12] i2c: meson: series with improvements Heiner Kallweit
2017-03-08 6:42 ` [PATCH 01/12] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit
2017-03-08 9:25 ` Jerome Brunet
2017-03-08 6:43 ` [PATCH 02/12] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit
2017-03-08 9:07 ` Jerome Brunet
2017-03-08 6:44 ` [PATCH 03/12] i2c: meson: use i2c core for DT clock-frequency parsing Heiner Kallweit
2017-03-08 9:10 ` Jerome Brunet
2017-03-08 6:44 ` [PATCH 04/12] i2c: meson: use full 12 bits for clock divider Heiner Kallweit
2017-03-08 9:19 ` Jerome Brunet
2017-03-08 6:45 ` [PATCH 05/12] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit
2017-03-08 6:46 ` [PATCH 06/12] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit
2017-03-08 9:28 ` Jerome Brunet
2017-03-08 6:47 ` [PATCH 07/12] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit
2017-03-08 9:50 ` Jerome Brunet
2017-03-08 21:02 ` Heiner Kallweit
2017-03-09 20:16 ` Heiner Kallweit
2017-03-08 6:47 ` [PATCH 08/12] i2c: meson: explicitly ignore messages with length zero Heiner Kallweit
[not found] ` <CANe6Qb9nKdLnOcwEwuk8NXEB+fxW2S_kkzP+U+qygYhNqz0Y0w@mail.gmail.com>
2017-03-08 22:03 ` Heiner Kallweit
2017-03-08 6:48 ` [PATCH 09/12] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit
2017-03-08 6:49 ` [PATCH 10/12] i2c: meson: remove meson_i2c_write_tokens Heiner Kallweit
2017-03-08 6:49 ` [PATCH 11/12] i2c: meson: improve and simplify interrupt handler Heiner Kallweit
2017-03-08 6:50 ` [PATCH 12/12] i2c: meson: use state in meson_i2c_prepare_xfer Heiner Kallweit
2017-03-08 9:34 ` [PATCH 00/12] i2c: meson: series with improvements Jerome Brunet
2017-03-08 20:49 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a809a238-11fe-410b-fee8-a941109d49b9@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).