From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 3/6] serial: meson: remove unneeded variable assignment in meson_serial_port_write
Date: Mon, 17 Apr 2017 14:58:13 +0100 [thread overview]
Message-ID: <a9179fc6-9ca6-c153-0b60-db1365cfb18c@codethink.co.uk> (raw)
In-Reply-To: <c1371fc8-ebc2-0d14-e409-02e2fbf3ba94@gmail.com>
On 16/04/17 21:13, Heiner Kallweit wrote:
> AML_UART_TX_EN is set in meson_uart_startup and there's no place in
> the driver where it gets cleared. Therefore we don't have to set it
> here.
I think this is a leftover of the patches I did when trying to fix
the UART driver when using debian/systemd and having strange console
problems.
The only comment is it might be worth leaving this in as it isn't
a high cost to the driver and it is possible someone might accidentally
clear it later.
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/tty/serial/meson_uart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 22857f1e..714b29ad 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -497,7 +497,6 @@ static void meson_serial_port_write(struct uart_port *port, const char *s,
> }
>
> val = readl(port->membase + AML_UART_CONTROL);
> - val |= AML_UART_TX_EN;
> tmp = val & ~(AML_UART_TX_INT_EN | AML_UART_RX_INT_EN);
> writel(tmp, port->membase + AML_UART_CONTROL);
>
>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2017-04-17 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 20:02 [PATCH 0/6] serial: meson: series with smaller fixes and improvements Heiner Kallweit
2017-04-16 20:06 ` [PATCH 1/6] serial: meson: fix setting number of stop bits Heiner Kallweit
2017-04-17 15:24 ` Neil Armstrong
2017-04-17 15:54 ` Heiner Kallweit
2017-04-21 22:03 ` Kevin Hilman
2017-04-16 20:10 ` [PATCH 2/6] serial: meson: remove dead code in meson_uart_change_speed Heiner Kallweit
2017-04-17 15:25 ` Neil Armstrong
2017-04-17 15:54 ` Andreas Färber
2017-04-16 20:13 ` [PATCH 3/6] serial: meson: remove unneeded variable assignment in meson_serial_port_write Heiner Kallweit
2017-04-17 13:58 ` Ben Dooks [this message]
2017-04-17 15:27 ` Neil Armstrong
2017-04-17 15:37 ` Andreas Färber
2017-04-17 16:03 ` Heiner Kallweit
2017-04-19 8:39 ` Neil Armstrong
2017-04-16 20:15 ` [PATCH 4/6] serial: meson: make use of uart_port member mapsize Heiner Kallweit
2017-04-17 13:53 ` Ben Dooks
2017-04-17 15:28 ` Neil Armstrong
2017-04-16 20:21 ` [PATCH 5/6] serial: meson: remove use of flag UPF_IOREMAP Heiner Kallweit
2017-04-17 15:28 ` Neil Armstrong
2017-04-16 20:23 ` [PATCH 6/6] serial: meson: change interrupt description to of node name Heiner Kallweit
2017-04-17 13:52 ` Ben Dooks
2017-04-17 15:29 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9179fc6-9ca6-c153-0b60-db1365cfb18c@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).