From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C552C83038 for ; Tue, 1 Jul 2025 18:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2h4MJxYb6RP+Ym/revuCovZ1zBzeuqS4dQjdJwHoT+0=; b=ecfSX2PYnIT0VH UNAtnrkBeG6j3vv42HwZ0hFUZfsdtvbs861Os1+LByitU+cM8XqYfJY5JoFUQU7PB5/GNzEnP+vm1 fihtfs0fNH/ammkV0V4oFH88LSj3N4q2X9EjnlFpBtFBaPbffCNHdkKyiuwnmpMD5UYncu2LO66Lh IY6vRBIz7ypTmWpx5XVlXL/FE0x0dNfiyuzwGr3mo32YLo9CtgYYg+xVcT7/T/8tqzawnpKyPYAPi OEO2mO51fvgc4x6FcDrI6E/l4ShazRMxdBiZP5YokQW4WwFa7g7t0RMf4URIaSeWtvfiMHeG/2j2r thLQrpHyOB0Z2Jjmk1Zg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWfJc-00000006I97-2vXg; Tue, 01 Jul 2025 18:02:44 +0000 Received: from mail-qv1-xf29.google.com ([2607:f8b0:4864:20::f29]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWcrZ-00000005sZZ-3rT2; Tue, 01 Jul 2025 15:25:39 +0000 Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-6fafdd322d3so38215446d6.3; Tue, 01 Jul 2025 08:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751383537; x=1751988337; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H69zG5gO7h9M6iKs5G+TtTbg5NtVZiozRw1J2ZHqQt8=; b=fzk1h6BCEI8LPPFqKo3vx5lm2kf5rIemtvaP9XjPa2TmeZL/nLgHrV7m9u+ovHgg8c 6f3GKrmoto2AixJnEs10LK9h69pIvbhwdMFHxSPRZUmIFeeIsuF8pbASy3fcCS4Mc0Wn Ew5V7UJC4FsOMyHuL03U+JyoKsfspBgwdiYIo3byJk3c/HMWZrgNsWbRrOJB2nlL+cUu +zjQZ5OhAZN6sSwcGvt3FxsxGt5C7Rmn/r0nTSSJ3REpAkgo4YTpF2cYDQ7aFHrT4Qie l5jwBcsvbWTT6p7JXlkM0X0GISCABp1InEOzD9JwDcj0ycGp1fqcb1sx4tFo5fvRUzyP xVgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751383537; x=1751988337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H69zG5gO7h9M6iKs5G+TtTbg5NtVZiozRw1J2ZHqQt8=; b=EcfwYkY5+tO0XG8kXqtdc076W1pJBdwaTE+r49tLvYqqCFIBsytd23MVmlRX5lGlZo jP5vDf9qtrlqde1NR7hcFZ8nEnMBEuUrLQYqUm0yU/o/nQq2TItx6/KMoHYSQo0ggTIq 22RdbO11lCtxZpc5iQ9+COWBUOCTLqeWhPUWzGASCPcoHioC4rmILEcdQB3aCl06k2Ec Yi50DDnGLjZNTyclS3cjNd4DzUGhyRV+JZCp4Sb3bh1fWGpfXT3wf1sTaNgGbMgRwvbM 66urYiJfGDy/f0JiHB1rZZbC07CF2FXOf3lGCyC5qOrZ8Rk7TIizux4gXQFVYHxDEEqe SSlg== X-Forwarded-Encrypted: i=1; AJvYcCU9IfheQqaRDQuT6h123AVUsSQzKy94lpp3++L3yP8EOsjD/v3F0q+Z/pJcHt5zCXgu3F3IYSIo+DiFccN8xgY=@lists.infradead.org, AJvYcCUw2IEJpm54lBEJPFoGF29J30PBWJmMGLbuz48kB9WWlRug4oWxzejvcIyl9sc2Rbeo38nW5pl5DxsD@lists.infradead.org, AJvYcCWkuDQ09Z+43kyIqq21j3Sjs4PpoWWaSigFuiKzDaG+IQsXJu7ooPHFfuE+oaShy8YvvRxn3QyVbH29GVPu@lists.infradead.org, AJvYcCXMQXlA/V70u6GuxBcC/ipjnou/wkZdgDT9OkH4ENp2Xuc8K6mizY89CYuoxkh172syoHRFaq9ZvVKVzDewGyo=@lists.infradead.org, AJvYcCXMwFeClWt0e+ykAjh1Mdv5I296SJDiJtxdR8mCMN355NCVYa/qv7BbrODn4ABzK5rdtV+Sqmu8pop0noKfGRxdwA==@lists.infradead.org X-Gm-Message-State: AOJu0Yz1CJMLRCUo9o1fo5Hu5dq1xHZnwYXKe85bzbId0sB58hyH29NT QR7wY+nGZfwCwWsQnhqgqj71jYyxh7ANqVASWjTz2LwueCL1Tdxs+wgz X-Gm-Gg: ASbGncsv4hTuxCnUsZXINKXwzKb+L6xDUxpZCfB4PmVlZok5OlsqOE8IHSzE32utws0 5dJj+xU7Aw6PC2oyzApAerH/JJOvtso+E3Ha04ITCxo4kvNYYBfpvo1AnN9p+ziLaXm/GVKCdDz rUVw9RplGM+0EtT0VUlZB1TGrtV+ypGCCiMtwqBVK5g+9qCUgqQ8GctO4AbFkqnox2cYpViehJy kuGiZHrk7A7100wf0NffZvSg+dVnzh2NceqtI+OsKW+fEzPIvg7i6ecR+UI/US7mJ1UI/EoAs0c qEHaNlFgFVThxGQsxO2Sn/YHKSnzMQyFgoUXIyMuKRHrlKSzov2aucS+A91U X-Google-Smtp-Source: AGHT+IFGwV5rgzZNlThD3qZhxiETqJeu0UK36HZAls92ncvO2dh0OxLl48BruxfcxiFAUDT+MVUh3g== X-Received: by 2002:a05:6214:d08:b0:6e8:fbb7:675b with SMTP id 6a1803df08f44-7000291854amr270803556d6.32.1751383536220; Tue, 01 Jul 2025 08:25:36 -0700 (PDT) Received: from geday ([2804:7f2:800b:517d::dead:c001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd771acfe6sm85521916d6.31.2025.07.01.08.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 08:25:35 -0700 (PDT) Date: Tue, 1 Jul 2025 12:25:12 -0300 From: Geraldo Nascimento To: Waqar Hameed Cc: Vignesh Raghavendra , Julien Panis , William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , Peter Rosin , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Matthias Brugger , AngeloGioacchino Del Regno , Matteo Martelli , Heiko Stuebner , Francesco Dolcini , =?utf-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Hugo Villeneuve , Subhajit Ghosh , Mudit Sharma , Gerald Loacker , Song Qiang , Crt Mori , Dmitry Torokhov , Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sebastian Reichel , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Han Xu , Haibo Chen , Yogesh Gaur , Mark Brown , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Souradeep Chowdhury , Greg Kroah-Hartman , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , kernel@axis.com, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, imx@lists.linux.dev, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH] Remove error prints for devm_add_action_or_reset() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250701_082537_963138_1CEF01A4 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Jul 01, 2025 at 05:03:33PM +0200, Waqar Hameed wrote: > When `devm_add_action_or_reset()` fails, it is due to a failed memory > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do > anything when error is `-ENOMEM`. Therefore, remove the useless call to > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just > return the value instead. Hi Waqar, thank you for the patch. However I personally advise you to split the patches per-file and remember to then precede each individual patch subject with the proper subsystem and driver touched. While this looks like a nit-pick, it really isn't, and my suggestion will make reviewing much more easier and you'll get your Reviewed-by's and Acked-by's much more smoothly. The cover-letter should probably be preceded by "treewide" instead of a specific subsystem. Thank you, Geraldo Nascimento _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic