From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD351C8303C for ; Tue, 1 Jul 2025 19:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lKR0e7SDEh2v0ImBx73yjGfXJ0T5xhRP6/w+gbpIMQA=; b=v4ofmykIDxj7To WIp50TKPYmPXSMwM7Dr/O7+0PxzhIgGAaVBMh6iHHtynBGEYi0tvffagBc0jliO8CJisLOcLx/Mhf hc8a5YTkm5QknrVVdeIkK6vTjAgbS6qgQmJ37PoWJ0vv7vg244+T0ioviZfYDLaKz+y1rWHLlB3pF 4MKWTUMTYTYrrmAGgCkaIrMO/KaaHw/WlRjupiSuQGsulDYrmDOWLVvYKUiuyv60xl7WZwqPFopZG v98me7mTUtmFYvMYodgjBsrL+8xSHaROYv4NUvzqLGGVfn6iacLTuIM9BVpGHJq9quSKfE0gkuW0h SoUNYC3ENxmi8ZNnr59w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWgDQ-00000006PCa-445y; Tue, 01 Jul 2025 19:00:24 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWdnl-000000062CM-01zL; Tue, 01 Jul 2025 16:25:46 +0000 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7d45f5fde50so170855985a.2; Tue, 01 Jul 2025 09:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751387144; x=1751991944; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MwCrqmYe9TCJHuYWG2jCcUWVn5259lJARsV/a3PINFE=; b=lAsYTX5Q/b+rJKmHkojnbcUBDqsB9ytu+fhYKWzmWwNJlzCWFYgVES5ZbrKhTdviM6 VDRmXT8LyObUh/jbKHz7i5u1zzUa82H3RBjo++gK/unnXy+NQmF0zRqoLhqNWkb+e1ZI vsVO2M+ffNINvaXYC7OTgUukugegJ0rr4ciCuJMin6ZGLSJwwouRCYqLAnuuJFKR+uTD pCH8Avp6kw54rHrZgF9zaG8ECiRfaG0u919F/C5/MpUzncrAU8R2YsabnuK+NWqtGQ+Y v3ZbPrgazCjdagcviyfzgHAOjmADovYmyb0JFlYUBzrpVSQcHLJNXwecqthl2MbCIUig thgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751387144; x=1751991944; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MwCrqmYe9TCJHuYWG2jCcUWVn5259lJARsV/a3PINFE=; b=XQYXy+zWldHiBuIns2EtlPIjzIamKmUSjRheQBYZ0T3tsbMgnmiiGTU6o06Faq+pz5 D8HglteAq0PQOacRTjoIeZnpV5A7BqSKBdNZCV9NzHw8aerMVGSvHbUo8KyoWko53pyo Q7QkSFBQnikubGL+7AzV+drlUcrpwons5PYGY6mDvOvbuez50ZORm0cWkbb/OOslFTgf 7a+A9G/a/tc1sLvxH6X0yvGydQyqGKP7SGpLWPpudrE26AGEnU84JVdo0orhQVz+W0/Z AV07Y8hDjqiMaQbpW5BmKbc4aYcSxG1xjWwuNsGoxBZYrsv1QfOrQ7WiLEfHdaUnEDmg g9Wg== X-Forwarded-Encrypted: i=1; AJvYcCUKh8TeSfhhtBzC5nGJAcSCSat1dpJA7xMBF6gJw527FIDsvad5aE4h16zlhYM4NKr+sYNaj1jvoyqDT2/6MLA=@lists.infradead.org, AJvYcCULJJbxVwRbtzIK78BGRsMC9sYc1PjLI+noAd+cuRq2G6PpyeOD5htwGrYP+980iYPcr08cYjIOTQOh@lists.infradead.org, AJvYcCUMOqvntwMRqIpkaluQQWpvot6WwrPOpj09/W+dAgSV4qhtpqFEbt/kbeIjvJiq3jeR5ztBueDzhC+r/D8vmIWnbA==@lists.infradead.org, AJvYcCV3IeoCKjZGiMT8GtoTk+EvLV2k8bnvnAeLXyAyFlqpJVS0E8xCYM4mDM0wKkhy6jesA1DM2FGlKpcvDBjezjA=@lists.infradead.org, AJvYcCV8vXWSNrDhWuzR7SZyFeYNWxHSKY5hPPA/pv3XD/MHpJo7EdGCAJKWnsXV8KbKV1IJky4hQib8IpUpbYwF@lists.infradead.org X-Gm-Message-State: AOJu0YwEmsffPNIfxb3eTE6ixHo27IzX9+fqcxHkkxhTj6g6Vh4O63OB akSn/RFgLllXPsQxIwO/uKItHxz+kGZV4Y6zwrOJxdPcwFFmThFl02ay X-Gm-Gg: ASbGnctck+xuNSkRFKw0FQdEMq9CDUt+DPBvSMIab4iDckQ7MkyHkRivJi7pBwJHG+X e22ISRhYGN7CddTDcj+TZzz5l6u6Js/nrfeduhqL4tYMLQd6thtUzBrYvogVv8n0qYFTTcVdpKP 1Fe1N6/GrfcSbJupRkSJmAkJLpCOdjDmmLgi94NXtMFyA1sztabDM7r3Wv7OLRZHKwdpCzkQvUL e9sZrMrdVG4AVTdebShr38LY3MOvSy0mvXKv26cCrc576ZN4cBmzUjKhw6zsoU1SJioCyW4XKLL lDUUXQPUSTbJfHrV8hTm9Dc/7jnXbYmouqm8wAfAXWSchaxRMg== X-Google-Smtp-Source: AGHT+IFaquJkOuj7GD/t4hRYC7j2CE8mxqIujMtOYOepN4kjeXyf+EKHtvQBv03/JpyXmxYQUG4sHA== X-Received: by 2002:a05:620a:1a1a:b0:7c5:95e6:ce1d with SMTP id af79cd13be357-7d4438566f9mr2476294085a.0.1751387143543; Tue, 01 Jul 2025 09:25:43 -0700 (PDT) Received: from geday ([2804:7f2:800b:55e2::dead:c001]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd772e4305sm86349236d6.66.2025.07.01.09.25.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 09:25:43 -0700 (PDT) Date: Tue, 1 Jul 2025 13:25:19 -0300 From: Geraldo Nascimento To: Waqar Hameed Cc: Vignesh Raghavendra , Julien Panis , William Breathitt Gray , Linus Walleij , Bartosz Golaszewski , Peter Rosin , Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Matthias Brugger , AngeloGioacchino Del Regno , Matteo Martelli , Heiko Stuebner , Francesco Dolcini , =?utf-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Hugo Villeneuve , Subhajit Ghosh , Mudit Sharma , Gerald Loacker , Song Qiang , Crt Mori , Dmitry Torokhov , Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sebastian Reichel , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Han Xu , Haibo Chen , Yogesh Gaur , Mark Brown , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Souradeep Chowdhury , Greg Kroah-Hartman , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , kernel@axis.com, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, imx@lists.linux.dev, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH] Remove error prints for devm_add_action_or_reset() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250701_092545_046339_75702DD3 X-CRM114-Status: GOOD ( 24.85 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Jul 01, 2025 at 06:15:51PM +0200, Waqar Hameed wrote: > On Tue, Jul 01, 2025 at 12:25 -0300 Geraldo Nascimento wrote: > > > [Some people who received this message don't often get email from geraldogabriel@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > > > On Tue, Jul 01, 2025 at 05:03:33PM +0200, Waqar Hameed wrote: > >> When `devm_add_action_or_reset()` fails, it is due to a failed memory > >> allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do > >> anything when error is `-ENOMEM`. Therefore, remove the useless call to > >> `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just > >> return the value instead. > > > > Hi Waqar, > > > > thank you for the patch. However I personally advise you to split the > > patches per-file and remember to then precede each individual patch > > subject with the proper subsystem and driver touched. > > > > While this looks like a nit-pick, it really isn't, and my suggestion > > will make reviewing much more easier and you'll get your Reviewed-by's > > and Acked-by's much more smoothly. > > > > The cover-letter should probably be preceded by "treewide" instead of > > a specific subsystem. > > Thank you for the suggestion Geraldo! I will do that (as also answered > to David). You're welcome Waqar! Note that David's suggestion is even smarter than mine: instead of patch-bombing lots of maintainers with changes unrelated to their subsystems through a treewide change, he suggests you split the patch into one series per subsystem. This is indeed advisable. Thanks, Geraldo Nascimento _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic