* [PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup()
@ 2025-09-15 5:49 Dan Carpenter
2025-09-15 9:14 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-09-15 5:49 UTC (permalink / raw)
To: Feng Chen
Cc: Liang Yang, Xianwei Zhao, Mark Brown, linux-amlogic, linux-spi,
linux-kernel, kernel-janitors
There was supposed to be a "ret = " assignment here but it was
accidentally left off so the error checking doesn't work.
Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/spi/spi-amlogic-spifc-a4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-amlogic-spifc-a4.c b/drivers/spi/spi-amlogic-spifc-a4.c
index 4ca8e82fdc67..4338d00e56a6 100644
--- a/drivers/spi/spi-amlogic-spifc-a4.c
+++ b/drivers/spi/spi-amlogic-spifc-a4.c
@@ -420,7 +420,7 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
goto out_map_data;
cmd = CMD_DATA_ADDRH(sfc->daddr);
- regmap_write(sfc->regmap_base, SFC_CMD, cmd);
+ ret = regmap_write(sfc->regmap_base, SFC_CMD, cmd);
if (ret)
goto out_map_data;
--
2.51.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup()
2025-09-15 5:49 [PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup() Dan Carpenter
@ 2025-09-15 9:14 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-09-15 9:14 UTC (permalink / raw)
To: Feng Chen
Cc: Liang Yang, Xianwei Zhao, Mark Brown, linux-amlogic, linux-spi,
linux-kernel, kernel-janitors
On Mon, Sep 15, 2025 at 08:49:59AM +0300, Dan Carpenter wrote:
> There was supposed to be a "ret = " assignment here but it was
> accidentally left off so the error checking doesn't work.
>
> Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Sorry, I should have checked lore before I sent this. It's already been
patched.
regards,
dan carpenter
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-15 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-15 5:49 [PATCH next] spi: amlogic: Fix some error checking in aml_sfc_dma_buffer_setup() Dan Carpenter
2025-09-15 9:14 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox