From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FF3FC38145 for ; Wed, 7 Sep 2022 07:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9USOIc6NelK1P94nLAXwuq0BvfHHsXBE+Hl7NY0sVa4=; b=QkRDSFFlkXz2Wq e6vR5ET6yVrx6p4rc0Pe0daTQAjt3J3IqmKWXJgIg3dAhBDRr+EEm4XYFVDu20B4XBpfJpC14158q MfRs9aTUEWfy3v020yeiY696YenwUgLJHxIVRik4IPfE9CJk1yI2DrBmy6l320V6Wdse2zhe8r3et 7aXA4iEJpPCrfEqP6mLnc1LFuOiVfInQzLZUoMFPkIKo+4nKFgkw1QLW2hx6Ml6zXutIuvP/8s4+Z 0X8jowXkU8SvS7mbFEsNpZGMLrcQ6xYoSbkqZD/Y1W7J4Gk5X1hCfYbKT6bqpmebg6T+VdkikcTWD VwNTV6DFr5I6rZfx9snQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVpl2-003qSS-DP; Wed, 07 Sep 2022 07:46:00 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVpky-003qO5-TY; Wed, 07 Sep 2022 07:45:59 +0000 Received: from [10.28.39.72] (10.28.39.72) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.2507.6; Wed, 7 Sep 2022 15:45:51 +0800 Message-ID: Date: Wed, 7 Sep 2022 15:45:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH RESEND v8 4/5] dt-bindings: nand: meson: convert txt to yaml Content-Language: en-US To: Rob Herring CC: Miquel Raynal , , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220906060034.2528-1-liang.yang@amlogic.com> <20220906060034.2528-5-liang.yang@amlogic.com> <20220906143021.GA439874-robh@kernel.org> From: Liang Yang In-Reply-To: <20220906143021.GA439874-robh@kernel.org> X-Originating-IP: [10.28.39.72] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_004557_489254_3D03241E X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Rob, On 2022/9/6 22:30, Rob Herring wrote: > [ EXTERNAL EMAIL ] > > On Tue, Sep 06, 2022 at 02:00:32PM +0800, Liang Yang wrote: >> convert the amlogic,meson-name.txt to amlogic,meson-nand.yaml >> >> Signed-off-by: Liang Yang >> --- >> .../bindings/mtd/amlogic,meson-nand.txt | 55 ------------ >> .../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++ >> 2 files changed, 88 insertions(+), 55 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt >> create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> >> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt >> deleted file mode 100644 >> index 5d5cdfef417f..000000000000 >> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt >> +++ /dev/null >> @@ -1,55 +0,0 @@ >> -Amlogic NAND Flash Controller (NFC) for GXBB/GXL/AXG family SoCs >> - >> -This file documents the properties in addition to those available in >> -the MTD NAND bindings. >> - >> -Required properties: >> -- compatible : contains one of: >> - - "amlogic,meson-gxl-nfc" >> - - "amlogic,meson-axg-nfc" >> - >> -- reg : Offset and length of the register set >> - >> -- reg-names : "nfc" is the register set for NFC controller and "emmc" >> - is the register set for MCI controller. >> - >> -- clocks : >> - A list of phandle + clock-specifier pairs for the clocks listed >> - in clock-names. >> - >> -- clock-names: Should contain the following: >> - "core" - NFC module gate clock >> - "device" - parent clock for internal NFC >> - >> -Optional children nodes: >> -Children nodes represent the available nand chips. >> - >> -Other properties: >> -see Documentation/devicetree/bindings/mtd/nand-controller.yaml for generic bindings. >> - >> -Example demonstrate on AXG SoC: >> - >> - nand-controller@7800 { >> - compatible = "amlogic,meson-axg-nfc"; >> - reg = <0x0 0x7800 0x0 0x100>, >> - <0x0 0x7000 0x0 0x800>; >> - reg-names = "nfc", "emmc"; >> - #address-cells = <1>; >> - #size-cells = <0>; >> - interrupts = ; >> - >> - clocks = <&clkc CLKID_SD_EMMC_C>, >> - <&clkc CLKID_FCLK_DIV2>; >> - clock-names = "core", "device"; >> - >> - pinctrl-names = "default"; >> - pinctrl-0 = <&nand_pins>; >> - >> - nand@0 { >> - reg = <0>; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - >> - nand-on-flash-bbt; >> - }; >> - }; >> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> new file mode 100644 >> index 000000000000..42634e9c0d3c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> @@ -0,0 +1,88 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mtd/amlogic,meson-nand.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic NAND Flash Controller (NFC) for GXBB/GXL/AXG family SoCs >> + >> +allOf: >> + - $ref: "nand-controller.yaml" > > Don't need quotes I will fix it > >> + >> +maintainers: >> + - liang.yang@amlogic.com >> + >> +properties: >> + compatible: >> + enum: >> + - "amlogic,meson-gxl-nfc" >> + - "amlogic,meson-axg-nfc" > > Don't need quotes i will fix it > >> + >> + reg: >> + maxItems: 2 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 2 >> + >> + clock-names: >> + items: >> + - const: core >> + - const: device >> + >> +patternProperties: >> + "^nand@[0-7]$": >> + type: object >> + properties: >> + reg: >> + minimum: 0 >> + maximum: 1 >> + >> + nand-ecc-mode: >> + const: hw >> + >> + nand-ecc-step-size: >> + const: 1024 >> + >> + nand-ecc-strength: >> + enum: [8, 16, 24, 30, 40, 50, 60] >> + description: | >> + The ECC configurations that can be supported are as follows. >> + meson-gxl-nfc 8, 16, 24, 30, 40, 50, 60 >> + meson-axg-nfc 8 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + nand-controller@ffe07800 { >> + compatible = "amlogic,meson-axg-nfc"; >> + reg = <0xffe07800 0x100>, <0xffe07000 0x800>; >> + reg-names = "nfc", "emmc"; >> + interrupts = ; >> + clocks = <&clkc CLKID_SD_EMMC_C>, <&clkc CLKID_FCLK_DIV2>; >> + clock-names = "core", "device"; >> + >> + pinctrl-0 = <&nand_pins>; >> + pinctrl-names = "default"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + nand@0 { >> + reg = <0>; >> + }; >> + }; >> + >> +... >> -- >> 2.34.1 >> >> > > . _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic