From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E607FC43219 for ; Mon, 2 May 2022 17:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ziPr9k7sFB0V7FxhKongSYwA0tcrFc6JHicllpM8nmQ=; b=s+SN0QHo4eqfyv LzYyIRz+YFEeJgtzEN2ahXKKxK/sKU4HLIgBAULMaA+Rika7voEWrBiG/p6vleoLDRs/pOICVyxtL 9qgOCTUhckqWjwlxfOvtBOZ7M2J9CdvSARKRVQOrj3CdiCPkrjZWOZdOrdsEvCqmKgCeMlh0xVo6G V5zScSqBc9imdgHxkLTTeEVE0TNnlZhKzSdUw8KNAsjgDQ6Z1b2n7kVNhRVALW1LIS3lU/g1i3gj6 JqnqfXIEmCn4fcVXaPJd1ZCR1brYxcvUAxCm5Zj9x5lPW3QdrJQYspSzYZu+lRqla2m7sf4xjY19g YLrmsTp2IDBo3JFCDzow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlZT7-001vlx-Gr; Mon, 02 May 2022 17:04:17 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlZMK-001sIb-Ns for linux-amlogic@lists.infradead.org; Mon, 02 May 2022 16:57:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651510635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0Gq4g+r6nSFFN2UMiOU7agj8frQhJOC3wt5ScKN4WI=; b=VVwzwO59SzS0+Lzj+SrIY/Auhq1cFya02SAB75l5ytIZFavMtdZ09zH3GfXkCMZ+5fA8yp lFxlfbUH2uqedBLECNtfrR8u/AliTr/B7CVQdQj3aCh2w1576vxZliTQkWc4tQ4Ix5KKH6 WbbKGAAfgm2ezWaVJ5dpSLKMFT/A4a4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-50-tBBsPzmQNgmPIxVqxRSo6w-1; Mon, 02 May 2022 12:57:07 -0400 X-MC-Unique: tBBsPzmQNgmPIxVqxRSo6w-1 Received: by mail-wr1-f69.google.com with SMTP id s14-20020adfa28e000000b0020ac7532f08so5485690wra.15 for ; Mon, 02 May 2022 09:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=K0Gq4g+r6nSFFN2UMiOU7agj8frQhJOC3wt5ScKN4WI=; b=YEI3+BpUeWxC19AX0rrO4X2Hci2iiguS/40nZlYwkpMXMWS8EU65DImu11KDmeXufI xxSN3AvCrjps0nw7dpfBfWoAmxvBUSwzMFkz5zVbV/juQmjJPUTDSsNd3SUjFUN+Ky/+ IB3Vhav9/louPlJRGnY4NuyU/W2IWgq747R1x/xcRvBLcX387tDBQJI2NJkWBl9MraYS yB9EayNR0PANbHLm/uK7I60IqK0cpAQXDP2/cLfNBWbE0tb+5PnKqSlcj4rLw56ZNEXg k28PTsBzqGN77y5SOff11le9S2zwpTaCTu7OAnKJxLw+Ztrw3Qin1+kiVFjRjfa7qsoH kmcA== X-Gm-Message-State: AOAM530cPRT7jJ3Y/4oLimGeetWvx0Z1dgvdjQIbbQuTHh92qI2xnI24 Awo3XsI/+BGOji2fluRKJUW+pXLBOOJAGvgqpbBby1Yg2dQfZK6/cwjwl3uTmVHxrfK+50U0DsO kKF16UJWQV7udvgkvNMZxc253iSJOHL8= X-Received: by 2002:a05:600c:4f08:b0:391:fe3c:40e6 with SMTP id l8-20020a05600c4f0800b00391fe3c40e6mr78552wmq.34.1651510626195; Mon, 02 May 2022 09:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBR5y6TmCRfu+8hzM0SQTGA4cZrpN3ZhuFriWyFUH2mb/ZbNn3olE2yOJI8bAuj+96a04yXQ== X-Received: by 2002:a05:600c:4f08:b0:391:fe3c:40e6 with SMTP id l8-20020a05600c4f0800b00391fe3c40e6mr78523wmq.34.1651510625948; Mon, 02 May 2022 09:57:05 -0700 (PDT) Received: from [192.168.1.129] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id r20-20020adfa154000000b0020c5253d8c7sm7273243wrr.19.2022.05.02.09.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 09:57:05 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 18:57:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, Thomas Zimmermann , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, spice-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <20220502153900.408522-1-javierm@redhat.com> <20220502153900.408522-3-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220502_095716_946693_88361983 X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 5/2/22 18:07, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote: >> By default the bits per pixel for the emulated framebuffer device is set >> to dev->mode_config.preferred_depth, but some devices need another value. >> >> Since this second parameter is only used by a few drivers, and to allow >> drivers to use it for passing other configurations when registering the >> fbdev, rename @preferred_bpp to @options and make it a multi-field param. >> >> The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers >> for computing options bitfield values and getting the values respectively >> >> For now, only the DRM_FB_BPP option exists but other options can be added. >> >> Suggested-by: Thomas Zimmermann >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Thomas Zimmermann >> Reviewed-by: Laurent Pinchart >> --- >> >> Changes in v2: >> - Rename DRM_FB_SET_OPTION() to DRM_FB_SET() and make more clear in the > > I assume you meant DRM_FB_OPTION() here, not DRM_FB_SET(). > >> kernel-doc what this macro does (Laurent Pinchart). >> Right, that's a typo. The patch description and content are correct though. I'll fix the patch history log in v3. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic