From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] mmc: meson-gx: support platform interrupt as card detect interrupt
Date: Tue, 14 Feb 2023 07:39:32 +0100 [thread overview]
Message-ID: <ade6669b-9a4b-094c-a485-fdc8c7f5a8c3@gmail.com> (raw)
In-Reply-To: <CAPDyKFrsTMpguDp+0ZrKYkH5CYSk_OgKLxuZu4tFoGYaLpbJUQ@mail.gmail.com>
On 13.02.2023 23:47, Ulf Hansson wrote:
> On Mon, 30 Jan 2023 at 00:10, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> Use a new mmc core feature and support specifying the card detect
>> gpio interrupt in device tree.
>
> Don't we need an update to the DT doc too?
>
Right, the binding still has to be changed to allow more than one interrupt.
> Kind regards
> Uffe
>
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/mmc/host/meson-gx-mmc.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index be1a972c2..c87bc31d0 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -1236,6 +1236,9 @@ static int meson_mmc_probe(struct platform_device *pdev)
>> goto free_host;
>> }
>>
>> + /* gpio card detect interrupt */
>> + mmc->cd_irq = platform_get_irq_optional(pdev, 1);
>> +
>> host->pinctrl = devm_pinctrl_get(&pdev->dev);
>> if (IS_ERR(host->pinctrl)) {
>> ret = PTR_ERR(host->pinctrl);
>> --
>> 2.39.1
>>
>>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-02-14 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 23:02 [PATCH 0/2] mmc: meson-gx: support platform interrupt as card detect interrupt Heiner Kallweit
2023-01-29 23:04 ` [PATCH 1/2] mmc: core: " Heiner Kallweit
2023-02-13 22:46 ` Ulf Hansson
2023-02-14 7:45 ` Heiner Kallweit
2023-01-29 23:10 ` [PATCH 2/2] mmc: meson-gx: " Heiner Kallweit
2023-01-30 11:06 ` Neil Armstrong
2023-01-30 19:04 ` Heiner Kallweit
2023-02-13 22:47 ` Ulf Hansson
2023-02-14 6:39 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade6669b-9a4b-094c-a485-fdc8c7f5a8c3@gmail.com \
--to=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox