From: Neil Armstrong <narmstrong@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v1 1/1] pinctrl: meson: Switch to use fwnode instead of of_node
Date: Tue, 6 Sep 2022 11:07:07 +0200 [thread overview]
Message-ID: <b0d45e18-c92d-d187-2eac-851d975fbb7e@baylibre.com> (raw)
In-Reply-To: <20220905180034.73132-1-andriy.shevchenko@linux.intel.com>
On 05/09/2022 20:00, Andy Shevchenko wrote:
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson.c | 7 +++----
> drivers/pinctrl/meson/pinctrl-meson.h | 4 +++-
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index cc2cd73ff8f9..530f3f934e19 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -608,6 +608,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
>
> pc->chip.label = pc->data->name;
> pc->chip.parent = pc->dev;
> + pc->chip.fwnode = pc->fwnode;
> pc->chip.request = gpiochip_generic_request;
> pc->chip.free = gpiochip_generic_free;
> pc->chip.set_config = gpiochip_generic_config;
> @@ -619,8 +620,6 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
> pc->chip.base = -1;
> pc->chip.ngpio = pc->data->num_pins;
> pc->chip.can_sleep = false;
> - pc->chip.of_node = pc->of_node;
> - pc->chip.of_gpio_n_cells = 2;
>
> ret = gpiochip_add_data(&pc->chip, pc);
> if (ret) {
> @@ -678,8 +677,8 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc)
> return -EINVAL;
> }
>
> - gpio_np = to_of_node(gpiochip_node_get_first(pc->dev));
> - pc->of_node = gpio_np;
> + pc->fwnode = gpiochip_node_get_first(pc->dev);
> + gpio_np = to_of_node(pc->fwnode);
>
> pc->reg_mux = meson_map_resource(pc, gpio_np, "mux");
> if (IS_ERR_OR_NULL(pc->reg_mux)) {
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.h b/drivers/pinctrl/meson/pinctrl-meson.h
> index b197827027bd..34fc4e8612e4 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.h
> +++ b/drivers/pinctrl/meson/pinctrl-meson.h
> @@ -12,6 +12,8 @@
> #include <linux/types.h>
> #include <linux/module.h>
>
> +struct fwnode_handle;
> +
> struct meson_pinctrl;
>
> /**
> @@ -131,7 +133,7 @@ struct meson_pinctrl {
> struct regmap *reg_gpio;
> struct regmap *reg_ds;
> struct gpio_chip chip;
> - struct device_node *of_node;
> + struct fwnode_handle *fwnode;
> };
>
> #define FUNCTION(fn) \
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-09-06 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 18:00 [PATCH v1 1/1] pinctrl: meson: Switch to use fwnode instead of of_node Andy Shevchenko
2022-09-06 9:07 ` Neil Armstrong [this message]
2022-09-06 11:52 ` Andy Shevchenko
2022-09-08 8:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0d45e18-c92d-d187-2eac-851d975fbb7e@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox