From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexey Romanov <avromanov@salutedevices.com>,
neil.armstrong@linaro.org, clabbe@baylibre.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com
Cc: linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@salutedevices.com
Subject: Re: [PATCH v2 20/20] arch: arm64: dts: meson: axg: add crypto node
Date: Wed, 24 Jan 2024 08:22:59 +0100 [thread overview]
Message-ID: <b1a8bfbe-8e89-4cbb-af5b-3bd260cc89e7@linaro.org> (raw)
In-Reply-To: <20240123165831.970023-21-avromanov@salutedevices.com>
On 23/01/2024 17:58, Alexey Romanov wrote:
> This patch adds a crypto node declaration. With the
> Amlogic crypto driver we can use HW implementation
> of SHA1/224/256 and AES algo.
>
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 7e5ac9db93f8..39ecb894668e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -286,6 +286,12 @@ ethmac: ethernet@ff3f0000 {
> status = "disabled";
> };
>
> + crypto: crypto@ff63e000 {
> + compatible = "amlogic,axg-crypto";
Test your code.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-01-24 7:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 16:58 [PATCH v2 00/20] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 01/20] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 02/20] drivers: crypto: meson: make CLK controller optional Alexey Romanov
2024-01-24 8:28 ` Jerome Brunet
2024-01-23 16:58 ` [PATCH v2 03/20] drviers: crypto: meson: add platform data Alexey Romanov
2024-01-24 7:30 ` Corentin Labbe
2024-02-01 17:13 ` Alexey Romanov
2024-02-01 19:45 ` Corentin Labbe
2024-01-23 16:58 ` [PATCH v2 04/20] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 05/20] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 06/20] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 07/20] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 08/20] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 09/20] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 10/20] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 11/20] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 12/20] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 13/20] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 14/20] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 15/20] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 16/20] dt-bindings: crypto: meson: add new compatibles Alexey Romanov
2024-01-23 18:37 ` Rob Herring
2024-01-24 7:22 ` Krzysztof Kozlowski
2024-01-23 16:58 ` [PATCH v2 17/20] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 18/20] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 19/20] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-01-23 16:58 ` [PATCH v2 20/20] arch: arm64: dts: meson: axg: " Alexey Romanov
2024-01-24 7:22 ` Krzysztof Kozlowski [this message]
2024-01-24 9:13 ` [PATCH v2 00/20] Support more Amlogic SoC families in crypto driver neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1a8bfbe-8e89-4cbb-af5b-3bd260cc89e7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avromanov@salutedevices.com \
--cc=clabbe@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox