From: Neil Armstrong <neil.armstrong@linaro.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] arm(64): dts: meson: adjust order of some compatibles
Date: Wed, 1 Feb 2023 18:32:56 +0100 [thread overview]
Message-ID: <b5a29098-53b2-c940-0b1f-4dff40d97e44@linaro.org> (raw)
In-Reply-To: <e7b3fd1e-69eb-e66e-8abc-72b7c5fa975d@gmail.com>
Hi Heiner,
On 01/02/2023 18:30, Heiner Kallweit wrote:
> During review of a new yaml binding, affecting these dts, it turned out
> that some compatibles aren't ordered as they should be. Order should be
> most specific to least specific.
>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index d5a3fe21e..5979209fe 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -580,8 +580,8 @@ ðmac {
> };
>
> &gpio_intc {
> - compatible = "amlogic,meson-gpio-intc",
> - "amlogic,meson8b-gpio-intc";
> + compatible = "amlogic,meson8b-gpio-intc",
> + "amlogic,meson-gpio-intc";
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index 923d2d8bb..12ef6e81c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -300,8 +300,8 @@ ðmac {
> };
>
> &gpio_intc {
> - compatible = "amlogic,meson-gpio-intc",
> - "amlogic,meson-gxbb-gpio-intc";
> + compatible = "amlogic,meson-gxbb-gpio-intc",
> + "amlogic,meson-gpio-intc";
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index 04e9d0f1b..af912f698 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -312,8 +312,8 @@ &clkc_AO {
> };
>
> &gpio_intc {
> - compatible = "amlogic,meson-gpio-intc",
> - "amlogic,meson-gxl-gpio-intc";
> + compatible = "amlogic,meson-gxl-gpio-intc",
> + "amlogic,meson-gpio-intc";
> status = "okay";
> };
>
Please send a new clean patchset with the associated bindings changes then this patch,
and split ARM and arm64 in 2 patches.
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-02-01 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 17:30 [PATCH] arm(64): dts: meson: adjust order of some compatibles Heiner Kallweit
2023-02-01 17:32 ` Neil Armstrong [this message]
2023-02-01 17:57 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a29098-53b2-c940-0b1f-4dff40d97e44@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox