From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection
Date: Mon, 8 Apr 2019 19:45:13 +0200 [thread overview]
Message-ID: <bc5c192e-78ce-89b1-eeae-541836f5f0fb@gmail.com> (raw)
In-Reply-To: <20190407221312.GA14347@lunn.ch>
On 08.04.2019 00:13, Andrew Lunn wrote:
> On Sun, Apr 07, 2019 at 11:57:13AM +0200, Heiner Kallweit wrote:
>> Recently genphy_read_abilities() has been added that dynamically detects
>> clause 22 PHY abilities. I *think* this detection should work with all
>> supported PHY's, at least for the ones with basic features sets, i.e.
>> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
>> features explicitly and rely on phylib feature detection.
>
> Hi Heiner
>
Hi Andrew,
> We could make this a two step process, to avoid regressions. For one
> cycle compare genphy_read_abilities() against .features and raise a
> WARN_ON() if they differ. And keep using the .features value.
>
in general this is a good idea. I say in general because this would fail
with several, if not most GBit PHY's. Reason is that the hardcoded
features currently pretend we're supporting 1000BT/Half, whilst several
PHY's don't support this mode. 1000BT/Half has been specified but never
really been used. If we see it from this angle, the series is actually
a fix. The feature detection uses very basic C22 registers/bits,
therefore I consider the risk of breaking something to be relatively low.
And just in case we have the rc phase to fix support for a broken PHY.
Splitting the series and waiting for a Tested-by, as proposed by Richard,
may be problematic because most PHY drivers don't have a dedicated
maintainer, and we lack the hardware to test.
> Then a release late, complete the swap removing .features and the
> WARN_ON.
>
> Andrew
> .
>
Heiner
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-08 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 9:57 [PATCH net-next] net: phy: switch drivers to use dynamic feature detection Heiner Kallweit
2019-04-07 20:31 ` Florian Fainelli
2019-04-07 20:48 ` Heiner Kallweit
2019-04-07 22:13 ` Andrew Lunn
2019-04-08 17:45 ` Heiner Kallweit [this message]
2019-04-08 18:12 ` Andrew Lunn
2019-04-08 18:45 ` Heiner Kallweit
2019-04-08 2:38 ` Richard Cochran
2019-04-09 20:59 ` David Miller
2019-04-10 19:31 ` Heiner Kallweit
2019-04-10 19:33 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc5c192e-78ce-89b1-eeae-541836f5f0fb@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).