From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6401DE7719C for ; Fri, 10 Jan 2025 10:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5IsVidpLnxgkrtMSJhjP7udlmCwyOGhWANDOXPkCFdM=; b=Tl4xaqEh325rE3HAr/jOOmeO2S FZYLc+jVrxcKqf5MxgXwhtfF6c3+B1jr8h1ZTDzbYpHAfICb/4qOrikTTv4DmvUlUoN6c6mWKM86g WmqRnpsE4OZGdRgHvO5QY5jdZuKxcOsFz8lWsDZ1jQsDmFRqmJdpae3D4vYUTgQ1GRrA2e0/fGYna WI2piq/vmBGvl8q1qokB87RkGhheJJoey+FrVN3NvYYDCMrUKOvahYsM0dF0bz56e4Z7h2jpun2CQ a1CYZm3YIaqNYQBXOAYje/rV/PI13JKeBNo9//ORCW6gbuw6A4DB4sV8ChUcVa1JBY99I9np0qsWl 6rxbjbAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tWCEp-0000000Ewlb-1lMy; Fri, 10 Jan 2025 10:27:35 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tWC0n-0000000Eu2F-1N5f for linux-amlogic@lists.infradead.org; Fri, 10 Jan 2025 10:13:06 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4363ae65100so19971175e9.0 for ; Fri, 10 Jan 2025 02:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736503984; x=1737108784; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=QOUzYhTzRbU2PZyaCr9aEEOmHEzU4GQv9eiFuMaGvrQ=; b=okIVrXFhcKomZ6Z5ynA6K/a1tdWHl100M6AT83VTZ2ISYzTVRG+1HHMOjEjwCYsZIA anhv96WYGnfG9JRByotEvWMMor1o3jM0Zgt7w9cOd3PNI3RyzFli8/bC0pe/jtrUbN1b z7UK6/7UvCbWepLmB3zht3pmFKDwDZ9JFpFk2Z8YdJo/7ZRtJeCZmqJtYHQ+rfQR7VxG teyqhJdOK7yS70U7NMafAQwRe3uRNYgl81cyySDcKu8KltfyH9HPUo1Eo7oILOK0JLkm w0Gaxtbh7cp5o6WIv6UuI+k7WSVPP3V2u1zg+KMeBChx/jV9Y4CgJiECW4jERcdNuqJM zumA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736503984; x=1737108784; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QOUzYhTzRbU2PZyaCr9aEEOmHEzU4GQv9eiFuMaGvrQ=; b=KkHtugMnFDuNmSoo2oi6v8wC2yr2ROlko32DfNwNmgJ1A5xUiMgqaQKvVt6+/Bj37H aI1c2xncTcQhf+SfxPuVw6xV6K2EqBGEqfKhaX1bj/nwH3nREf75NAWS7qgoxfEJmR/M eozZgDe3AionRPABEtTKyosDPsB4NwkopZloyD+ABdgfqGitKRic5M+vHWCQuAjrwRXf BCeskMQUuAfxN95HZmDdSNIa3V2T45SoN7LiCv9end5E7DybBddZ1hFqDYqY6Wtcpe99 HokyCD305AvJqcYPigs6J8WV/AEKZxoOVyScTGMRVyfGD5FcFEhXPYFvVb2Ibq154OOz EH0Q== X-Forwarded-Encrypted: i=1; AJvYcCUeyTPiUsBJo5S9C9Rjj6+LXbYUBNkGCECi5TKhTB37cADjB9rvw7LlRSaleDre9b/MNjRwwiR1+uWFapw0@lists.infradead.org X-Gm-Message-State: AOJu0YxsqE/8Jq0Wq7Rs3JgTuW2Vyp12WgSVyQjm7BHdPrRBRv+wzlKu tpzN8h2JXznjGhvvdVea3rkfkcdcv0bRMs90IUhSxf5zif7wRLYVgzXct8J0Wb0= X-Gm-Gg: ASbGncurLSdm4RtIp2Nh6n3RCl727l1tRL/WFaLiy7RWfzbWlJJQQonSx3iuQaAfhmm T7j/+BfiU+y7JyTTY5t18ysvk2scRZhLcksguD1RJxKDwJ7FTZBB4AapXZWgsQuXsBQmJcNqnX2 ITiizBCNdv14VTyFZEetKTm3QJm+8rfFXHNDIcZFE3XWC6CQyk1YKnDS5k2t+LtWZ8fWOB9DVgj ZU/bUFv2Oyae/kFRgDv3VhkqA3xNmXKzRvFMW/3CUmv/Cb+HMjJ9+TQNtJnYvzyrt8iAENuipL3 Gt7TShIcw6/ABVrO+v1iLYgQXdXoIH0bRw== X-Google-Smtp-Source: AGHT+IH14VgpNAHxLDfw+eb1nzA4fydxlf+fdVrPXOSjYG/N+CGyBX4YnPcgAjL/ozrdB+dQhWcohA== X-Received: by 2002:a05:600c:46d2:b0:434:a1d3:a321 with SMTP id 5b1f17b1804b1-436e2679db4mr91257665e9.3.1736503983816; Fri, 10 Jan 2025 02:13:03 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:bf4e:5758:59ef:deb8? ([2a01:e0a:982:cbb0:bf4e:5758:59ef:deb8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9dc895esm47221015e9.13.2025.01.10.02.13.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 02:13:03 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 11:13:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 1/2] Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates" To: Christian Hewitt , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20250110074458.3624094-1-christianshewitt@gmail.com> <20250110074458.3624094-2-christianshewitt@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250110074458.3624094-2-christianshewitt@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250110_021305_368776_BF977C39 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 10/01/2025 08:44, Christian Hewitt wrote: > This reverts commit bfbc68e4d8695497f858a45a142665e22a512ea3. > > The patch does permit the offending YUV420 @ 59.94 phy_freq and > vclk_freq mode to match in calculations. It also results in all > fractional rates being unavailable for use. This was unintended > and requires the patch to be reverted. > > Cc: > Signed-off-by: Christian Hewitt > --- > drivers/gpu/drm/meson/meson_vclk.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c > index 2a942dc6a6dc..2a82119eb58e 100644 > --- a/drivers/gpu/drm/meson/meson_vclk.c > +++ b/drivers/gpu/drm/meson/meson_vclk.c > @@ -790,13 +790,13 @@ meson_vclk_vic_supported_freq(struct meson_drm *priv, unsigned int phy_freq, > FREQ_1000_1001(params[i].pixel_freq)); > DRM_DEBUG_DRIVER("i = %d phy_freq = %d alt = %d\n", > i, params[i].phy_freq, > - FREQ_1000_1001(params[i].phy_freq/1000)*1000); > + FREQ_1000_1001(params[i].phy_freq/10)*10); > /* Match strict frequency */ > if (phy_freq == params[i].phy_freq && > vclk_freq == params[i].vclk_freq) > return MODE_OK; > /* Match 1000/1001 variant */ > - if (phy_freq == (FREQ_1000_1001(params[i].phy_freq/1000)*1000) && > + if (phy_freq == (FREQ_1000_1001(params[i].phy_freq/10)*10) && > vclk_freq == FREQ_1000_1001(params[i].vclk_freq)) > return MODE_OK; > } > @@ -1070,7 +1070,7 @@ void meson_vclk_setup(struct meson_drm *priv, unsigned int target, > > for (freq = 0 ; params[freq].pixel_freq ; ++freq) { > if ((phy_freq == params[freq].phy_freq || > - phy_freq == FREQ_1000_1001(params[freq].phy_freq/1000)*1000) && > + phy_freq == FREQ_1000_1001(params[freq].phy_freq/10)*10) && > (vclk_freq == params[freq].vclk_freq || > vclk_freq == FREQ_1000_1001(params[freq].vclk_freq))) { > if (vclk_freq != params[freq].vclk_freq) I wonder if a Fixes is also required here _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic