From: Neil Armstrong <narmstrong@baylibre.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: khilman@baylibre.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, daniel@ffwll.ch,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro
Date: Mon, 27 Jul 2020 09:28:43 +0200 [thread overview]
Message-ID: <c056f317-c705-8356-e83b-ef3e206f4811@baylibre.com> (raw)
In-Reply-To: <20200726172549.GH3275923@ravnborg.org>
On 26/07/2020 19:25, Sam Ravnborg wrote:
> Hi Neil.
>
> On Thu, Jul 23, 2020 at 11:05:50AM +0200, Neil Armstrong wrote:
>> Fix the Amlogic Video Framebuffer Compression modifier macro to
>> correctly add the layout options, a pair of parenthesis was missing.
>>
>> Fixes: d6528ec88309 ("drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression")
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Looks correct just looking at the patch below.
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> I assume you will apply the patch.
Yes, indeed
Thanks !
Neil
>
> Sam
>
>> ---
>> include/uapi/drm/drm_fourcc.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> index 4bee7de5f306..82f327801267 100644
>> --- a/include/uapi/drm/drm_fourcc.h
>> +++ b/include/uapi/drm/drm_fourcc.h
>> @@ -1004,7 +1004,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
>> #define DRM_FORMAT_MOD_AMLOGIC_FBC(__layout, __options) \
>> fourcc_mod_code(AMLOGIC, \
>> ((__layout) & __fourcc_mod_amlogic_layout_mask) | \
>> - ((__options) & __fourcc_mod_amlogic_options_mask \
>> + (((__options) & __fourcc_mod_amlogic_options_mask) \
>> << __fourcc_mod_amlogic_options_shift))
>>
>> /* Amlogic FBC Layouts */
>> --
>> 2.22.0
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-07-27 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 9:05 [PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro Neil Armstrong
2020-07-23 9:05 ` [PATCH 2/2] drm/meson: overlay: fix Amlogic Compressed Framebuffer modifier layout extract Neil Armstrong
2020-07-26 17:25 ` [PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro Sam Ravnborg
2020-07-27 7:28 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c056f317-c705-8356-e83b-ef3e206f4811@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox