From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D64AEC433EF for ; Mon, 6 Dec 2021 12:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QwQjBVqj4pgY1q5U0hC0iXRum7HbMAbHdUYjA8CPqn4=; b=c//KggIQ8C0gBqwTlWD18YPIl/ DU9+7Sip7Tsw8SNDvK6dW2vEWdVMRXmycIobOnzzMhACJOM+qbxMgyc5FD5kNpHQibg3PAjiKV65u eSbxh/o1Z5Iji0HWKDzusXpjaX82ROTyNUVX7AD2iUuf5pfAmQrJxC4CDhN01uod4rfyE4+0jydMj TYXwEk+IwptLPIi/N2WvaD5ZHUBXBBnSdMAumZmUrtyYiw+gjT70yFgVJ7X5j2Yt5r+hQyQ5CyTeJ KkWGbeFJYlCJvmGP185SIdK6rWzKMN8FOHCo75Rx3JpyqocsUdzsxVPAfbpgXFYtbEqY/NXPAyvx6 lrqp8nXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muDUs-003raQ-WE; Mon, 06 Dec 2021 12:53:35 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muDUp-003rYY-U7; Mon, 06 Dec 2021 12:53:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7AEE2B81095; Mon, 6 Dec 2021 12:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ED77C341C1; Mon, 6 Dec 2021 12:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638795209; bh=od76G1UF9Yr6eb3UB4DOF8v/MK2V4wRo+0/Q/ViTo9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bqtim4S/nDlnH2iHTyOs2HkWN46DA2ycegS0fjPt3iXOdKkeCjmF7c9kpsr/5u+nd 09VeW/PoZXf0xHPH57y4B9kcmM5Mi+mkB5bwO/eev2m3092mZoAZkzoCLTk3C7Aek8 P38pXQMXC7kJMy8LB3OPBeN3t9ZU26mnzgEnqM85T73UrKFqV6EZqSpZXLfRPJpzEu OZuVS7RrHTTM91/w6FbE4hdwGErKJj4L/46OXpQrxqx2tjCn7+urPoK00Xo1X2doup ZPpZnF29EBcUJCwM5isU0SMegprDdHQBLukHo6DTD4XWuBt7PCmnSaU962cAyr39mi +deOq7+yGrvXw== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1muDUk-00AAVg-U7; Mon, 06 Dec 2021 12:53:27 +0000 MIME-Version: 1.0 Date: Mon, 06 Dec 2021 12:53:26 +0000 From: Marc Zyngier To: "xianwei.zhao" Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Herring Subject: Re: [PATCH] arm64: dts: add support for S4 based Amlogic AQ222 In-Reply-To: <20211206100209.31971-1-xianwei.zhao@amlogic.com> References: <20211206100209.31971-1-xianwei.zhao@amlogic.com> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: xianwei.zhao@amlogic.com, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, narmstrong@baylibre.com, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, robh+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_045332_290121_B1FCE5FF X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2021-12-06 10:02, xianwei.zhao wrote: > Add basic support for the Amlogic S4 based Amlogic AQ222 board: > which describe components as follows: CPU, GIC, IRQ, Timer, UART. > It's capable of booting up into the serial console. > > Signed-off-by: xianwei.zhao > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../dts/amlogic/meson-s4-s805x2-aq222.dts | 30 ++++++ > arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 98 +++++++++++++++++++ > 3 files changed, 129 insertions(+) > create mode 100644 > arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts > create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4.dtsi > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile > b/arch/arm64/boot/dts/amlogic/Makefile > index 5148cd9e5146..faea74a45994 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -57,3 +57,4 @@ dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-c4.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-odroid-hc4.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-sm1-sei610.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-a1-ad401.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-s4-s805x2-aq222.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts > b/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts > new file mode 100644 > index 000000000000..6b6ecb40be4a > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Amlogic, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "meson-s4.dtsi" > + > +/ { > + model = "Amlogic"; > + compatible = "amlogic, aq222"; > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &uart_B; > + }; > + > + memory@00000000 { > + device_type = "memory"; > + linux,usable-memory = <0x0 0x0 0x0 0x40000000>; > + }; > + > +}; > + > +&uart_B { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > new file mode 100644 > index 000000000000..b66f62701063 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > @@ -0,0 +1,98 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Amlogic, Inc. All rights reserved. > + */ > + > +#include > +#include > +/ { > + cpus:cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + CPU0:cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a35","arm,armv8"; > + reg = <0x0 0x0>; > + enable-method = "psci"; > + }; > + > + CPU1:cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a35","arm,armv8"; > + reg = <0x0 0x1>; > + enable-method = "psci"; > + }; > + > + CPU2:cpu@2 { > + device_type = "cpu"; > + compatible = "arm,cortex-a35","arm,armv8"; > + reg = <0x0 0x2>; > + enable-method = "psci"; > + }; > + > + CPU3:cpu@3 { > + device_type = "cpu"; > + compatible = "arm,cortex-a35","arm,armv8"; > + reg = <0x0 0x3>; > + enable-method = "psci"; > + }; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = , > + , > + , > + ; You only have 4 CPUs, so the affinity is wrong. Please use symbolic constants for all the PPIs. > + }; > + > + psci { > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > + xtal: xtal-clk { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + clock-output-names = "xtal"; > + #clock-cells = <0>; > + }; > + > + soc { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + gic: interrupt-controller@fff01000 { > + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; Neither, really. It cannot be an A9 GIC (you have virtualisation), and because on an ARMv8 system, it is the CPU that implements the CPU interface, this cannot be a A15 GIC either. This is most likely yet another GIC400. > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x0 0xfff01000 0 0x1000>, > + <0x0 0xfff02000 0 0x0100>; 256 bytes? where are you getting this value from? You are also missing the GICH and GICV regions, despite describing a maintenance interrupt... > + interrupts = ; > + }; > + > + apb4: apb4@fe000000 { > + compatible = "simple-bus"; > + reg = <0x0 0xfe000000 0x0 0x480000>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > + > + uart_B: serial@7a000 { > + compatible = "amlogic,meson-gx-uart", > + "amlogic,meson-ao-uart"; > + reg = <0x0 0x7a000 0x0 0x18>; > + interrupts = ; > + status = "disabled"; > + clocks = <&xtal>, <&xtal>, <&xtal>; > + clock-names = "xtal", "pclk", "baud"; > + xtal_tick_en = <1>; > + fifo-size = <64>; > + }; > + }; > + }; > +}; > > base-commit: c5468e3c930d4d2937d3a842a85df0f74e95e152 Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic