linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hkallweit1@gmail.com (Heiner Kallweit)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 12/12] i2c: meson: use state in meson_i2c_prepare_xfer
Date: Wed, 8 Mar 2017 07:50:23 +0100	[thread overview]
Message-ID: <c9ee2ea8-28d6-17ff-2bf4-2354d3e404a5@gmail.com> (raw)
In-Reply-To: <d5f0545a-fb4c-b436-20f5-7df9d10605b1@gmail.com>

Let's use the state here to make meson_i2c_prepare_xfer more in line
with other parts of the driver.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/i2c/busses/i2c-meson.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index 7b29f077..eacb6f3d 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -181,7 +181,6 @@ static void meson_i2c_put_data(struct meson_i2c *i2c, char *buf, int len)
 
 static void meson_i2c_prepare_xfer(struct meson_i2c *i2c)
 {
-	bool write = !(i2c->msg->flags & I2C_M_RD);
 	int i;
 
 	i2c->count = min(i2c->msg->len - i2c->pos, 8);
@@ -189,7 +188,7 @@ static void meson_i2c_prepare_xfer(struct meson_i2c *i2c)
 	for (i = 0; i < i2c->count - 1; i++)
 		meson_i2c_add_token(i2c, TOKEN_DATA);
 
-	if (write || i2c->pos + i2c->count < i2c->msg->len)
+	if (i2c->state == STATE_WRITE || i2c->pos + i2c->count < i2c->msg->len)
 		meson_i2c_add_token(i2c, TOKEN_DATA);
 	else
 		meson_i2c_add_token(i2c, TOKEN_DATA_LAST);
@@ -197,7 +196,7 @@ static void meson_i2c_prepare_xfer(struct meson_i2c *i2c)
 	if (i2c->last && i2c->pos + i2c->count >= i2c->msg->len)
 		meson_i2c_add_token(i2c, TOKEN_STOP);
 
-	if (write)
+	if (i2c->state == STATE_WRITE)
 		meson_i2c_put_data(i2c, i2c->msg->buf + i2c->pos, i2c->count);
 
 	writel(i2c->tokens[0], i2c->regs + REG_TOK_LIST0);
-- 
2.12.0

  parent reply	other threads:[~2017-03-08  6:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08  6:41 [PATCH 00/12] i2c: meson: series with improvements Heiner Kallweit
2017-03-08  6:42 ` [PATCH 01/12] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit
2017-03-08  9:25   ` Jerome Brunet
2017-03-08  6:43 ` [PATCH 02/12] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit
2017-03-08  9:07   ` Jerome Brunet
2017-03-08  6:44 ` [PATCH 03/12] i2c: meson: use i2c core for DT clock-frequency parsing Heiner Kallweit
2017-03-08  9:10   ` Jerome Brunet
2017-03-08  6:44 ` [PATCH 04/12] i2c: meson: use full 12 bits for clock divider Heiner Kallweit
2017-03-08  9:19   ` Jerome Brunet
2017-03-08  6:45 ` [PATCH 05/12] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit
2017-03-08  6:46 ` [PATCH 06/12] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit
2017-03-08  9:28   ` Jerome Brunet
2017-03-08  6:47 ` [PATCH 07/12] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit
2017-03-08  9:50   ` Jerome Brunet
2017-03-08 21:02     ` Heiner Kallweit
2017-03-09 20:16       ` Heiner Kallweit
2017-03-08  6:47 ` [PATCH 08/12] i2c: meson: explicitly ignore messages with length zero Heiner Kallweit
     [not found]   ` <CANe6Qb9nKdLnOcwEwuk8NXEB+fxW2S_kkzP+U+qygYhNqz0Y0w@mail.gmail.com>
2017-03-08 22:03     ` Heiner Kallweit
2017-03-08  6:48 ` [PATCH 09/12] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit
2017-03-08  6:49 ` [PATCH 10/12] i2c: meson: remove meson_i2c_write_tokens Heiner Kallweit
2017-03-08  6:49 ` [PATCH 11/12] i2c: meson: improve and simplify interrupt handler Heiner Kallweit
2017-03-08  6:50 ` Heiner Kallweit [this message]
2017-03-08  9:34 ` [PATCH 00/12] i2c: meson: series with improvements Jerome Brunet
2017-03-08 20:49   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9ee2ea8-28d6-17ff-2bf4-2354d3e404a5@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).