From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Miller <davem@davemloft.net>, f.fainelli@gmail.com
Cc: andrew@lunn.ch, heiko@sntech.de, sbranden@broadcom.com,
khilman@baylibre.com, richardcochran@gmail.com,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection
Date: Wed, 10 Apr 2019 21:31:21 +0200 [thread overview]
Message-ID: <cbd952f0-117f-8418-e82f-5460dc0d99d0@gmail.com> (raw)
In-Reply-To: <20190409.135944.1516944884952068835.davem@davemloft.net>
On 09.04.2019 22:59, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Sun, 7 Apr 2019 11:57:13 +0200
>
>> Recently genphy_read_abilities() has been added that dynamically detects
>> clause 22 PHY abilities. I *think* this detection should work with all
>> supported PHY's, at least for the ones with basic features sets, i.e.
>> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
>> features explicitly and rely on phylib feature detection.
>>
>> I don't have access to most of these PHY's, therefore I'd appreciate
>> regression testing.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> This appears to need to be done differently.
>
> A question was asked as to why fast ethernet PHY identification from the
> source is important, well I'd say it's important for someone working on
> the PHY code to see how "all fast ethernet PHY drivers do or handle X"
>
Then, what we could do: Change all occurrences of
.features = PHY_XXX_FEATURES
to
/* PHY_XXX_FEATURES */
Would this be an acceptable option?
> :-)
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-10 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 9:57 [PATCH net-next] net: phy: switch drivers to use dynamic feature detection Heiner Kallweit
2019-04-07 20:31 ` Florian Fainelli
2019-04-07 20:48 ` Heiner Kallweit
2019-04-07 22:13 ` Andrew Lunn
2019-04-08 17:45 ` Heiner Kallweit
2019-04-08 18:12 ` Andrew Lunn
2019-04-08 18:45 ` Heiner Kallweit
2019-04-08 2:38 ` Richard Cochran
2019-04-09 20:59 ` David Miller
2019-04-10 19:31 ` Heiner Kallweit [this message]
2019-04-10 19:33 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd952f0-117f-8418-e82f-5460dc0d99d0@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).