From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35068C5DF81 for ; Wed, 19 Aug 2026 19:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Be4oGVMf/5jlY5rVklO89GsDFkqlUAEpm18YsPK7ddY=; b=16BAkfkmGnbxAN D8VY7heyZ27LQym724YqQJR7EemFHzVmW/kNsCyoaJsPD2fyDhRe6nSNP7xDl5w8E0rc9pYwkgvyR p7Oo4DH6/gysv0yfhIdMniVFzOzAYM/sJ8CgDce+3dMqPKLIuAkMg9RIPD1txiUMqdHRmShPwOy2A A3/qu5VfKUuSyxAHAhCl/CDieMsXOS64Gzj5HOkzcT37w0n3I/LYsOdjg/uEAnoy+xBtH/Vf0wdBJ Sr9XAc73ACCBgcJYLWldTM6G1zmOv2L16zZ/9L8B4AvWNPgTiIeEObOfAyPmtdjMiXUCqQ07lpvmX 166fLnf8xE/DAawjtmPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwlbh-0000000APps-13Rw; Wed, 19 Aug 2026 19:05:49 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwlbg-0000000APph-0IfC; Wed, 19 Aug 2026 19:05:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 265C660AAA; Wed, 19 Aug 2026 19:05:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 576961F000E9; Wed, 19 Aug 2026 19:05:41 +0000 (UTC) From: Geert Uytterhoeven To: Tero Kristo , Stephen Boyd , Brian Masney , Jerome Brunet , Nobuhiro Iwamatsu , Nuno Sa , Guenter Roeck , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , Andy Shevchenko , Sunny Luo , Xianwei Zhao , Mark Brown , Kees Cook , Kevin Hilman , Mathieu Dubois-Briand Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, linux@analog.com, linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH treewide 0/5] clk: Make sure clk_init_data is fully initialized (part 1) Date: Wed, 19 Aug 2026 21:05:14 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi all, The clk_init_data structure contains three mutually-exclusive members for different methods to specify the possible parents of a clock, prompting drivers to initialize only the members they need. When commit fc0c209c147f35ed ("clk: Allow parents to be specified without string names") added the last two methods, this was done in a backwards-compatible way, using a priority-based scheme: - .name, .ops, .num_parents, and .flags must always be initialized, - if .num_parents is non-zero, .parent_names must be initialized, - if .parent_names is NULL, .parent_data must be initialized, - if .parent_data is NULL, .parent_hws must be initialized and valid. However, not initializing all members may cause subtle issues, which are only exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is enabled. Hence this series makes sure all members are fully initialized, to fix such bugs, and to avoid future breakage when converting drivers to a different method for specifying the parents. This (small) series is part 1, and fixes all cases that I identified to be real bugs: - The first patch fixes a crash I saw on BeagleBone Black, - The other patches are only compile-tested. All patches in this series can be applied independently. Part 2 will be much larger (touching 185 files), and will fix the remaining cases that are currently harmless. Thanks for your comments! Geert Uytterhoeven (5): clk: ti: Make sure clk_init_data is fully initialized clk: visconti: Make sure clk_init_data is fully initialized hwmon: (ltc4282) Make sure clk_init_data is fully initialized iio: frequency: adf4377: Make sure clk_init_data is fully initialized spi: amlogic-spisg: Make sure clk_init_data is fully initialized drivers/clk/ti/adpll.c | 4 ++-- drivers/clk/ti/divider.c | 2 +- drivers/clk/ti/mux.c | 2 +- drivers/clk/visconti/clkc.c | 2 +- drivers/hwmon/ltc4282.c | 2 +- drivers/iio/frequency/adf4377.c | 2 +- drivers/spi/spi-amlogic-spisg.c | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) -- 2.43.0 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic