From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Icenowy Zheng <uwu@icenowy.me>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-amlogic@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub
Date: Tue, 12 Dec 2023 12:52:02 +0100 [thread overview]
Message-ID: <d2962ffb-badd-44a6-bdcc-53e15d4a4379@linaro.org> (raw)
In-Reply-To: <CANAwSgRLORHb6qiHWRBR0tMbYB=O=gwatuGhk72SwZyhYMopCw@mail.gmail.com>
On 12/12/2023 12:37, Anand Moon wrote:
>
> Here is the list of warnings I observed with this patch
>
> DTC_CHK Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.example.dtb
> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> hub@1: 'vdd-supply' is a required property
You always require the property, but it is not valid for some devices.
Just require it only where it is applicable (in if:then: clause).
> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> hub@1: 'reset-gpios' is a required property
> from schema $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
> hub@1: 'peer-hub' is a required property
...
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - usb5e3,610
>>> + - usb5e3,620
>>> + then:
>>> + properties:
>>> + peer-hub: true
>>> + vdd-supply: true
>>
>> Drop this if:, redundant.
>>
> No, this does not resolve the above issue.
It shouldn't resolve it, not related.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-12-12 11:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:44 [PATCH v6 0/2] Use onboard usb hub reset on Odroid N2 Anand Moon
2023-12-04 14:44 ` [PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub Anand Moon
2023-12-06 13:53 ` Rob Herring
2023-12-06 17:14 ` Anand Moon
2023-12-07 8:30 ` Krzysztof Kozlowski
2023-12-07 12:33 ` Anand Moon
2023-12-07 12:40 ` Krzysztof Kozlowski
2023-12-08 0:24 ` Anand Moon
2023-12-08 7:44 ` Krzysztof Kozlowski
2023-12-08 11:19 ` Anand Moon
2023-12-08 12:17 ` Krzysztof Kozlowski
2023-12-12 6:22 ` Anand Moon
2023-12-12 8:40 ` Krzysztof Kozlowski
2023-12-12 11:37 ` Anand Moon
2023-12-12 11:52 ` Krzysztof Kozlowski [this message]
2023-12-12 12:51 ` Anand Moon
2023-12-12 13:09 ` Krzysztof Kozlowski
2023-12-12 13:17 ` Anand Moon
2024-04-04 4:27 ` Anand Moon
2024-04-04 6:12 ` Krzysztof Kozlowski
2024-04-04 6:32 ` Anand Moon
2024-04-04 6:34 ` Anand Moon
2023-12-04 14:44 ` [PATCH v6 2/2] arm64: dts: amlogic: Used onboard usb hub reset on odroid n2 Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2962ffb-badd-44a6-bdcc-53e15d4a4379@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).