From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52A57C48285 for ; Sat, 27 Jan 2024 22:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UqvKOxgSwBjIwS6raJ8vhvvSDwchA/j+2kLCyO7HVyY=; b=2FlxD1hEIsytCM urjT9mBE9snrWULlNAxp4eW/hgizvjwx+4U8C/SbZTXRCYzSjU3ZXvspfd+lGHxgabDM2ZumNGjy1 K/kAXjA989CWIFvQbOGDvIjjzL5d/uybnensiFjk0DGR6W/DUDffSJfY8g9RbQRM4oj3JXvopHV2f toC5O5sVhwfBdUtWTk1rqzNwUgsrjEaUDnc5qILqQ52cj4Mqj3hkLti1Jg3TaCTPylD8ChKxZTjvd bp0OuoVdT655vy4K83WsI8e5nUNrh+oyDOan10vw5u7ewS9zAa8YI72Qit7dSyp4b+6ov08Db6Aac ytMkmvBazRHlZ0L9Aeug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTqjB-00000008FoO-2V5P; Sat, 27 Jan 2024 22:00:41 +0000 Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTqj6-00000008FnG-0a1X; Sat, 27 Jan 2024 22:00:36 +0000 Message-ID: Date: Sat, 27 Jan 2024 14:00:34 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/17] media: i2c: css-quirk.h: Fix kerneldoc Content-Language: en-US To: Ricardo Ribalda , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Sakari Ailus , Laurent Pinchart , Hans Verkuil , Hans Verkuil , Kieran Bingham , Bin Liu , Ezequiel Garcia , Philipp Zabel , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , Andrzej Hajda , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-amlogic@lists.infradead.org References: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> <20240126-gix-mtk-warnings-v1-6-eed7865fce18@chromium.org> From: Randy Dunlap In-Reply-To: <20240126-gix-mtk-warnings-v1-6-eed7865fce18@chromium.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 1/26/24 15:16, Ricardo Ribalda wrote: > Kerneldoc does not seem to understand that embed doc: > drivers/media/i2c/ccs/ccs-quirk.h:50: warning: Excess struct member 'write' description in 'ccs_quirk' > drivers/media/i2c/ccs/ccs-quirk.h:50: warning: Excess struct member 'reg' description in 'ccs_quirk' > drivers/media/i2c/ccs/ccs-quirk.h:50: warning: Excess struct member 'val' description in 'ccs_quirk' > Correct. It's never tried to understand that AFAIK. > Convert into a standard doc. > > Signed-off-by: Ricardo Ribalda Reviewed-by: Randy Dunlap Thanks. > --- > drivers/media/i2c/ccs/ccs-quirk.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/ccs/ccs-quirk.h b/drivers/media/i2c/ccs/ccs-quirk.h > index 0b1a64958d71..392c97109617 100644 > --- a/drivers/media/i2c/ccs/ccs-quirk.h > +++ b/drivers/media/i2c/ccs/ccs-quirk.h > @@ -28,11 +28,11 @@ struct ccs_sensor; > * @reg_access: Register access quirk. The quirk may divert the access > * to another register, or no register at all. > * > - * @write: Is this read (false) or write (true) access? > - * @reg: Pointer to the register to access > - * @value: Register value, set by the caller on write, or > + * -write: Is this read (false) or write (true) access? > + * -reg: Pointer to the register to access > + * -val: Register value, set by the caller on write, or > * by the quirk on read > - * @return: 0 on success, -ENOIOCTLCMD if no register > + * -return: 0 on success, -ENOIOCTLCMD if no register > * access may be done by the caller (default read > * value is zero), else negative error code on error > * @flags: Quirk flags > -- #Randy _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic