linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hkallweit1@gmail.com (Heiner Kallweit)
To: linus-amlogic@lists.infradead.org
Subject: Status of Meson GPIO IRQ support
Date: Tue, 25 Apr 2017 23:28:30 +0200	[thread overview]
Message-ID: <dbe0c7d8-ddd2-f006-c3b2-1144eee66850@gmail.com> (raw)
In-Reply-To: <1489564235.25254.5.camel@baylibre.com>

Am 15.03.2017 um 08:50 schrieb Jerome Brunet:
> On Tue, 2017-03-14 at 21:41 +0100, Heiner Kallweit wrote:
>> Jerome,
>>
>> when working on Meson I2C driver I was testing with a device where I wanted
>> to use a GPIO as interrupt source.
>> This isn't supported yet and when checking I found that end of last year
>> you submitted related patches. After some intense discussions I found no
>> further update.
>> Was this topic put on-hold due to bigger technical issues?
>>
> 
> Well, the proposed code does work but, as you have probaly seen for yourself,
> the maintainers of irqchip and gpio raised valid concerns, mainly about the way
> the mapping is created in the gpio driver. Ideally, the mapping should be
> created at probe time but, with a hierarchic interrupt domain, that means
> allocating the parent irq. We only have 8 of those for 100+ gpios. 
> 
> I'm still not sure how to address the problem to be honest: Is there a way to
> create mapping in hierarchy domain and allocate the parent only when the irq is
> actually requested ? Or should we simply not use a hierarchy domain for this
> controller (which seems to make sense) ?
> 
Meanwhile I became somewhat familiar with the irq subsystem and do some tests
with a GPIO IRQ driver based on GPIOLIB_IRQCHIP (in generic chained mode).

This basically works, however I have a problem with edge detection.
Level changes are not reliably detected. If I connect an input pin (configured
for edge irq generation) to a output pin and change the value of the output pin
no edge is detected. However if I use a cable to connect the input pin to
VCC/GND manually then most of the time edges are detected (not always).
Did you ever come across a similar problem during your tests?

Regards, Heiner

> I still hope to be able to do something on this topic but probably not tomorrow
> :( Of course, If you have some spare time and want to contribute on this topic,
> you are welcome to do so.
> 
>> Rgds, Heiner
> 
> Cheers
> 
> Jerome
> 

  reply	other threads:[~2017-04-25 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 20:41 Status of Meson GPIO IRQ support Heiner Kallweit
2017-03-15  7:50 ` Jerome Brunet
2017-04-25 21:28   ` Heiner Kallweit [this message]
2017-04-26  9:39     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbe0c7d8-ddd2-f006-c3b2-1144eee66850@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).