From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104C2C32771 for ; Tue, 7 Jan 2020 02:35:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DACD220715 for ; Tue, 7 Jan 2020 02:35:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s9OIm22d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DACD220715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0RrN9ngUkoxUjITbdOO7eHw3GFzgWPx6tG/gIPQeBwM=; b=s9OIm22dOfAcBJ WyGDkYWAnWT685VCiB2A4n8/dJLvZ7wLR93zq5W//xhbDUiJ82f9lHBykC24CqiOr5QoYosWRYQ3y 5hf3QeGknvuJCknKWsl3UQd5UzK2UsC2pzs00rmTNAVExT6jKLhfVxZGCSDysSFPJFzp3TSVeu81H 1mSvDypQCaqQIFa49z8u5Gmn7Gb2vfkc19FCWyGk9nopKSeQAcL/VxJ5TIoPauqI+arHRR9bXrsNV w82wulkHTt8fct/v1QSn/rsqdNssrdCZXBYllpGHhu5s4xjqVLsD5aoH0BgVasBdG4cImTXZ5cHm6 z7/a618ubs3cnFihHwqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioeiI-0003iz-3i; Tue, 07 Jan 2020 02:35:22 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioeiF-0003hn-Lb; Tue, 07 Jan 2020 02:35:21 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Tue, 7 Jan 2020 10:35:34 +0800 Subject: Re: [PATCH v3 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Rob Herring References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-2-git-send-email-hanjie.lin@amlogic.com> <20200104002806.GA24214@bogus> From: Hanjie Lin Message-ID: Date: Tue, 7 Jan 2020 10:35:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200104002806.GA24214@bogus> Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200106_183519_707572_3E6D5164 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , Jian Hu , Liang Yang , Qiufang Dai , Xingyu Chen , Kevin Hilman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2020/1/4 8:28, Rob Herring wrote: > On Fri, Dec 27, 2019 at 02:36:41PM +0800, Hanjie Lin wrote: >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Hanjie Lin >> Signed-off-by: Yue Wang >> --- >> .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 55 ++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> new file mode 100644 >> index 00000000..2b2c526 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> @@ -0,0 +1,55 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +# Copyright 2019 Amlogic, Inc >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic A1 USB2 PHY >> + >> +maintainers: >> + - Yue Wang >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,meson-a1-usb2-phy > > Use 'const' if there's only 1. > Ok >> + >> + reg: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + reset-names: >> + items: >> + - const: phy > > Don't need *-names when there's a single entry. > Ok >> + >> + "#phy-cells": >> + const: 0 >> + >> + power-domains: >> + maxItems: 1 >> + description: >> + a phandle to respective power domain node as described by generic >> + PM domain bindings (see power/power_domain.txt for more information). > > Drop the generic description. No need to duplicate everywhere. > Ok, I will modify these issues. Thanks Hanjie >> + >> +required: >> + - compatible >> + - reg >> + - resets >> + - reset-names >> + - "#phy-cells" >> + - power-domains >> + >> +examples: >> + - | >> + usb2_phy1: phy@40000 { >> + status = "okay"; >> + compatible = "amlogic,a1-usb2-phy"; >> + reg = <0x0 0x40000 0x0 0x2000>; >> + resets = <&reset RESET_USBPHY>; >> + reset-names = "phy"; >> + #phy-cells = <0>; >> + power-domains = <&pwrc PWRC_USB_ID>; >> + }; >> -- >> 2.7.4 >> > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic