From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F703C43334 for ; Tue, 5 Jul 2022 07:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4Dsa8lJt86EDdkTm4J0d5ktdK7BhbpX3dUypq751t+4=; b=l1+TnE30QBvXMk 9QeO3h6hJBOCFbByAS5PsV5uHt/GAVYXdx9x2ezydKXeF6Qzu1MYHFEE4oO6BxkHa8EQIrDuBLZzn hIjpb3GANx4SQk092qESkyEL8StOMNYppkgAgjxjvmZKSALpWtpFz/qxBa0TIlciRG/ejCy4+WfdX rOa6JAFX8xIemdsHagRW5FtlOpxW7e06HkN6EhbS/qRDiD/q8Q9rRl9bO3J033pQfijgjKKzblFwP GqJP2LEoz9u2eTYoXsC1P15dBbim7Hxe/grnVT5CiiyWZRmM7oKN9B9eeJ6pPJoH/muRbAfJwwgfM XjExEw2R3AggPwGIyb3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8cql-00FUBF-Cw; Tue, 05 Jul 2022 07:19:59 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8cqY-00FTYE-Kb for linux-amlogic@lists.infradead.org; Tue, 05 Jul 2022 07:19:49 +0000 Received: by mail-wm1-x335.google.com with SMTP id t17-20020a1c7711000000b003a0434b0af7so6771940wmi.0 for ; Tue, 05 Jul 2022 00:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=yBMd+QAMBurTUday06tJn1n/zGFmox+wPn3qVPhtdoE=; b=B9FMLO2K1AfQ0Yu89f/FDDQwafkTVkDnJjtheSuJXk2i3fGkJAN6Ggh1p4eVoR0pXs DPrL04mOpDho3V0enpONlV5jhMGXLCu9vPkiLJsXObhTngIX8PhmiX4oeCG8vyr8MYVd F7j8tsPCyaPeETD5wldgpJKQ8HAD0+B5hgDIIVSBuk44JB9fvlbP3ce1qIq8eW8tKN01 unhWK5n8BGTueCd6+Npy3Z60bgTT7UVP4Qp9G5gsO4qLM4UO2cRGjjWGTxJ85A4kYyqK jq0l0iXgAJFigXrvmtVEKqeUf7SJP6ZWsfmtDdlicioxdEHvXgOOd6rVKAdH3yVnpnVz JkCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=yBMd+QAMBurTUday06tJn1n/zGFmox+wPn3qVPhtdoE=; b=11GQUgg0FxP+vE63I8xJoesW+e7ovfbHq/ovPDkqTXsURxukcNs3dcM3QsY40T2M7h NZyNs8zbn1HRboZkC8BEOisKrvaQ3LOg56fdsOIL7oLp0NM6ynF+HKvqZhlu+b+TgMQs T6BWM0s6cWDHHq/qRpOCW4F7BuHpIcJKHmhzbfuqJ9jQL3jqg5lSHOX10e3iTk7Z687w wELI4bnhuzgCkmRd7Qk0E5efgnliWJzzDtJSWbNljs7EJRhxyVdV+L2ujCnKKXXYXP8q ow5/7CqW3XG10ycCbsXCysJpfiOX9N+UTjFNC92FgkAQo3uX5m3F6AL59CfhsHeq7iUr WYXw== X-Gm-Message-State: AJIora9dsqg7vDE60/jFXG7/xNUNX93GeEHnaFlaQyJtvSyCJlW6XPY+ VtQ5iyH8269X6lst+i4dXNMxJg== X-Google-Smtp-Source: AGRyM1tmSmQ136glZwFL8MnFX8NzY19FwN6EkYF5SnmCGdCMuL0+ixpR3qPpLgNEm7TC1xL9pB+47w== X-Received: by 2002:a05:600c:35cf:b0:3a0:49c1:f991 with SMTP id r15-20020a05600c35cf00b003a049c1f991mr35420825wmq.95.1657005581419; Tue, 05 Jul 2022 00:19:41 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:3c4f:78be:dc90:14f9? ([2001:861:44c0:66c0:3c4f:78be:dc90:14f9]) by smtp.gmail.com with ESMTPSA id m10-20020adff38a000000b0021d6de18f68sm3215032wro.22.2022.07.05.00.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 00:19:41 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 09:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 2/2] phy: amlogic: Add G12A Analog MIPI D-PHY driver Content-Language: en-US To: Vinod Koul Cc: kishon@ti.com, linux-phy@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220616133811.1674777-1-narmstrong@baylibre.com> <20220616133811.1674777-3-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_001946_877613_2F9F6FBD X-CRM114-Status: GOOD ( 22.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On 05/07/2022 08:44, Vinod Koul wrote: > On 16-06-22, 15:38, Neil Armstrong wrote: >> The Amlogic G12A SoCs embeds an Analog MIPI D-PHY used to communicate with DSI >> panels. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/phy/amlogic/Kconfig | 12 ++ >> drivers/phy/amlogic/Makefile | 1 + >> .../amlogic/phy-meson-g12a-mipi-dphy-analog.c | 177 ++++++++++++++++++ >> 3 files changed, 190 insertions(+) >> create mode 100644 drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c >> >> diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig >> index 486ca23aba32..e4d1170efd54 100644 >> --- a/drivers/phy/amlogic/Kconfig >> +++ b/drivers/phy/amlogic/Kconfig >> @@ -59,6 +59,18 @@ config PHY_MESON_G12A_USB3_PCIE >> in Meson G12A SoCs. >> If unsure, say N. >> >> +config PHY_MESON_G12A_MIPI_DPHY_ANALOG > > this should be sorted alphabetically, so before PHY_MESON_G12A_USB3_PCIE Ack > >> + tristate "Meson G12A MIPI Analog DPHY driver" >> + default ARCH_MESON >> + depends on OF && (ARCH_MESON || COMPILE_TEST) >> + select GENERIC_PHY >> + select REGMAP_MMIO >> + select GENERIC_PHY_MIPI_DPHY >> + help >> + Enable this to support the Meson MIPI Analog DPHY found in Meson G12A >> + SoCs. >> + If unsure, say N. >> + >> config PHY_MESON_AXG_PCIE >> tristate "Meson AXG PCIE PHY driver" >> default ARCH_MESON >> diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile >> index c0886c850bb0..91e3b9790c03 100644 >> --- a/drivers/phy/amlogic/Makefile >> +++ b/drivers/phy/amlogic/Makefile >> @@ -4,6 +4,7 @@ obj-$(CONFIG_PHY_MESON8B_USB2) += phy-meson8b-usb2.o >> obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o >> obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o >> obj-$(CONFIG_PHY_MESON_G12A_USB3_PCIE) += phy-meson-g12a-usb3-pcie.o >> +obj-$(CONFIG_PHY_MESON_G12A_MIPI_DPHY_ANALOG) += phy-meson-g12a-mipi-dphy-analog.o >> obj-$(CONFIG_PHY_MESON_AXG_PCIE) += phy-meson-axg-pcie.o >> obj-$(CONFIG_PHY_MESON_AXG_MIPI_PCIE_ANALOG) += phy-meson-axg-mipi-pcie-analog.o >> obj-$(CONFIG_PHY_MESON_AXG_MIPI_DPHY) += phy-meson-axg-mipi-dphy.o >> diff --git a/drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c b/drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c >> new file mode 100644 >> index 000000000000..adfcca38a952 >> --- /dev/null >> +++ b/drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c >> @@ -0,0 +1,177 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Meson G12A MIPI DSI Analog PHY >> + * >> + * Copyright (C) 2018 Amlogic, Inc. All rights reserved >> + * Copyright (C) 2020 BayLibre, SAS > > 2022 now? Well it was developed in 2020, but I'll update it anyway > >> + * Author: Neil Armstrong >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define HHI_MIPI_CNTL0 0x00 >> +#define HHI_MIPI_CNTL0_DIF_REF_CTL1 GENMASK(31, 16) >> +#define HHI_MIPI_CNTL0_DIF_REF_CTL0 GENMASK(15, 0) >> + >> +#define HHI_MIPI_CNTL1 0x04 >> +#define HHI_MIPI_CNTL1_BANDGAP BIT(16) >> +#define HHI_MIPI_CNTL2_DIF_REF_CTL2 GENMASK(15, 0) >> + >> +#define HHI_MIPI_CNTL2 0x08 >> +#define HHI_MIPI_CNTL2_DIF_TX_CTL1 GENMASK(31, 16) >> +#define HHI_MIPI_CNTL2_CH_EN GENMASK(15, 11) >> +#define HHI_MIPI_CNTL2_DIF_TX_CTL0 GENMASK(10, 0) >> + >> +#define DSI_LANE_0 BIT(4) >> +#define DSI_LANE_1 BIT(3) >> +#define DSI_LANE_CLK BIT(2) >> +#define DSI_LANE_2 BIT(1) >> +#define DSI_LANE_3 BIT(0) >> + >> +struct phy_g12a_mipi_dphy_analog_priv { >> + struct phy *phy; >> + struct regmap *regmap; >> + struct phy_configure_opts_mipi_dphy config; >> +}; >> + >> +static int phy_g12a_mipi_dphy_analog_configure(struct phy *phy, >> + union phy_configure_opts *opts) >> +{ >> + struct phy_g12a_mipi_dphy_analog_priv *priv = phy_get_drvdata(phy); >> + int ret; >> + >> + ret = phy_mipi_dphy_config_validate(&opts->mipi_dphy); >> + if (ret) >> + return ret; >> + >> + memcpy(&priv->config, opts, sizeof(priv->config)); >> + >> + return 0; >> +} >> + >> +static int phy_g12a_mipi_dphy_analog_power_on(struct phy *phy) >> +{ >> + struct phy_g12a_mipi_dphy_analog_priv *priv = phy_get_drvdata(phy); >> + unsigned int reg; >> + >> + regmap_write(priv->regmap, HHI_MIPI_CNTL0, >> + FIELD_PREP(HHI_MIPI_CNTL0_DIF_REF_CTL0, 0x8) | >> + FIELD_PREP(HHI_MIPI_CNTL0_DIF_REF_CTL1, 0xa487)); >> + >> + regmap_write(priv->regmap, HHI_MIPI_CNTL1, >> + FIELD_PREP(HHI_MIPI_CNTL2_DIF_REF_CTL2, 0x2e) | >> + HHI_MIPI_CNTL1_BANDGAP); >> + >> + regmap_write(priv->regmap, HHI_MIPI_CNTL2, >> + FIELD_PREP(HHI_MIPI_CNTL2_DIF_TX_CTL0, 0x459) | >> + FIELD_PREP(HHI_MIPI_CNTL2_DIF_TX_CTL1, 0x2680)); >> + >> + reg = DSI_LANE_CLK; >> + switch (priv->config.lanes) { >> + case 4: >> + reg |= DSI_LANE_3; >> + fallthrough; >> + case 3: >> + reg |= DSI_LANE_2; >> + fallthrough; >> + case 2: >> + reg |= DSI_LANE_1; >> + fallthrough; >> + case 1: >> + reg |= DSI_LANE_0; >> + break; >> + default: >> + reg = 0; >> + } >> + >> + regmap_update_bits(priv->regmap, HHI_MIPI_CNTL2, >> + HHI_MIPI_CNTL2_CH_EN, >> + FIELD_PREP(HHI_MIPI_CNTL2_CH_EN, reg)); >> + >> + return 0; >> +} >> + >> +static int phy_g12a_mipi_dphy_analog_power_off(struct phy *phy) >> +{ >> + struct phy_g12a_mipi_dphy_analog_priv *priv = phy_get_drvdata(phy); >> + >> + regmap_write(priv->regmap, HHI_MIPI_CNTL0, 0); >> + regmap_write(priv->regmap, HHI_MIPI_CNTL1, 0); >> + regmap_write(priv->regmap, HHI_MIPI_CNTL2, 0); >> + >> + return 0; >> +} >> + >> +static const struct phy_ops phy_g12a_mipi_dphy_analog_ops = { >> + .configure = phy_g12a_mipi_dphy_analog_configure, >> + .power_on = phy_g12a_mipi_dphy_analog_power_on, >> + .power_off = phy_g12a_mipi_dphy_analog_power_off, >> + .owner = THIS_MODULE, >> +}; >> + >> +static int phy_g12a_mipi_dphy_analog_probe(struct platform_device *pdev) >> +{ >> + struct phy_provider *phy; >> + struct device *dev = &pdev->dev; >> + struct phy_g12a_mipi_dphy_analog_priv *priv; >> + struct device_node *np = dev->of_node; >> + struct regmap *map; >> + int ret; >> + >> + priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); >> + if (!priv) >> + return -ENOMEM; >> + >> + /* Get the hhi system controller node */ >> + map = syscon_node_to_regmap(of_get_parent(dev->of_node)); >> + if (IS_ERR(map)) { >> + dev_err(dev, >> + "failed to get HHI regmap\n"); >> + return PTR_ERR(map); >> + } >> + >> + priv->regmap = map; >> + >> + priv->phy = devm_phy_create(dev, np, &phy_g12a_mipi_dphy_analog_ops); >> + if (IS_ERR(priv->phy)) { >> + ret = PTR_ERR(priv->phy); >> + if (ret != -EPROBE_DEFER) >> + dev_err(dev, "failed to create PHY\n"); > > log the error ? Ack > >> + return ret; >> + } >> + >> + phy_set_drvdata(priv->phy, priv); >> + dev_set_drvdata(dev, priv); >> + >> + phy = devm_of_phy_provider_register(dev, of_phy_simple_xlate); >> + >> + return PTR_ERR_OR_ZERO(phy); >> +} >> + >> +static const struct of_device_id phy_g12a_mipi_dphy_analog_of_match[] = { >> + { >> + .compatible = "amlogic,g12a-mipi-dphy-analog", >> + }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, phy_g12a_mipi_dphy_analog_of_match); >> + >> +static struct platform_driver phy_g12a_mipi_dphy_analog_driver = { >> + .probe = phy_g12a_mipi_dphy_analog_probe, >> + .driver = { >> + .name = "phy-meson-g12a-mipi-dphy-analog", >> + .of_match_table = phy_g12a_mipi_dphy_analog_of_match, >> + }, >> +}; >> +module_platform_driver(phy_g12a_mipi_dphy_analog_driver); >> + >> +MODULE_AUTHOR("Neil Armstrong "); >> +MODULE_DESCRIPTION("Meson G12A MIPI Analog D-PHY driver"); >> +MODULE_LICENSE("GPL v2"); >> -- >> 2.25.1 > Thanks for ther review, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic