From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBB2CC6FD1F for ; Wed, 22 Mar 2023 16:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c4dWho3mUzQbJunM3lcnow97JJlFgFEtW2zMfLeagO4=; b=zFrdYvyxz1P594zgQam5NBbsSG urqfVDPFBCqI0nRn3yuFeeoIB6lEv2mQ4OXSGjf8llPVqSpU8dhoaB2phesdvmAcFWlBhd4J5B+Bo 39v1UJxMSNly9VP1J6/7ZEFdfjTgRCzvWTW01IM3mkU8jXHqRCsj/E6Q3dwRWxR4BkoIXGL5/4Fv3 2K6HyMuuXtuUk4MQxTuT2nGNnlqGamuzZdeypZxtjK9I9Bvt6trA4nFotEegpgfhko2uoffcNCy7s PxjEzi0I5o8Yo7CrfQFMGABxYUp3sTUciTloDmdehRv0d7JsukYlPUcd4a0MrFxXEk6lAdNFKlve0 askbjmTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pf0t2-00GZt0-38; Wed, 22 Mar 2023 16:00:28 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pf0sz-00GZs5-2V for linux-amlogic@lists.infradead.org; Wed, 22 Mar 2023 16:00:27 +0000 Received: by mail-wr1-x430.google.com with SMTP id e18so6080780wra.9 for ; Wed, 22 Mar 2023 09:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679500823; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=b1A56twIdd4XdlBDQ/o8uz6vaFh0/U1CPyi1UN3+GrI=; b=ziXK8E/wvSN6p/5FBJRC6CeiEKqO6RkykeFO/BFCiquAcE1xwEpmgdBsP0b9k9LkGe MJLn8PdV/rIj6jeU7DkN9FICKLG5P7nSYucrtEw3UUo0iVyzjsuk0Xe4CNKMWfhlsTvv alfKa4MrwfRxcdT+XVy8cIxUN6FBl1Z3elzCSi3EKqXlmVS+ZCB5OhSbUw7e0whuxGAv 4vBx8T7V4eEfNyiwZJ8/JvRv2FxCYPyy3nSZjcmw98qwImaZ1uEgfBaWvpvQZOPhrBi0 dFqvicKLRZg9sBRzzbW3lHrxmOciOjKjZ5Uqp2OJ/Vtj0e5L2em0MYotmU5QKoDBWSZe ePIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679500823; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b1A56twIdd4XdlBDQ/o8uz6vaFh0/U1CPyi1UN3+GrI=; b=o+Bb6jOAj2x2SnGkbA5voBPwg7mGS3XdnYYqyj2nIPR43Um/yGI6NLtumUZsWnl2iT 3+FbK9RdIZwcT+doDHyBiMFuZWCV4rLgo6GNNpH2TUXIGJBvksNnI3No6cNnWvcDvj0I BkRmYsPi7sQjCWHmwQQfJeUoLDL+ybRP2lS1A4wqhR4ZCP6RH2JPMiMo+wZTaPqro893 +ppojVMTUv09z2u898k4sqDjb+h8ZLeiqggtX2H3zeke6EiqLyI4H5nJLZvvKcXkNVaS 2X9IJmMm/5YlL7KM8moh9utUC5lkGyeygIoe/NW7Vjgl3bzyLncWn5LsOlyP3oWtnzz9 kMnQ== X-Gm-Message-State: AAQBX9cbuWjxfofDeEnF+d7BLH+FJoHjdbtxh/C4Pqo76F69nTQ6djaO p8VFC5YLxpF8ZIV5yUjO5hgTJA== X-Google-Smtp-Source: AKy350bPd3r7zDh6GA3RkT4KF6T12j2TXmukQIC7PsSb5x/WiuAQyTCvWTHYGJRvcxGKZ+SHhO2Esw== X-Received: by 2002:adf:e70c:0:b0:2cf:efc7:19ad with SMTP id c12-20020adfe70c000000b002cfefc719admr210428wrm.53.1679500823327; Wed, 22 Mar 2023 09:00:23 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:3606:a601:f273:994a? ([2a01:e0a:982:cbb0:3606:a601:f273:994a]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c154900b003ede03e4369sm11749524wmg.33.2023.03.22.09.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 09:00:22 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 17:00:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Neil Armstrong Subject: Re: [PATCH v1 2/2] spi: add support for Meson A1 SPI Flash Controller Content-Language: en-US To: Martin Kurbanov , Mark Brown , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru References: <20230322150458.783901-1-mmkurbanov@sberdevices.ru> <20230322150458.783901-3-mmkurbanov@sberdevices.ru> Organization: Linaro Developer Services In-Reply-To: <20230322150458.783901-3-mmkurbanov@sberdevices.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230322_090025_925393_8B1AE89F X-CRM114-Status: GOOD ( 21.44 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On 22/03/2023 16:04, Martin Kurbanov wrote: > This is a driver for the Amlogic Meson SPI flash controller support > on A113L SoC. > > Signed-off-by: Martin Kurbanov > --- > drivers/spi/Kconfig | 7 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-meson-spifc-a1.c | 444 +++++++++++++++++++++++++++++++ > 3 files changed, 452 insertions(+) > create mode 100644 drivers/spi/spi-meson-spifc-a1.c > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index 3b1c0878bb85..a12452bd1e0c 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -582,6 +582,13 @@ config SPI_MESON_SPIFC > This enables master mode support for the SPIFC (SPI flash > controller) available in Amlogic Meson SoCs. > > +config SPI_MESON_SPIFC_A1 > + tristate "Amlogic Meson A113L SPIFC controller" The title should be "Amlogic Meson A1 SPIFC controller" for coherency. > + depends on ARCH_MESON || COMPILE_TEST > + help > + This enables master mode support for the SPIFC (SPI flash > + controller) available in Amlogic Meson A113L (A1 family) SoC. You should write the reverse: available in Amlogic Meson A1 Family (A113L SoC). > + > config SPI_MICROCHIP_CORE > tristate "Microchip FPGA SPI controllers" > depends on SPI_MASTER > diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile > index be9ba40ef8d0..702053970967 100644 > --- a/drivers/spi/Makefile > +++ b/drivers/spi/Makefile > @@ -72,6 +72,7 @@ obj-$(CONFIG_SPI_LM70_LLP) += spi-lm70llp.o > obj-$(CONFIG_SPI_LP8841_RTC) += spi-lp8841-rtc.o > obj-$(CONFIG_SPI_MESON_SPICC) += spi-meson-spicc.o > obj-$(CONFIG_SPI_MESON_SPIFC) += spi-meson-spifc.o > +obj-$(CONFIG_SPI_MESON_SPIFC_A1) += spi-meson-spifc-a1.o > obj-$(CONFIG_SPI_MICROCHIP_CORE) += spi-microchip-core.o > obj-$(CONFIG_SPI_MICROCHIP_CORE_QSPI) += spi-microchip-core-qspi.o > obj-$(CONFIG_SPI_MPC512x_PSC) += spi-mpc512x-psc.o > diff --git a/drivers/spi/spi-meson-spifc-a1.c b/drivers/spi/spi-meson-spifc-a1.c > new file mode 100644 > index 000000000000..213c8b692675 > --- /dev/null > +++ b/drivers/spi/spi-meson-spifc-a1.c > @@ -0,0 +1,444 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Driver for Amlogic Meson A113L SPI flash controller (SPIFC) Same here > + * > + * Copyright (c) 2023, SberDevices. All Rights Reserved. > + * > + * Author: Martin Kurbanov > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define A1_SPIFC_AHB_CTRL_REG 0x0 > +#define A1_SPIFC_AHB_BUS_EN BIT(31) I find the "A1_SPIFC" hard to read, I think you should reverse it in all the file into : #define SPIFC_A1_... and static XXX meson_spifc_a1_request to be coherent with the legacy spifc driver and spicc driver. > + > +MODULE_AUTHOR("Martin Kurbanov "); > +MODULE_DESCRIPTION("Amlogic Meson A113L SPIFC driver"); Same here "Meson A1 SPIFC driver" > +MODULE_LICENSE("GPL"); Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic