From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B408C54E4A for ; Thu, 7 Mar 2024 14:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SZVTwx1ZH4KbuJL1CAd8EAfMPLQqLZio0L/KbWuLJUQ=; b=bPcw8Fsnegiviy LvF/AzFRl7BMUb8N2vtvhcptv3rEJ2qg+NyeQu6iCVtT06tbXQiTJ0rxZbVdDdmR8KbpWtLE3wFmD 4osaAPpxrJQvCAXYw2mHfrEJBsyyOAWlS+gLUABokoX57XjJ21bi25I54pGy++v0uMIxmdVtsGr/z EdVGk9zUX+1VrOhi296wbHXncuTNU3Nz13R8ixhcVu1ZWghAmHS0ZPs0byoTp+qEIFDv1Zo6yoZ8V y6a1EPb1FJDFLEiSEv96oKoWSm9OgclWxClWcvDebDYF3dng2mwAsOxyDlecNlZqOxrkvYqvq2az8 iauuHr9zyZLrOy+M2x1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riEKX-00000004uu4-3voS; Thu, 07 Mar 2024 14:02:41 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riEKT-00000004uqj-1cxj; Thu, 07 Mar 2024 14:02:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709820155; bh=ZIhPB/qLdXpK4MZKtW9rnHxM6+5wDqNGfhxfTeZKrO0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=zdg5y6GRQA4Yv2JLzuSfqTDEE1PR3nzF4aJiy4wpylltl0EbyfeJpBsGectXg8vky DrPOARI+gbZDHAsgoUyxZ204EHuUxt+qX+W0Ad3uOOeb3brbPM0XjUvUS9L85whYIM tyc+GApxOUeN3XsvhoStzUgsn06ztHgBKp2Y+BKqyqKH5MzkPA3PljScW60fPz4RsZ M7BYYohhOV8epa0CyFF5pt2UIqAvRx0PrSa+uNpZnRgBUTMqBBUXa3FNO85us6/cBC uekqJyVj0luROzmJkguMwiE8pt4/6Eslv7RyaPB/3sOj6TZCpL0EZ9+gYcpBMX/tsj k46Qb5Pg9M1vg== Received: from [100.95.196.25] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: koike) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 9610E3780624; Thu, 7 Mar 2024 14:02:29 +0000 (UTC) Message-ID: Date: Thu, 7 Mar 2024 11:02:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/11] drm/ci: mediatek: Refactor existing mediatek jobs Content-Language: en-US To: Vignesh Raman , dri-devel@lists.freedesktop.org Cc: daniels@collabora.com, airlied@gmail.com, daniel@ffwll.ch, emma@anholt.net, robdclark@gmail.com, david.heidelberg@collabora.com, guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, hamohammed.sa@gmail.com, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, mairacanal@riseup.net, mcanal@igalia.com, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240306030649.60269-1-vignesh.raman@collabora.com> <20240306030649.60269-6-vignesh.raman@collabora.com> From: Helen Koike In-Reply-To: <20240306030649.60269-6-vignesh.raman@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_060237_670416_E033B2AB X-CRM114-Status: GOOD ( 24.18 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 06/03/2024 00:06, Vignesh Raman wrote: > For mediatek mt8173 and mt8183, the display driver is mediatek. > Currently, in drm-ci for mediatek, only the display driver is > tested. Refactor the existing mediatek jobs so that gpu driver > testing jobs can be added later and update xfails accordingly. > Since the correct driver name is passed from the job to test gpu > and display driver, remove the check to set IGT_FORCE_DRIVER > based on driver name. > > Signed-off-by: Vignesh Raman > --- > > v2: > - Refactor the patch to rename job to indicate display driver testing, > rename the existing xfail files, and remove IGT_FORCE_DRIVER from the > script since it's now set by the job. > > v3: > - Add the job name in GPU_VERSION and use it for xfail file names instead > of using DRIVER_NAME. Also update xfails. > > v4: > - Remove the display suffix in job and rename xfails accordingly. > Remove the change adding job name in GPU_VERSION. > > --- > drivers/gpu/drm/ci/igt_runner.sh | 10 --------- > drivers/gpu/drm/ci/test.yml | 21 ++++++++++++++----- > .../drm/ci/xfails/mediatek-mt8173-fails.txt | 15 ------------- > .../drm/ci/xfails/mediatek-mt8173-flakes.txt | 13 ++++++++++++ > .../drm/ci/xfails/mediatek-mt8183-fails.txt | 21 ++++++++++++------- > .../drm/ci/xfails/mediatek-mt8183-flakes.txt | 8 +++++++ > 6 files changed, 50 insertions(+), 38 deletions(-) > create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt > create mode 100644 drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt > > diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh > index 77cd81fe6d1a..711f32772e48 100755 > --- a/drivers/gpu/drm/ci/igt_runner.sh > +++ b/drivers/gpu/drm/ci/igt_runner.sh > @@ -20,16 +20,6 @@ cat /sys/kernel/debug/dri/*/state > set -e > > case "$DRIVER_NAME" in > - rockchip|meson) > - export IGT_FORCE_DRIVER="panfrost" > - ;; > - mediatek) > - if [ "$GPU_VERSION" = "mt8173" ]; then > - export IGT_FORCE_DRIVER=${DRIVER_NAME} > - elif [ "$GPU_VERSION" = "mt8183" ]; then > - export IGT_FORCE_DRIVER="panfrost" > - fi > - ;; > amdgpu) > # Cannot use HWCI_KERNEL_MODULES as at that point we don't have the module in /lib > mv /install/modules/lib/modules/* /lib/modules/. > diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml > index 0857773e5c5f..f8f48523ada3 100644 > --- a/drivers/gpu/drm/ci/test.yml > +++ b/drivers/gpu/drm/ci/test.yml > @@ -282,29 +282,40 @@ amdgpu:stoney: > - .lava-igt:arm64 > stage: mediatek > variables: > - DRIVER_NAME: mediatek > DTB: ${DEVICE_TYPE} > BOOT_METHOD: depthcharge > KERNEL_IMAGE_TYPE: "" > > -mediatek:mt8173: > +.mt8173: > extends: > - .mediatek > parallel: 4 > variables: > DEVICE_TYPE: mt8173-elm-hana > - GPU_VERSION: mt8173 Looks like it make sense to keep GPU_VERSION here, no? Same comment for .mt8183. Regards, Helen > RUNNER_TAG: mesa-ci-x86-64-lava-mt8173-elm-hana > > -mediatek:mt8183: > +.mt8183: > extends: > - .mediatek > parallel: 3 > variables: > DEVICE_TYPE: mt8183-kukui-jacuzzi-juniper-sku16 > - GPU_VERSION: mt8183 > RUNNER_TAG: mesa-ci-x86-64-lava-mt8183-kukui-jacuzzi-juniper-sku16 > > +mediatek:mt8173: > + extends: > + - .mt8173 > + variables: > + GPU_VERSION: mt8173 > + DRIVER_NAME: mediatek > + > +mediatek:mt8183: > + extends: > + - .mt8183 > + variables: > + GPU_VERSION: mt8183 > + DRIVER_NAME: mediatek > + > # drm-mtk doesn't even probe yet in mainline for mt8192 > .mediatek:mt8192: > extends: > diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt > index ef0cb7c3698c..c63abd603b02 100644 > --- a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt > +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-fails.txt > @@ -9,28 +9,13 @@ kms_bw@linear-tiling-3-displays-1920x1080p,Fail > kms_bw@linear-tiling-3-displays-2560x1440p,Fail > kms_bw@linear-tiling-3-displays-3840x2160p,Fail > kms_color@invalid-gamma-lut-sizes,Fail > -kms_color@pipe-A-invalid-gamma-lut-sizes,Fail > -kms_color@pipe-B-invalid-gamma-lut-sizes,Fail > kms_cursor_legacy@cursor-vs-flip-atomic,Fail > kms_cursor_legacy@cursor-vs-flip-legacy,Fail > kms_flip@flip-vs-modeset-vs-hang,Fail > kms_flip@flip-vs-panning-vs-hang,Fail > kms_flip@flip-vs-suspend,Fail > kms_flip@flip-vs-suspend-interruptible,Fail > -kms_force_connector_basic@force-edid,Fail > -kms_force_connector_basic@force-load-detect,Fail > -kms_force_connector_basic@prune-stale-modes,Fail > -kms_hdmi_inject@inject-4k,Fail > -kms_plane_scaling@planes-upscale-20x20,Fail > -kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25,Fail > -kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5,Fail > -kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-75,Fail > -kms_plane_scaling@upscale-with-modifier-20x20,Fail > -kms_plane_scaling@upscale-with-pixel-format-20x20,Fail > -kms_plane_scaling@upscale-with-rotation-20x20,Fail > kms_properties@get_properties-sanity-atomic,Fail > kms_properties@plane-properties-atomic,Fail > kms_properties@plane-properties-legacy,Fail > kms_rmfb@close-fd,Fail > -kms_selftest@drm_format,Timeout > -kms_selftest@drm_format_helper,Timeout > diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt > new file mode 100644 > index 000000000000..64b30c092c85 > --- /dev/null > +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8173-flakes.txt > @@ -0,0 +1,13 @@ > +# Board Name: mt8173-elm-hana.dtb > +# Bug Report: https://lore.kernel.org/dri-devel/931e3f9a-9c5c-fc42-16fc-abaac4e0c0ff@collabora.com/T/#u > +# IGT Version: 1.28-gd2af13d9f > +# Failure Rate: 50 > +# Linux Version: 6.7.0-rc3 > + > +# Reported by deqp-runner > +kms_cursor_legacy@cursor-vs-flip-atomic-transitions > + > +# Below test shows inconsistency across multiple runs, > +# giving results of Pass and Timeout/Fail alternately > +kms_prop_blob@invalid-set-prop > +kms_prop_blob@invalid-set-prop-any > diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt > index 67d690fc4037..28c825c9cd60 100644 > --- a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt > +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-fails.txt > @@ -1,13 +1,18 @@ > -kms_addfb_basic@addfb25-bad-modifier,Fail > +core_setmaster_vs_auth,Fail > +kms_bw@linear-tiling-1-displays-1920x1080p,Fail > kms_bw@linear-tiling-1-displays-2560x1440p,Fail > +kms_bw@linear-tiling-1-displays-3840x2160p,Fail > kms_bw@linear-tiling-2-displays-1920x1080p,Fail > kms_bw@linear-tiling-2-displays-2560x1440p,Fail > kms_bw@linear-tiling-2-displays-3840x2160p,Fail > -kms_bw@linear-tiling-3-displays-2560x1440p,Fail > -kms_bw@linear-tiling-3-displays-3840x2160p,Fail > -kms_color@pipe-A-invalid-gamma-lut-sizes,Fail > -kms_plane_cursor@overlay,Fail > -kms_plane_cursor@primary,Fail > -kms_plane_cursor@viewport,Fail > -kms_plane_scaling@upscale-with-rotation-20x20,Fail > +kms_color@invalid-gamma-lut-sizes,Fail > +kms_cursor_legacy@cursor-vs-flip-atomic,Fail > +kms_cursor_legacy@cursor-vs-flip-legacy,Fail > +kms_flip@flip-vs-modeset-vs-hang,Fail > +kms_flip@flip-vs-panning-vs-hang,Fail > +kms_flip@flip-vs-suspend,Fail > +kms_prop_blob@invalid-set-prop-any,Fail > +kms_properties@get_properties-sanity-atomic,Fail > +kms_properties@plane-properties-atomic,Fail > +kms_properties@plane-properties-legacy,Fail > kms_rmfb@close-fd,Fail > diff --git a/drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt > new file mode 100644 > index 000000000000..5885a950fa72 > --- /dev/null > +++ b/drivers/gpu/drm/ci/xfails/mediatek-mt8183-flakes.txt > @@ -0,0 +1,8 @@ > +# Board Name: mt8183-kukui-jacuzzi-juniper-sku16.dtb > +# Bug Report: https://lore.kernel.org/dri-devel/931e3f9a-9c5c-fc42-16fc-abaac4e0c0ff@collabora.com/T/#u > +# IGT Version: 1.28-gd2af13d9f > +# Failure Rate: 100 > +# Linux Version: 6.7.0-rc3 > + > +# Reported by deqp-runner > +kms_cursor_legacy@cursor-vs-flip-atomic-transitions _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic