From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54BCDC54EAA for ; Fri, 27 Jan 2023 07:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pma/2YPQoCoqwBr1VhpP7pHFBT8na3qRZl20jE/Qdqo=; b=SqMqJ1N7p0tilxxBCxYHCZFbF3 QB7dI4SHNwp8Q+qhAjbFlkb9PDVgSKqm3C4lMgcXkNGPYnPL4HfMQyAVmCnLGTo33Toww48rT/+Kr AwHhiUPXtNIn9vfo7Uv87fcTCHMzrXdpfTX1gGPc3UEeuHLWbFdmdZoI7Nx1bcuyl1EybDzVAeAoV yoPLOn/yTFuDzSKttImAUVAgprjANZpk1uuJCav5A4riPtWR0aQgYhdO2UYKCnV0TRWFeJDLMdxEf vfTnpYcispr2/JtHU3tReD04vb1yU2yXJWLwP/SM4kAkVAyJuDNYgRpKcT07lOEef6Sk03e2xMccA YJq2yFXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLJe5-00DTFZ-S5; Fri, 27 Jan 2023 07:59:37 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLJe2-00DTDV-GN for linux-amlogic@lists.infradead.org; Fri, 27 Jan 2023 07:59:36 +0000 Received: by mail-wm1-x32d.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so4843278wmb.0 for ; Thu, 26 Jan 2023 23:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=1evn3OyldRBX/K2AFHL4ychXVXaRi8/AkJ+MuWZq/ac=; b=H8ZQbYQ0qiQQQOPGue/P+jRbQUjuHHcHCTs4qIHHld/3wBDSgZW3yak0ee0Z3ChgzO dAZ8nXgLnXEnNmuaxl/ugKfb0tHwLgY/VWzcnQveE22HjtSCmSrQ3bF5159iG0EEon79 AwM8+lV3gX9xHnfmyGOv73SByMrC0s1tVFldIDoUxDMzcwEpHZIk3Apd3FfP+ZXHJSR5 VBmRbnRbS7+gZnkIEYX7u0Er64c1Tf+o8fWkyQUg35x3Iawpkk4p4J1s3CFhI2SCdz6U 78sN5iXvZHFwn73kx6RCBEPKDuP6weo/uHasVOdQhkdjVr+h7JNP2N4LrqXb8rkDdfnz +LnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1evn3OyldRBX/K2AFHL4ychXVXaRi8/AkJ+MuWZq/ac=; b=iZcFb3v+O3doCPLMXlUzv5EoAhgsO9A1m2Hs5L1+YtqVqjgSReACivSc/8SmFz66LR Maqmes/a+EHkSd+vylymMTy2u9dHGnMmwbNCgTbQgnTLWUmlKrpKG3teWgRFXsDrC4bc wVHhgNwrr5A76bPJEt8/F6FQpHesSnLY5RXhfupURUlqMAWKH6podkh/vG5T1TH+duyo vRyC5a38xLUWT2AnjjHFJaSsgIJWxGjIHGqSeNN7oiZnVTyr0oAbNYuQjZj34sV7cANj 1g1CRG8QTtxyrZTQuSmkTjL+BusTvAN2BFP3RSDqFWjz4D7Px4NdEpX9+kUjxmY99Pzx T51Q== X-Gm-Message-State: AFqh2kqCvN4QNsxQy+3r5ZCLqmJqbPj33xhPa0mdh+LsgUZeI6EEQEHq +1QW41w/0UvWCp3WQvT8B4sozA== X-Google-Smtp-Source: AMrXdXsYVu7APJnfmWx6Uh1ruX4EvjzTSsoxvfK/aNb67COhAEo48Je3QQmrOduqRfjzUmfVj2CNVQ== X-Received: by 2002:a7b:c4d7:0:b0:3db:2fc6:e124 with SMTP id g23-20020a7bc4d7000000b003db2fc6e124mr27740602wmk.7.1674806371186; Thu, 26 Jan 2023 23:59:31 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:d4ec:15ea:873c:61e6? ([2a01:e0a:982:cbb0:d4ec:15ea:873c:61e6]) by smtp.gmail.com with ESMTPSA id p22-20020a1c5456000000b003da286f8332sm3673828wmi.18.2023.01.26.23.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 23:59:30 -0800 (PST) Message-ID: Date: Fri, 27 Jan 2023 08:59:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Subject: Re: [PATCH v2] arm64: dts: amlogic: Make mmc host controller interrupts level-sensitive Content-Language: en-US To: Heiner Kallweit , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." References: Organization: Linaro Developer Services In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_235934_588978_D8B453B2 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On 26/01/2023 15:03, Heiner Kallweit wrote: > The usage of edge-triggered interrupts lead to lost interrupts under load, > see [0]. This was confirmed to be fixed by using level-triggered > interrupts. > The report was about SDIO. However, as the host controller is the same > for SD and MMC, apply the change to all mmc controller instances. Thanks, I applied it in for-next so it runs on the CI tests. > > [0] https://www.spinics.net/lists/linux-mmc/msg73991.html > > Fixes: 1499218c80c9 ("arm64: dts: move common G12A & G12B modes to meson-g12-common.dtsi") I think we should find a better Fixes or perhaps split in 3 so it targets the right commit adding the nodes for each family. If the test doesn't report any breakage, I'll probably ask you that. Neil > Reported-by: Peter Suti > Tested-by: Peter Suti > Cc: stable@vger.kernel.org > Signed-off-by: Heiner Kallweit > --- > v2: > - apply the fix also to meson-axg > - apply the fix to all host controller instances > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++-- > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 +++--- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 +++--- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index ed895fb32..a6a3095de 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -1886,7 +1886,7 @@ apb: bus@ffe00000 { > sd_emmc_b: mmc@5000 { > compatible = "amlogic,meson-axg-mmc"; > reg = <0x0 0x5000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > clocks = <&clkc CLKID_SD_EMMC_B>, > <&clkc CLKID_SD_EMMC_B_CLK0>, > @@ -1898,7 +1898,7 @@ sd_emmc_b: mmc@5000 { > sd_emmc_c: mmc@7000 { > compatible = "amlogic,meson-axg-mmc"; > reg = <0x0 0x7000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > clocks = <&clkc CLKID_SD_EMMC_C>, > <&clkc CLKID_SD_EMMC_C_CLK0>, > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > index 6d7272b2c..13fdaba21 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi > @@ -2324,7 +2324,7 @@ uart_A: serial@24000 { > sd_emmc_a: mmc@ffe03000 { > compatible = "amlogic,meson-axg-mmc"; > reg = <0x0 0xffe03000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > clocks = <&clkc CLKID_SD_EMMC_A>, > <&clkc CLKID_SD_EMMC_A_CLK0>, > @@ -2336,7 +2336,7 @@ sd_emmc_a: mmc@ffe03000 { > sd_emmc_b: mmc@ffe05000 { > compatible = "amlogic,meson-axg-mmc"; > reg = <0x0 0xffe05000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > clocks = <&clkc CLKID_SD_EMMC_B>, > <&clkc CLKID_SD_EMMC_B_CLK0>, > @@ -2348,7 +2348,7 @@ sd_emmc_b: mmc@ffe05000 { > sd_emmc_c: mmc@ffe07000 { > compatible = "amlogic,meson-axg-mmc"; > reg = <0x0 0xffe07000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > clocks = <&clkc CLKID_SD_EMMC_C>, > <&clkc CLKID_SD_EMMC_C_CLK0>, > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index e3c12e0be..5eed15035 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -603,21 +603,21 @@ apb: apb@d0000000 { > sd_emmc_a: mmc@70000 { > compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > reg = <0x0 0x70000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > }; > > sd_emmc_b: mmc@72000 { > compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > reg = <0x0 0x72000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > }; > > sd_emmc_c: mmc@74000 { > compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > reg = <0x0 0x74000 0x0 0x800>; > - interrupts = ; > + interrupts = ; > status = "disabled"; > }; > }; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic