From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Huqiang Qin <huqiang.qin@amlogic.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
narmstrong@baylibre.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h
Date: Fri, 26 Aug 2022 20:40:13 +0300 [thread overview]
Message-ID: <fd2c9ca1-5ff6-3c45-fc10-90167c413061@linaro.org> (raw)
In-Reply-To: <20220826122338.2452433-1-huqiang.qin@amlogic.com>
On 26/08/2022 15:23, Huqiang Qin wrote:
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
>
> e.g.
> * Bluetooth enable pin:
> bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> * Audio mute pin:
> spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
> * ...
Then the header should be added when the need is implemented. Do not add
unused headers to files.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-08-26 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 12:23 [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h Huqiang Qin
2022-08-26 17:40 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-29 4:35 Huqiang Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd2c9ca1-5ff6-3c45-fc10-90167c413061@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).