From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970A7606A31C for ; Tue, 17 Nov 2026 06:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SGXAOAL4; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=E0EscKcz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=j8eDI2T/AwQVAnSjt3DNJb5yOy3c59wwisESVbNa7/M=; b=SGXAOAL4bRBC3EAYj8QqH0OnPd 0kXzT7T+YegkCb1pJxsSEerp5ZMA+5diDfscTBsLilrSppw106Y/YqnExnB/W3i6zPziDSu8owkE7 Z+JmCF7PjyZ186oskMJrQ6USCqCVdf+SXvPIAAPk0OrLct3m4+SGfQXn94DWOnW/C43LXArlztl5y EeK4Rxi8PtE7qzGlO4HGDYC7qkYMtY4q2oV87ZpgdC73lbjr2rBwyxbwb1WQcZR3Q+hwmwlG3mvV8 Yb0iOJWcd2nziVs1m2isH9pFFI8suwMhgdHGgEvA6ZXAGHgJWAWAhxDvPrEIJfp3t2KyycNgVCugD XqYO5Mkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTCLg-00000004eAC-2QUQ; Tue, 17 Nov 2026 06:07:20 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTCLd-00000004e9Z-2Iqp for linux-amlogic@lists.infradead.org; Tue, 17 Nov 2026 06:07:19 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 855B461CFE; Tue, 17 Nov 2026 06:07:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6A741F000C4; Tue, 17 Nov 2026 06:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794895636; bh=Pkj1bOJmGhwStbcVBtig6+X3xOLp8HKGqfSBHFXYFWg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=E0EscKczHQfqmh4Uzm0CLi+wSI3ByuoAV73srujafaKWc8h+Y+ahLYcmh9Qim5MX9 JcRE7GUGA5NLZ+lHjSmD45Poe1ACtsvSRUW6JWeZjjToPZzCtrn/HmM5hoySbrq0yX lV3S5TaILzScYc87/4R9wMQt0ABKuCzUfNc4/8F4qjWH+kWGKX4WUPfYMwyy5h5mOG uxSqR0NVXlWp6Q65idwAHctigFehOvHBHL1gbsWo4IOl6QkapbQJq5S4uQCM7KfooS E9BIfe4KFGlD9np0Mk49oCYJNN9+Oi1iqlvgP16G9jGHA5X3vjAY3KmvX5SH3H66NU SDv0KUifwsYfw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v9 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261117-a9-i2c-v9-2-7b303c894fea@amlogic.com> References: <20261117-a9-i2c-v9-0-7b303c894fea@amlogic.com> <20261117-a9-i2c-v9-2-7b303c894fea@amlogic.com> Date: Tue, 17 Nov 2026 06:07:15 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtNZWRpdW1dIGkyYzogYW1sb2dpYy1h OTogdHJhbnNmZXIgc3RhcnRlZCBiZWZvcmUgSVJRIHNldHVwIGluCiAgYW1sX2kyY19kb19zdGFy dCgpCi0gW01lZGl1bV0gaTJjOiBhbWxvZ2ljLWE5OiBzdGFsZSBpcnFfc3RhdGUgYW5kIGVkZ2Ug SVJRIG1pc3MgaW4KICBhbWxfaTJjX2lycSgpCi0tCgpjb21taXQgMDNjMTNlNjUzN2Q3NzFkYmY0 NTI4NDYzOWE2ZDZkMzE1MTFiOWVlNApBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1s b2dpYy5jb20+CgppMmM6IGFtbG9naWM6IEFkZCBBbWxvZ2ljIEE5IEkyQyBjb250cm9sbGVyIGRy aXZlcgoKVGhpcyBjb21taXQgYWRkcyBhbiBJMkMgY29udHJvbGxlciBkcml2ZXIgZm9yIEFtbG9n aWMgQTkgU29DcywgYWxvbmcgd2l0aApLY29uZmlnLCBNYWtlZmlsZSwgYW5kIE1BSU5UQUlORVJT IGVudHJpZXMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFtbG9naWMt YTkuYyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtYW1sb2dpYy1hOS5jCj4gbmV3IGZpbGUgbW9k ZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi44NDkyYzEzNjgwYWFiCj4gLS0tIC9kZXYv bnVsbAo+ICsrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtYW1sb2dpYy1hOS5jClsgLi4uIF0K PiArc3RhdGljIGlycXJldHVybl90IGFtbF9pMmNfaXJxKGludCBpcnFubywgdm9pZCAqZGV2X2lk KQo+ICt7Cj4gKwlzdHJ1Y3QgYW1sX2kyYyAqaTJjID0gZGV2X2lkOwo+ICsJdTggKmJ1ZiA9IE5V TEw7Cj4gKwl1MzIgcmRfbGVuLCBpOwo+ICsJdTMyIHJkX3ZhbDsKPiArCXUzMiBpcnFfc3RhdGU7 Cj4gKwo+ICsJZ3VhcmQoc3BpbmxvY2spKCZpMmMtPmxvY2spOwo+ICsJaXJxX3N0YXRlID0gcmVh ZGwoaTJjLT5yZWdzICsgUkVHX0NGR19JUlFfU1RBVEUpOwo+ICsJaWYgKGkyYy0+c3RhdGUgPT0g QTlfU1RBVEVfSURMRSkgewo+ICsJCWRldl93YXJuKGkyYy0+ZGV2LCAiaTJjIGlycSB0cmlnZ2Vy ZWQgYWJub3JtYWxseSwgaXJxX3N0YXRlOjB4JXgsaXJxX2VuOjB4JXhcbiIsCj4gKwkJCSBpcnFf c3RhdGUsIHJlYWRsKGkyYy0+cmVncyArIFJFR19DRkdfSVJRX0VOQUJMRSkpOwo+ICsJCWdvdG8g aXJxX3RyYW5zX291dDsKPiArCX0KPiArCj4gKwlpZiAoaXJxX3N0YXRlICYgQTlfVFJBTlNfRVJS T1IpIHsKPiArCQlpMmMtPmVycm9yID0gLUVOWElPOwo+ICsJCWdvdG8gY29tcGxldGVfaXJxX291 dDsKPiArCX0KPiArCj4gKwlzd2l0Y2ggKGkyYy0+c3RhdGUpIHsKPiArCWNhc2UgQTlfU1RBVEVf UkVBRDoKPiArCQlidWYgPSBpMmMtPm1zZy0+YnVmOwo+ICsJCXJkX2xlbiA9IG1pbihpMmMtPm1z Zy0+bGVuIC0gaTJjLT5wb3MsIEE5X0kyQ19GSUZPX0RFUFRIKTsKPiArCQlmb3IgKGkgPSAwOyBp IDwgcmRfbGVuOyBpKyspIHsKPiArCQkJcmRfdmFsID0gcmVhZGwoaTJjLT5yZWdzICsgUkVHX0NG R19SWCk7Cj4gKwkJCWJ1ZltpMmMtPnBvcysrXSA9IHJkX3ZhbCAmIFRYX1JYX0RBVEE7Cj4gKwkJ fQo+ICsJCS8qIFJ4IG11c3QgY2xlYXIgdGhyZXNoIGFmdGVyIHJlYWQgZmlmbyAqLwo+ICsJCWNs ZWFyX2lycV9zdGF0dXMoaTJjLCBBOV9SWF9USFJFU0hfUkVBRCk7Cj4gKwkJYnJlYWs7Cj4gKwlj YXNlIEE5X1NUQVRFX1dSSVRFOgo+ICsJCWFtbF9pMmNfcHJlcGFyZV94ZmVyKGkyYywgQTlfRklG T19GSUxMX0hBTEYpOwo+ICsJCWlmIChpMmMtPnBvcyA9PSBpMmMtPm1zZy0+bGVuKQo+ICsJCQlh bWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19JUlFfRU5BQkxFLCBBOV9UWF9USFJFU0hfV1JJ VEUsIDApOwo+ICsJCS8qIFR4IG11c3QgY2xlYXIgdGhyZXNoIGFmdGVyIHdyaXRlIGZpZm8gKi8K PiArCQljbGVhcl9pcnFfc3RhdHVzKGkyYywgQTlfVFhfVEhSRVNIX1dSSVRFKTsKPiArCQlicmVh azsKPiArCWRlZmF1bHQ6Cj4gKwkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJaWYgKCEoaXJxX3N0YXRl ICYgQTlfVFJBTlNfRE9ORSkgfHwKPiArCSAgICAoaTJjLT5zdGF0ZSA9PSBBOV9TVEFURV9SRUFE ICYmIGkyYy0+cG9zIDwgaTJjLT5tc2ctPmxlbikpIHsKPiArCQlyZXR1cm4gSVJRX0hBTkRMRUQ7 Cj4gKwl9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KQ2FuIG11bHRpLWNodW5rIHJlYWQgdHJhbnNmZXJz IG1pc3MgdGhlIEE5X1BIWV9ET05FIGludGVycnVwdCBhbmQgdGltZSBvdXQgaW4KYW1sX2kyY194 ZmVyX21zZygpPwoKRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2kyYy9hbWxvZ2lj LGE5LWkyYy55YW1sIHNwZWNpZmllcyBhCnJpc2luZy1lZGdlIGludGVycnVwdCAoaW50ZXJydXB0 cyA9IDwwIDE2NCAxPiksIHdoaWNoIHJlcXVpcmVzIGEgMC10by0xCnRyYW5zaXRpb24gb24gdGhl IGludGVycnVwdCBsaW5lIHRvIGxhdGNoIGEgbmV3IHBlbmRpbmcgaW50ZXJydXB0IGluIHRoZSBH SUMuClVubGlrZSBBOV9TVEFURV9XUklURSwgQTlfU1RBVEVfUkVBRCBuZXZlciBkaXNhYmxlcyBB OV9SWF9USFJFU0hfUkVBRCB3aGVuCnRoZSByZW1haW5pbmcgYnl0ZXMgZml0IGluIHRoZSAzMi1i eXRlIEZJRk8sIGFuZCBpcnFfc3RhdGUgaXMgc2FtcGxlZCBvbmx5Cm9uY2UgYmVmb3JlIHJlYWRp bmcgdXAgdG8gMzIgYnl0ZXMgZnJvbSBSRUdfQ0ZHX1JYLgoKT24gYSA2NC1ieXRlIHJlYWQsIHRo ZSAzMm5kIGJ5dGUgb2YgdGhlIHNlY29uZCBjaHVuayBhc3NlcnRzIEE5X1JYX1RIUkVTSF9SRUFE CmFzIHNvb24gYXMgaXQgZW50ZXJzIHRoZSBGSUZPLCBiZWZvcmUgdGhlIGJ1cyBOQUNLIGFuZCBT VE9QIGZpbmlzaDoKCmFtbF9pMmNfaXJxKCkKICBpcnFfc3RhdGUgPSByZWFkbChSRUdfQ0ZHX0lS UV9TVEFURSkgIC8qIEE5X1JYX1RIUkVTSF9SRUFEICovCiAgcmVhZGwoUkVHX0NGR19SWCkgeCAz MgogIC8qIGhhcmR3YXJlIGZpbmlzaGVzIFNUT1AgYW5kIHNldHMgQTlfUEhZX0RPTkUgaW4gUkVH X0NGR19JUlFfU1RBVEUgKi8KICBjbGVhcl9pcnFfc3RhdHVzKEE5X1JYX1RIUkVTSF9SRUFEKQog ICAgLyogQTlfUEhZX0RPTkUgc3RheXMgaGlnaDsgbm8gMC0+MSBlZGdlIG9uIHRoZSBJUlEgbGlu ZSAqLwogIGlmICghKGlycV9zdGF0ZSAmIEE5X1RSQU5TX0RPTkUpIHx8IC4uLikKICAgIHJldHVy biBJUlFfSEFORExFRDsgICAgICAgICAgICAgICAgIDwtLSBuZXZlciBjb21wbGV0ZXMgaTJjLT5k b25lCgpMaWtld2lzZSwgaWYgYm90aCBBOV9SWF9USFJFU0hfUkVBRCBhbmQgQTlfUEhZX0RPTkUg YXJlIGFscmVhZHkgc2V0IGluCmlycV9zdGF0ZSB3aGVuIG1vcmUgdGhhbiAzMiBieXRlcyByZW1h aW4sIGFtbF9pMmNfaXJxKCkgZHJhaW5zIDMyIGJ5dGVzLApjbGVhcnMgb25seSBBOV9SWF9USFJF U0hfUkVBRCwgYW5kIHJldHVybnMgZWFybHkgYmVjYXVzZSBpMmMtPnBvcyA8CmkyYy0+bXNnLT5s ZW4uICBCZWNhdXNlIEE5X1BIWV9ET05FIHJlbWFpbnMgYXNzZXJ0ZWQgd2l0aG91dCBhIG5ldyBy aXNpbmcKZWRnZSBhbmQgZmV3ZXIgdGhhbiAzMiB0YWlsIGJ5dGVzIHJlbWFpbiBpbiB0aGUgRklG Tywgbm8gZnVydGhlciBpbnRlcnJ1cHQKZmlyZXMgYW5kIHdhaXRfZm9yX2NvbXBsZXRpb25fdGlt ZW91dCgpIGhhbmdzIGZvciA1MDAgbXMgYmVmb3JlIHJldHVybmluZwotRVRJTUVET1VULgoKPiAr Cj4gK2NvbXBsZXRlX2lycV9vdXQ6Cj4gKwlpMmMtPnN0YXRlID0gQTlfU1RBVEVfSURMRTsKPiAr CXJlc2V0X2ZpZm9fcG9zKGkyYyk7Cj4gKwlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19J UlFfRU5BQkxFLCBBOV9SWF9USFJFU0hfUkVBRCB8IEE5X1RYX1RIUkVTSF9XUklURSwgMCk7Cj4g Kwljb21wbGV0ZSgmaTJjLT5kb25lKTsKPiAraXJxX3RyYW5zX291dDoKPiArCWNsZWFyX2lycV9z dGF0dXMoaTJjLCBJUlFfQUxMX01BU0spOwo+ICsKPiArCXJldHVybiBJUlFfSEFORExFRDsKPiAr fQo+ICsKPiArc3RhdGljIHZvaWQgYW1sX2kyY19kb19zdGFydChzdHJ1Y3QgYW1sX2kyYyAqaTJj LCBzdHJ1Y3QgaTJjX21zZyAqbXNnKQo+ICt7Cj4gKwl1bnNpZ25lZCBpbnQgcmVnX3ZhbDsKPiAr CXVuc2lnbmVkIGludCB0cmFuc19sZW47Cj4gKwo+ICsJdHJhbnNfbGVuID0gbXNnLT5sZW47Cj4g KwlyZWdfdmFsID0gKHVuc2lnbmVkIGludCkoKChtc2ctPmFkZHIgJiAweDdmKSA8PCBTVEFSVF9T QUREUl9TSElGVCkgfAo+ICsJCQkJKChtc2ctPmZsYWdzICYgSTJDX01fUkQpID8gU1RBUlRfUkVB RCA6IDApIHwKPiArCQkJCSgodHJhbnNfbGVuICYgMHhmZmYpIDw8IFNUQVJUX0xFTl9TSElGVCkg fCBTVEFSVF9TVEFSVCk7Cj4gKwlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19TVEFSVCwK PiArCQkJIFNUQVJUX1NUQVJUIHwgU1RBUlRfU0xBVkVfQUREUiB8IFNUQVJUX1JFQUQgfCBTVEFS VF9MRU4sIHJlZ192YWwpOwo+ICsJY2xlYXJfaXJxX3N0YXR1cyhpMmMsIElSUV9BTExfTUFTSyk7 Cj4gKwkvKiBlbmFibGUgdGhyZXNoIG1vZGUgKi8KPiArCWlmICh0cmFuc19sZW4gPiBBOV9JMkNf RklGT19ERVBUSCkgewo+ICsJCXJlZ192YWwgPSAobXNnLT5mbGFncyAmIEkyQ19NX1JEKSA/IEE5 X1JYX1RIUkVTSF9SRUFEIDogQTlfVFhfVEhSRVNIX1dSSVRFOwo+ICsJCWFtbF9pMmNfc2V0X21h c2soaTJjLCBSRUdfQ0ZHX0lSUV9FTkFCTEUsCj4gKwkJCQkgQTlfUlhfVEhSRVNIX1JFQUQgfCBB OV9UWF9USFJFU0hfV1JJVEUsIHJlZ192YWwpOwo+ICsJfQo+ICt9CgpbU2V2ZXJpdHk6IE1lZGl1 bV0KU2hvdWxkIGNsZWFyX2lycV9zdGF0dXMoKSBhbmQgdGhlIFJFR19DRkdfSVJRX0VOQUJMRSB1 cGRhdGUgaGFwcGVuIGJlZm9yZQpzZXR0aW5nIFNUQVJUX1NUQVJUIGluIFJFR19DRkdfU1RBUlQ/ CgpBOV9FTkFCTEVfSVJRX0JJVCAoQTlfTkNLX0VSUk9SIHwgQTlfUEhZX0RPTkUpIGlzIGFscmVh ZHkgZW5hYmxlZCBpbgpSRUdfQ0ZHX0lSUV9FTkFCTEUgZnJvbSBhbWxfaTJjX3Byb2JlKCkuICBJ ZiBleGVjdXRpb24gaXMgZGVsYXllZCBhZnRlcgp3cml0aW5nIFNUQVJUX1NUQVJUIChmb3IgZXhh bXBsZSB1bmRlciBDT05GSUdfUFJFRU1QVF9SVCBvciBhIGh5cGVydmlzb3IpIGFuZAp0aGUgdHJh bnNmZXIgaW1tZWRpYXRlbHkgTkFDS3MgdGhlIGFkZHJlc3Mgb3IgZmluaXNoZXMsIGNsZWFyX2ly cV9zdGF0dXMoaTJjLApJUlFfQUxMX01BU0spIHdpcGVzIG91dCBBOV9OQ0tfRVJST1Igb3IgQTlf UEhZX0RPTkUgYmVmb3JlIGFtbF9pMmNfaXJxKCkKcmVhZHMgUkVHX0NGR19JUlFfU1RBVEUuICBh bWxfaTJjX2lycSgpIHRoZW4gc2VlcyBpcnFfc3RhdGUgPT0gMCwgbWlzc2VzCkE5X1RSQU5TX0VS Uk9SLCByZWFkcyB1bnBvcHVsYXRlZCBieXRlcyBmcm9tIFJFR19DRkdfUlggb24gYSByZWFkIG1l c3NhZ2UsCmFuZCByZXR1cm5zIGVhcmx5IHdpdGhvdXQgY29tcGxldGluZyBpMmMtPmRvbmUsIGNh dXNpbmcgYW1sX2kyY194ZmVyX21zZygpIHRvCnRpbWUgb3V0IGFmdGVyIDUwMCBtcy4KCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjEx MTctYTktaTJjLXY5LTAtN2IzMDNjODk0ZmVhQGFtbG9naWMuY29tP3BhcnQ9MgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWls aW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=