From: sashiko-bot@kernel.org
To: "Lucas Tanure" <tanure@linux.com>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH v8 3/4] arm64: dts: amlogic: t7: add the ethernet controller
Date: Sun, 22 Nov 2026 21:32:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-228358@kernel.org> (raw)
In-Reply-To: <20261121213102.143130-4-tanure@linux.com>
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] arm64: dts: amlogic: t7: ethmac uses unmatched compatible
amlogic,t7-dwmac
- [High] arm64: dts: amlogic: t7: ethmac pipeline clock is never claimed
by driver
- [Medium] arm64: dts: amlogic: t7: undocumented ethmac compatible and
clocks in binding
--
commit 4e3c40142c3d0de22878c5872271d7ab4185032f
Author: Lucas Tanure <tanure@linux.com>
arm64: dts: amlogic: t7: add the ethernet controller
This commit adds the Devicetree nodes for the Amlogic T7 Ethernet MAC, its
MDIO bus, and the MDIO multiplexer with the internal 100M PHY.
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> index 7bd53ec166071..eb7f46c98b0b4 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> @@ -250,6 +250,31 @@ gic: interrupt-controller@fff01000 {
> interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> };
>
> + ethmac: ethernet@fdc00000 {
> + compatible = "amlogic,t7-dwmac", "snps,dwmac-5.10a";
> + reg = <0x0 0xfdc00000 0x0 0x10000>,
> + <0x0 0xfe024000 0x0 0x8>;
[Severity: High]
Can any platform driver bind to ethmac with this compatible list?
meson8b_dwmac_match[] in drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c
has no entry for amlogic,t7-dwmac, and ethmac does not list a fallback
compatible such as amlogic,meson-g12a-dwmac. No platform driver matches
snps,dwmac-5.10a directly either (it is only checked in
stmmac_probe_config_dt() after a glue driver has already bound), so
ethmac never probes when enabled by a board.
> + interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq";
> + clocks = <&clkc_periphs CLKID_SYS_ETH>,
> + <&scmi_clk CLKID_FCLK_DIV2>,
> + <&mpll CLKID_MPLL2>,
> + <&clkc_periphs CLKID_SYS_AMPIPE_ETH>,
> + <&clkc_periphs CLKID_SYS_ETHPHY>;
> + clock-names = "stmmaceth", "clkin0", "clkin1", "pipeline",
> + "pclk";
[Severity: High]
Does any driver actually claim and enable the "pipeline" clock
(CLKID_SYS_AMPIPE_ETH)?
Neither meson8b_dwmac_probe() (which only requests "timing-adjustment",
"clkin0", and "clkin1") nor stmmac_probe_config_dt() (which only requests
"stmmaceth", "pclk", and "ptp_ref") acquires a clock named "pipeline".
Because t7_sys_ampipe_eth in drivers/clk/meson/t7-peripherals.c is defined
with flags = 0, CLKID_SYS_AMPIPE_ETH remains unclaimed and is gated off by
clk_disable_unused(), breaking Ethernet DMA access to memory.
[Severity: Medium]
Are the new compatible strings and clocks documented in
Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml?
The binding schema does not allow amlogic,t7-dwmac or snps,dwmac-5.10a in
compatible, and its clocks and clock-names properties only allow up to four
entries (stmmaceth, clkin0, clkin1, and timing-adjustment) without
"pipeline" or "pclk", causing dtbs_check validation to fail.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121213102.143130-1-tanure@linux.com?part=3
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-11-22 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 21:30 [PATCH v8 0/4] Add ethernet support for the Amlogic T7 Lucas Tanure
2026-11-21 21:30 ` [PATCH v8 1/4] dt-bindings: net: amlogic,g12a-mdio-mux: add the T7 compatible Lucas Tanure
2026-11-22 14:37 ` Krzysztof Kozlowski
2026-11-21 21:31 ` [PATCH v8 2/4] arm64: dts: amlogic: t7: add the ethernet pinctrl nodes Lucas Tanure
2026-11-21 21:31 ` [PATCH v8 3/4] arm64: dts: amlogic: t7: add the ethernet controller Lucas Tanure
2026-11-22 21:32 ` sashiko-bot [this message]
2026-11-21 21:31 ` [PATCH v8 4/4] arm64: dts: amlogic: t7: khadas-vim4: enable the ethernet port Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-228358@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tanure@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox