From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH update for 4.15 2/3] cpu_opv: selftests: Implement selftests (v4) Date: Wed, 22 Nov 2017 08:20:52 -0700 Message-ID: <00142e09-bcb9-a145-cbe3-27b61213f361@kernel.org> References: <20171121221933.25959-1-mathieu.desnoyers@efficios.com> <20171121221933.25959-2-mathieu.desnoyers@efficios.com> Reply-To: shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171121221933.25959-2-mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org> Content-Language: en-US Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mathieu Desnoyers , Peter Zijlstra , "Paul E . McKenney" , Boqun Feng , Andy Lutomirski , Dave Watson Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Turner , Andrew Morton , Russell King , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andrew Hunter , Andi Kleen , Chris Lameter , Ben Maurer , Steven Rostedt , Josh Triplett , Linus Torvalds , Catalin Marinas , Will Deacon , Michael Kerrisk , linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shuah Khan , Shuah Khan List-Id: linux-api@vger.kernel.org On 11/21/2017 03:19 PM, Mathieu Desnoyers wrote: > Implement cpu_opv selftests. It needs to express dependencies on > header files and .so, which require to override the selftests > lib.mk targets. Use OVERRIDE_TARGETS define for this. > > Signed-off-by: Mathieu Desnoyers > CC: Russell King > CC: Catalin Marinas > CC: Will Deacon > CC: Thomas Gleixner > CC: Paul Turner > CC: Andrew Hunter > CC: Peter Zijlstra > CC: Andy Lutomirski > CC: Andi Kleen > CC: Dave Watson > CC: Chris Lameter > CC: Ingo Molnar > CC: "H. Peter Anvin" > CC: Ben Maurer > CC: Steven Rostedt > CC: "Paul E. McKenney" > CC: Josh Triplett > CC: Linus Torvalds > CC: Andrew Morton > CC: Boqun Feng > CC: Shuah Khan > CC: linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > CC: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > Changes since v1: > > - Expose similar library API as rseq: Expose library API closely > matching the rseq APIs, following removal of the event counter from > the rseq kernel API. > - Update makefile to fix make run_tests dependency on "all". > - Introduce a OVERRIDE_TARGETS. > > Changes since v2: > > - Test page faults. > > Changes since v3: > > - Move lib.mk OVERRIDE_TARGETS change to its own patch. > - Printout TAP output. > --- > MAINTAINERS | 1 + > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/cpu-opv/.gitignore | 1 + > tools/testing/selftests/cpu-opv/Makefile | 17 + > .../testing/selftests/cpu-opv/basic_cpu_opv_test.c | 1167 ++++++++++++++++++++ > tools/testing/selftests/cpu-opv/cpu-op.c | 348 ++++++ > tools/testing/selftests/cpu-opv/cpu-op.h | 68 ++ > 7 files changed, 1603 insertions(+) > create mode 100644 tools/testing/selftests/cpu-opv/.gitignore > create mode 100644 tools/testing/selftests/cpu-opv/Makefile > create mode 100644 tools/testing/selftests/cpu-opv/basic_cpu_opv_test.c > create mode 100644 tools/testing/selftests/cpu-opv/cpu-op.c > create mode 100644 tools/testing/selftests/cpu-opv/cpu-op.h > Looks good. Acked-by: Shuah Khan thanks, -- Shuah