From: Devin Bayer <dev@doubly.so>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: corentin.chary@gmail.com, luke@ljones.dev,
Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: asus-wmi: support the disable camera LED on F10 of Zenbook 2023
Date: Mon, 24 Jun 2024 10:34:00 +0200 [thread overview]
Message-ID: <0c189a70-f832-44a0-9ea2-44231ee4624c@doubly.so> (raw)
In-Reply-To: <a80c09f8-e932-722f-8c68-19a254d94633@linux.intel.com>
On 24/06/2024 10.17, Ilpo Järvinen wrote:
> On Fri, 21 Jun 2024, Devin Bayer wrote:
>
>> Adds a sysfs entry for the LED on F10 above the crossed out camera
>> icon on 2023 Zenbooks.
>
> Please wrap paragraphs at 72 characters.
OK.
>> --- a/include/linux/platform_data/x86/asus-wmi.h
>> +++ b/include/linux/platform_data/x86/asus-wmi.h
>> @@ -50,6 +50,8 @@
>> #define ASUS_WMI_DEVID_LED5 0x00020015
>> #define ASUS_WMI_DEVID_LED6 0x00020016
>> #define ASUS_WMI_DEVID_MICMUTE_LED 0x00040017
>> +#define ASUS_WMI_DEVID_CAMERA_LED_NEG 0x00060078
>
> This is not used?
No, it does the same as CAMERA_LED but the values are opposite. I
thought it would just be useful as documentation of the WMI functions.
Should I remove it?
>> +#define ASUS_WMI_DEVID_CAMERA_LED 0x00060079
>
> Why is ASUS_WMI_DEVID_CAMERA_LED added here and into the .c file?
That was a mistake, I used it for testing.
~ Dev
prev parent reply other threads:[~2024-06-24 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 8:57 [PATCH v2] platform/x86: asus-wmi: support the disable camera LED on F10 of Zenbook 2023 Devin Bayer
2024-06-21 9:27 ` Luke Jones
2024-06-23 16:57 ` Ilpo Järvinen
2024-06-23 23:55 ` Luke Jones
2024-06-24 8:17 ` Ilpo Järvinen
2024-06-24 8:34 ` Devin Bayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c189a70-f832-44a0-9ea2-44231ee4624c@doubly.so \
--to=dev@doubly.so \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).