From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Borisov Subject: Re: [RFC PATCH v3 06/12] btrfs: remove dead snapshot-aware defrag code Date: Tue, 26 Nov 2019 17:13:42 +0200 Message-ID: <1165c066-09ae-df4b-856d-df27c1c9aca3@suse.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-btrfs-owner@vger.kernel.org To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com List-Id: linux-api@vger.kernel.org On 20.11.19 г. 20:24 ч., Omar Sandoval wrote: > From: Omar Sandoval > > Snapshot-aware defrag has been disabled since commit 8101c8dbf624 > ("Btrfs: disable snapshot aware defrag for now") almost 6 years ago. > Let's remove the dead code. If someone is up to the task of bringing it > back, they can dig it up from git. > > This is logically a revert of commit 38c227d87c49 ("Btrfs: > snapshot-aware defrag") except that now we have to clear the > EXTENT_DEFRAG bit to avoid need_force_cow() returning true forever. > > Signed-off-by: Omar Sandoval Reviewed-by: Nikolay Borisov