linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Greg KH <greg@kroah.com>, Alexey Dobriyan <adobriyan@gmail.com>,
	Remi Colinet <remi.colinet@gmail.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org,
	linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RESEND][PATCH] Add /proc/mempool to display mempool usage
Date: Mon, 01 Dec 2008 13:13:31 -0600	[thread overview]
Message-ID: <1228158811.3196.88.camel@calx> (raw)
In-Reply-To: <20081201101245.0a2f3123.randy.dunlap@oracle.com>

On Mon, 2008-12-01 at 10:12 -0800, Randy Dunlap wrote:
> On Sat, 29 Nov 2008 15:49:07 -0800 Greg KH wrote:
> 
> > On Sun, Nov 30, 2008 at 12:42:07AM +0300, Alexey Dobriyan wrote:
> > > On Sat, Nov 29, 2008 at 06:44:49PM +0100, Remi Colinet wrote:
> > > > This patch add a new /proc/mempool file in order to display mempool usage.
> > > > 
> > > > The feature can be disabled with CONFIG_PROC_MEMPOOL=N during kernel
> > > > configuration.
> > > 
> > > We're NOT adding config option per proc file.
> > > 
> > > And can we, please, freeze /proc for not per-process stuff and open debugfs
> > > for random stuff, please?
> > 
> > debugfs has been open for random stuff since the day it was added to the
> > tree :)
> > 
> > Feel free to put this kind of thing there instead of proc.
> 
> Do distros ship with debugfs enabled?
> The problem with using debugfs is that it is very optional IMO.

The problem with debugfs is that it claims to not be an ABI but it is
lying. Distributions ship tools that depend on portions of debugfs. And
they also ship debugfs in their kernel. So it is effectively the same
as /proc, except with the 1.0-era everything-goes attitude rather than
the 2.6-era we-should-really-think-about-this one.

Pushing stuff from procfs to debugfs is thus just setting us up for pain
down the road. Don't do it. In five years, we'll discover we can't turn
debugfs off or even clean it up because too much relies on it.

If you think that debugfs is NOT an ABI, then I'm sure you'll be happy
to ack my patch entitled 'gratuitously break usbmon to remind folks that
debugfs is not an ABI'.

-- 
Mathematics is the supreme nostalgia of our time.


  reply	other threads:[~2008-12-01 19:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1227980689.6354.24.camel@localhost.localdomain>
     [not found] ` <1227980689.6354.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-11-29 21:42   ` [RESEND][PATCH] Add /proc/mempool to display mempool usage Alexey Dobriyan
     [not found]     ` <20081129214207.GA6747-2ev+ksY9ol182hYKe6nXyg@public.gmane.org>
2008-11-29 23:49       ` Greg KH
2008-12-01 18:12         ` Randy Dunlap
2008-12-01 19:13           ` Matt Mackall [this message]
2008-12-01 20:02             ` Andrew Morton
2008-12-01 20:07               ` Pekka Enberg
2008-12-01 20:12                 ` Linus Torvalds
     [not found]                   ` <alpine.LFD.2.00.0812011210030.3256-nfNrOhbfy2R17+2ddN/4kux8cNe9sq/dYPYVAmT7z5s@public.gmane.org>
2008-12-01 20:23                     ` Linus Torvalds
2008-12-01 22:02                     ` Pekka Enberg
     [not found]                       ` <84144f020812011402v3cb3ab24pf5cb6310f2d00c5b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-01 22:20                         ` Matt Mackall
2008-12-02  2:54                         ` Linus Torvalds
     [not found]                           ` <alpine.LFD.2.00.0812011843340.3256-nfNrOhbfy2R17+2ddN/4kux8cNe9sq/dYPYVAmT7z5s@public.gmane.org>
2008-12-04 16:02                             ` Michael Kerrisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228158811.3196.88.camel@calx \
    --to=mpm@selenic.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=remi.colinet@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).