From mboxrd@z Thu Jan 1 00:00:00 1970 From: john stultz Subject: Re: [PATCH V8 02/13] ntp: add ADJ_SETOFFSET mode bit Date: Mon, 10 Jan 2011 13:11:32 -0800 Message-ID: <1294693892.3068.17.camel@work-vm> References: <20110108175028.GA22308@riccoc20.at.omicron.at> <20110110071759.GA4864@riccoc20.at.omicron.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Kuwahara,T." <6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com> Cc: Richard Cochran , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, Alan Cox , Arnd Bergmann , Christoph Lameter , David Miller , Krzysztof Halasa , Peter Zijlstra , Rodolfo Giometti , Thomas Gleixner List-Id: linux-api@vger.kernel.org On Tue, 2011-01-11 at 05:47 +0900, Kuwahara,T. wrote: > On Mon, Jan 10, 2011 at 4:17 PM, Richard Cochran > wrote: > > the PTP Hardware Clocks for which this whole patch > > set was created in the first place will keep their time as TAI. > > Are you sure of that? I don't have the standard handy (it's non-free, > right?) but it seems that the Annex B states differently. But that's > not the point anyway. My concern is that your patch not only adds the > useless (and broken) feature to the existing syscall but also makes a > permanent change to the public interface for your own use. That's > what I'm against. So if you stop touching the struct timex, I won't > complain anymore. You still haven't explained *why* you're so protective of the timex and adjtimex interfaces. While I do want to keep compatible the functionality where possible, I don't see why Linux should be limited by what other OSes do. Injecting an offset to the system time seems like a reasonable thing for adjtimex to do (rather then adding a new syscall). Further utilizing a new mode bit for this functionality seems reasonable and cleaner then your suggestions for utilizing existing mode bits in combined with other magic bits. If there is a compelling reason why not to do this, do please let us know! We might just agree with you after hearing it. :) thanks -john