From: John Stultz <john.stultz@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
David Miller <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
Peter Zijlstra <peterz@infradead.org>,
Rodolfo Giometti <giometti@linux.it>,
Thomas Gleixner <tglx@linutronix.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Mike Frysinger <vapier@gentoo.org>,
Paul Mackerras <paulus@samba.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH V12 3/4] ptp: Added a clock driver for the IXP46x.
Date: Wed, 23 Mar 2011 14:43:00 -0700 [thread overview]
Message-ID: <1300916580.848.51.camel@work-vm> (raw)
In-Reply-To: <cd6ddff0dcca60ac88b35660505d7bf54ad32405.1298878618.git.richard.cochran@omicron.at>
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote:
> This patch adds a driver for the hardware time stamping unit found on the
> IXP465. The basic clock operations and an external trigger are implemented.
>
> Signed-off-by: Richard Cochran <richard.cochran@omicron.at>
> Acked-by: John Stultz <johnstul@us.ibm.com>
My ack is still fine, but found a few more nits to consider on another
pass...
> +static int match(struct sk_buff *skb, u16 uid_hi, u32 uid_lo, u16 seq)
[snip]
> +static void do_rx_timestamp(struct port *port, struct sk_buff *skb)
[snip]
> +static u64 sys_time_read(struct ixp46x_ts_regs *regs)
[snip]
> +static void sys_time_write(struct ixp46x_ts_regs *regs, u64 ns)
I know these are static, but these function names are sort of generic
names, and make grep/cscoping for similar sounding functions a little
noisy.
Maybe add a ipx_ prefix just to be more obvious?
thanks
-john
next prev parent reply other threads:[~2011-03-23 21:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 7:57 [PATCH V12 0/4] ptp: IEEE 1588 hardware clock support Richard Cochran
2011-02-28 7:57 ` [PATCH V12 1/4] ptp: Added a brand new class driver for ptp clocks Richard Cochran
2011-03-23 21:19 ` John Stultz
2011-03-26 13:12 ` Richard Cochran
2011-02-28 7:57 ` [PATCH V12 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx Richard Cochran
[not found] ` <aa97e94c82ebd8953d83b53f64cbfef66c81b7be.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-03-23 21:30 ` John Stultz
2011-03-26 13:23 ` Richard Cochran
[not found] ` <cover.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-02-28 7:58 ` [PATCH V12 3/4] ptp: Added a clock driver for the IXP46x Richard Cochran
[not found] ` <cd6ddff0dcca60ac88b35660505d7bf54ad32405.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-03-13 23:40 ` Krzysztof Halasa
2011-03-23 21:43 ` John Stultz [this message]
2011-02-28 7:58 ` [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER Richard Cochran
[not found] ` <f8af215ebe32a8c0f4b3a82b8ee7e8008b4feb1e.1298878618.git.richard.cochran-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2011-03-23 21:46 ` John Stultz
2011-03-26 13:40 ` Richard Cochran
2011-03-03 20:13 ` [PATCH V12 0/4] ptp: IEEE 1588 hardware clock support David Miller
2011-03-16 14:26 ` Richard Cochran
2011-03-19 10:14 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300916580.848.51.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=giometti@linux.it \
--cc=khc@pm.waw.pl \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).