From: Mugunthan V N <mugunthanvnm@ti.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>
Subject: [net-next PATCH 2/3] drivers: net: cpsw: remove redundancy check
Date: Tue, 8 Jul 2014 14:27:40 +0530 [thread overview]
Message-ID: <1404809861-7040-3-git-send-email-mugunthanvnm@ti.com> (raw)
In-Reply-To: <1404809861-7040-1-git-send-email-mugunthanvnm@ti.com>
In cpsw_set_coalesce, rx_coalesce_usecs is already checked before
calling this function, so removing redundancy check.
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
drivers/net/ethernet/ti/cpsw.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index b988d16..a6117e6 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -884,9 +884,6 @@ static int cpsw_set_coalesce(struct net_device *ndev,
u32 addnl_dvdr = 1;
u32 coal_intvl = 0;
- if (!coal->rx_coalesce_usecs)
- return -EINVAL;
-
coal_intvl = coal->rx_coalesce_usecs;
int_ctrl = readl(&priv->wr_regs->int_control);
--
2.0.0.390.gcb682f8
next prev parent reply other threads:[~2014-07-08 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 8:57 [net-next PATCH 0/3] Broadcast/Multicast rate limit via Ethtool Coalesce Mugunthan V N
2014-07-08 8:57 ` [net-next PATCH 1/3] net: ethtool: Add Multicast and broadcast rate limit coalescing feature Mugunthan V N
2014-07-08 8:57 ` Mugunthan V N [this message]
2014-07-08 8:57 ` [net-next PATCH 3/3] drivers: net: cpsw: Add support for multicast/boradcast rate limit Mugunthan V N
[not found] ` <1404809861-7040-4-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org>
2014-07-08 9:18 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404809861-7040-3-git-send-email-mugunthanvnm@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox