From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org,
pbonzini@redhat.com, netdev@vger.kernel.org,
linux-api@vger.kernel.org
Subject: [PATCH v3 34/41] tun: add VNET_LE flag
Date: Mon, 24 Nov 2014 13:55:03 +0200 [thread overview]
Message-ID: <1416829787-14252-35-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1416829787-14252-1-git-send-email-mst@redhat.com>
virtio 1.0 modified virtio net header format,
making all fields little endian.
Users can tweak header format before submitting it to tun,
but this means more data copies where none were necessary.
And if the iovec is in RO memory, this means we might
need to split iovec also means we might in theory overflow
iovec max size.
This patch adds a simpler way for applications to handle this,
using new "little endian" flag in tun.
As a result, tun simply byte-swaps header fields as appropriate.
This is a NOP on LE architectures.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/uapi/linux/if_tun.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/if_tun.h b/include/uapi/linux/if_tun.h
index 277a260..18b2403 100644
--- a/include/uapi/linux/if_tun.h
+++ b/include/uapi/linux/if_tun.h
@@ -57,6 +57,7 @@
#define IFF_ONE_QUEUE 0x2000
#define IFF_VNET_HDR 0x4000
#define IFF_TUN_EXCL 0x8000
+#define IFF_VNET_LE 0x10000
#define IFF_MULTI_QUEUE 0x0100
#define IFF_ATTACH_QUEUE 0x0200
#define IFF_DETACH_QUEUE 0x0400
--
MST
next prev parent reply other threads:[~2014-11-24 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416829787-14252-1-git-send-email-mst@redhat.com>
2014-11-24 11:52 ` [PATCH v3 03/41] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 04/41] virtio: memory access APIs Michael S. Tsirkin
2014-11-24 12:03 ` Geert Uytterhoeven
2014-11-24 12:15 ` Michael S. Tsirkin
[not found] ` <20141124121503.GB14353-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-24 12:58 ` Geert Uytterhoeven
2014-11-24 18:49 ` Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 08/41] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 11/41] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 12/41] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 32/41] tun: move internal flag defines out of uapi Michael S. Tsirkin
2014-11-24 11:55 ` Michael S. Tsirkin [this message]
2014-11-24 11:55 ` [PATCH v3 39/41] virtio_scsi: export to userspace Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416829787-14252-35-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rusty@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).