From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>
Cc: amirv@mellanox.com, ddecotig@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, saeedm@mellanox.com,
decot@googlers.com, jasowang@redhat.com, mst@redhat.com,
herbert@gondor.apana.org.au, viro@zeniv.linux.org.uk,
yamato@redhat.com, xii@google.com, nhorman@tuxdriver.com,
xiyou.wangcong@gmail.com, fbl@redhat.com, teg@jklm.no,
jiri@resnulli.us, vyasevic@redhat.com, ebiederm@xmission.com,
VenkatKumar.Duvvuru@Emulex.Com, _govind@gmx.com
Subject: Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits
Date: Tue, 06 Jan 2015 23:08:39 +0000 [thread overview]
Message-ID: <1420585719.2327.3.camel@decadent.org.uk> (raw)
In-Reply-To: <20150106.172918.70204012105519766.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Tue, 2015-01-06 at 17:29 -0500, David Miller wrote:
> From: Amir Vadai <amirv@mellanox.com>
> Date: Tue, 6 Jan 2015 15:56:33 +0200
>
> > Mellanox is about to release next month a driver for a new NIC, with 3
> > new speeds * few link modes for each + new link modes for 10G.
> > It seems that we will need to consume almost all the new bits.
>
> This tells me that the approach to this problem needs to be rethought.
>
> Maybe we just need to bite the bullet and make a new ETHTOOL_GSET_2
> and ETHTOOL_SSET_2 or whatever you want to name them.
>
> Then we can define a completely new structure, with 64-bit bitmaps
> for link modes or whatever. The ethtool_op callbacks work using
> this structure, and only the net/core/ethtool.c code knows about
> the older structure and translates to/from for ETHTOOL_{GSET,SSET}.
Agreed.
Ben.
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2015-01-06 23:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 2:54 [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 2/8] net: ethtool: extend link mode support " David Decotigny
[not found] ` <1420512850-24699-1-git-send-email-ddecotig-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-06 2:54 ` [PATCH net-next v2 1/8] net: ethtool: internal compatibility flags to reject non-zero reserved fields David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 3/8] net: phy: extend link mode support to 48 bits David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 4/8] net: mii: " David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 5/8] net: mdio: " David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 6/8] net: veth: " David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 7/8] net: tun: " David Decotigny
2015-01-06 2:54 ` [PATCH net-next v2 8/8] net: mlx4_en: " David Decotigny
2015-01-06 13:56 ` [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps " Amir Vadai
2015-01-06 17:36 ` David Decotigny
[not found] ` <CAG88wWYPDpwkWkL+Pj2VKrX5WVp=at8v0=gcFAVAA8nntv+-nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-08 8:40 ` Amir Vadai
2015-01-11 22:49 ` David Decotigny
[not found] ` <54ABE991.3040107-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-01-06 22:29 ` David Miller
2015-01-06 23:08 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420585719.2327.3.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=VenkatKumar.Duvvuru@Emulex.Com \
--cc=_govind@gmx.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=ddecotig@gmail.com \
--cc=decot@googlers.com \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=fbl@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=saeedm@mellanox.com \
--cc=teg@jklm.no \
--cc=viro@zeniv.linux.org.uk \
--cc=vyasevic@redhat.com \
--cc=xii@google.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).