[GIT PULL] Kselftest updates for 3.20-rc1

[GIT PULL] Kselftest updates for 3.20-rc1

[Shuah Khan]

Hi Linus,

Please pull the following Kselftest updates for 3.20-rc1

thanks,
-- Shuah

The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

  Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
tags/linux-kselftest-3.20-rc1

for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:

  selftests/exec: Check if the syscall exists and bail if not
(2015-02-04 10:17:35 -0700)

----------------------------------------------------------------
Kselftest updates for 3.20-rc1

This update adds:
- Kselftest install target feature
- Fix for selftests/exec test

----------------------------------------------------------------
Michael Ellerman (1):
      selftests/exec: Check if the syscall exists and bail if not

Shuah Khan (20):
      selftests/breakpoints: add install target to enable test install
      selftests/cpu-hotplug: add install target to enable test install
      selftests/efivarfs: add install target to enable test install
      selftests/firmware: add install target to enable test install
      selftests/ftrace: add install target to enable test install
      selftests/ipc: add install target to enable test install
      selftests/kcmp: add install target to enable test install
      selftests/memfd: add install target to enable test install
      selftests/memory-hotplug: add install target to enable test install
      selftests/mount: add install target to enable test install
      selftests/mqueue: add install target to enable test install
      selftests/net: add install target to enable test install
      selftests/ptrace: add install target to enable test install
      selftests/size: add install target to enable test install
      selftests/sysctl: add install target to enable test install
      selftests/timers: add install target to enable test install
      selftests/user: add install target to enable test install
      selftests/vm: add install target to enable test install
      selftests: add install target to enable test install
      kbuild: add a new kselftest_install make target to install selftests

 Makefile                                           | 14 +++++-
 tools/testing/selftests/Makefile                   | 54
+++++++++++++++++++++-
 tools/testing/selftests/breakpoints/Makefile       | 19 +++++++-
 tools/testing/selftests/cpu-hotplug/Makefile       | 14 +++++-
 .../{on-off-test.sh => cpu-on-off-test.sh}         |  0
 tools/testing/selftests/efivarfs/Makefile          | 16 ++++++-
 tools/testing/selftests/exec/execveat.c            | 10 +++-
 tools/testing/selftests/firmware/Makefile          | 43 ++++++++++-------
 tools/testing/selftests/ftrace/Makefile            | 13 +++++-
 tools/testing/selftests/ipc/Makefile               | 19 +++++++-
 tools/testing/selftests/kcmp/Makefile              | 13 +++++-
 tools/testing/selftests/memfd/Makefile             | 17 +++++--
 tools/testing/selftests/memory-hotplug/Makefile    | 14 +++++-
 .../{on-off-test.sh => mem-on-off-test.sh}         |  0
 tools/testing/selftests/mount/Makefile             | 12 ++++-
 tools/testing/selftests/mqueue/Makefile            | 18 ++++++--
 tools/testing/selftests/net/Makefile               | 20 ++++++--
 tools/testing/selftests/ptrace/Makefile            | 16 +++++--
 tools/testing/selftests/size/Makefile              | 12 ++++-
 tools/testing/selftests/sysctl/Makefile            | 17 ++++++-
 tools/testing/selftests/timers/Makefile            | 12 ++++-
 tools/testing/selftests/user/Makefile              | 12 ++++-
 tools/testing/selftests/vm/Makefile                | 11 ++++-
 23 files changed, 326 insertions(+), 50 deletions(-)
 rename tools/testing/selftests/cpu-hotplug/{on-off-test.sh =>
cpu-on-off-test.sh} (100%)
 rename tools/testing/selftests/memory-hotplug/{on-off-test.sh =>
mem-on-off-test.sh} (100%)

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Michael Ellerman]

On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
> Hi Linus,
> 
> Please pull the following Kselftest updates for 3.20-rc1
> 
> thanks,
> -- Shuah
> 
> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
> 
>   Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux-kselftest-3.20-rc1
> 
> for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:
> 
>   selftests/exec: Check if the syscall exists and bail if not
> (2015-02-04 10:17:35 -0700)
> 
> ----------------------------------------------------------------
> Kselftest updates for 3.20-rc1
> 
> This update adds:
> - Kselftest install target feature
> - Fix for selftests/exec test
> 
> ----------------------------------------------------------------
> Michael Ellerman (1):
>       selftests/exec: Check if the syscall exists and bail if not
> 
> Shuah Khan (20):
>       selftests/breakpoints: add install target to enable test install
>       selftests/cpu-hotplug: add install target to enable test install
>       selftests/efivarfs: add install target to enable test install
>       selftests/firmware: add install target to enable test install
>       selftests/ftrace: add install target to enable test install
>       selftests/ipc: add install target to enable test install
>       selftests/kcmp: add install target to enable test install
>       selftests/memfd: add install target to enable test install
>       selftests/memory-hotplug: add install target to enable test install
>       selftests/mount: add install target to enable test install
>       selftests/mqueue: add install target to enable test install
>       selftests/net: add install target to enable test install
>       selftests/ptrace: add install target to enable test install
>       selftests/size: add install target to enable test install
>       selftests/sysctl: add install target to enable test install
>       selftests/timers: add install target to enable test install
>       selftests/user: add install target to enable test install
>       selftests/vm: add install target to enable test install
>       selftests: add install target to enable test install
>       kbuild: add a new kselftest_install make target to install selftests


I don't understand why you insist on merging this series with the logic copied
18 times.

I'm happy to tweak my series that uses an include file, but I don't see the
point of merging this series first when almost every line will be removed when
my series goes in.

  https://lkml.org/lkml/2015/1/9/45

cheers

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Shuah Khan]

On 02/09/2015 05:30 PM, Michael Ellerman wrote:
> On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
>> Hi Linus,
>>
>> Please pull the following Kselftest updates for 3.20-rc1
>>
>> thanks,
>> -- Shuah
>>
>> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
>>
>>   Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
>> tags/linux-kselftest-3.20-rc1
>>
>> for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:
>>
>>   selftests/exec: Check if the syscall exists and bail if not
>> (2015-02-04 10:17:35 -0700)
>>
>> ----------------------------------------------------------------
>> Kselftest updates for 3.20-rc1
>>
>> This update adds:
>> - Kselftest install target feature
>> - Fix for selftests/exec test
>>
>> ----------------------------------------------------------------
>> Michael Ellerman (1):
>>       selftests/exec: Check if the syscall exists and bail if not
>>
>> Shuah Khan (20):
>>       selftests/breakpoints: add install target to enable test install
>>       selftests/cpu-hotplug: add install target to enable test install
>>       selftests/efivarfs: add install target to enable test install
>>       selftests/firmware: add install target to enable test install
>>       selftests/ftrace: add install target to enable test install
>>       selftests/ipc: add install target to enable test install
>>       selftests/kcmp: add install target to enable test install
>>       selftests/memfd: add install target to enable test install
>>       selftests/memory-hotplug: add install target to enable test install
>>       selftests/mount: add install target to enable test install
>>       selftests/mqueue: add install target to enable test install
>>       selftests/net: add install target to enable test install
>>       selftests/ptrace: add install target to enable test install
>>       selftests/size: add install target to enable test install
>>       selftests/sysctl: add install target to enable test install
>>       selftests/timers: add install target to enable test install
>>       selftests/user: add install target to enable test install
>>       selftests/vm: add install target to enable test install
>>       selftests: add install target to enable test install
>>       kbuild: add a new kselftest_install make target to install selftests
> 
> 
> I don't understand why you insist on merging this series with the logic copied
> 18 times.
> 
> I'm happy to tweak my series that uses an include file, but I don't see the
> point of merging this series first when almost every line will be removed when
> my series goes in.

Please work on the suggestions I made and rework the patches
and resend. As I mentioned earlier, I want to enable this work
and them make improvements.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Michael Ellerman]

On Mon, 2015-02-09 at 17:36 -0700, Shuah Khan wrote:
> On 02/09/2015 05:30 PM, Michael Ellerman wrote:
> > On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
> >> Hi Linus,
> >>
> >> Please pull the following Kselftest updates for 3.20-rc1
> >>
> >> thanks,
> >> -- Shuah
> >>
> >> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
> >>
> >>   Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> >> tags/linux-kselftest-3.20-rc1
> >>
> >> for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:
> >>
> >>   selftests/exec: Check if the syscall exists and bail if not
> >> (2015-02-04 10:17:35 -0700)
> >>
> >> ----------------------------------------------------------------
> >> Kselftest updates for 3.20-rc1
> >>
> >> This update adds:
> >> - Kselftest install target feature
> >> - Fix for selftests/exec test
> >>
> >> ----------------------------------------------------------------
> >> Michael Ellerman (1):
> >>       selftests/exec: Check if the syscall exists and bail if not
> >>
> >> Shuah Khan (20):
> >>       selftests/breakpoints: add install target to enable test install
> >>       selftests/cpu-hotplug: add install target to enable test install
> >>       selftests/efivarfs: add install target to enable test install
> >>       selftests/firmware: add install target to enable test install
> >>       selftests/ftrace: add install target to enable test install
> >>       selftests/ipc: add install target to enable test install
> >>       selftests/kcmp: add install target to enable test install
> >>       selftests/memfd: add install target to enable test install
> >>       selftests/memory-hotplug: add install target to enable test install
> >>       selftests/mount: add install target to enable test install
> >>       selftests/mqueue: add install target to enable test install
> >>       selftests/net: add install target to enable test install
> >>       selftests/ptrace: add install target to enable test install
> >>       selftests/size: add install target to enable test install
> >>       selftests/sysctl: add install target to enable test install
> >>       selftests/timers: add install target to enable test install
> >>       selftests/user: add install target to enable test install
> >>       selftests/vm: add install target to enable test install
> >>       selftests: add install target to enable test install
> >>       kbuild: add a new kselftest_install make target to install selftests
> > 
> > 
> > I don't understand why you insist on merging this series with the logic copied
> > 18 times.
> > 
> > I'm happy to tweak my series that uses an include file, but I don't see the
> > point of merging this series first when almost every line will be removed when
> > my series goes in.
> 
> Please work on the suggestions I made and rework the patches
> and resend. As I mentioned earlier, I want to enable this work
> and them make improvements.

Yes I would like install to work to. I'd also like it to work for the powerpc
tests you ignored. But I don't want it to involve copying the same logic into
every Makefile in the tree.

My series was sent over a month ago, with plenty of time for you to merge it
instead of this cut-and-paste solution.

cheers

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Shuah Khan]

On 02/09/2015 05:43 PM, Michael Ellerman wrote:
> On Mon, 2015-02-09 at 17:36 -0700, Shuah Khan wrote:
>> On 02/09/2015 05:30 PM, Michael Ellerman wrote:
>>> On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
>>>> Hi Linus,
>>>>
>>>> Please pull the following Kselftest updates for 3.20-rc1
>>>>
>>>> thanks,
>>>> -- Shuah
>>>>
>>>> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
>>>>
>>>>   Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
>>>> tags/linux-kselftest-3.20-rc1
>>>>
>>>> for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:
>>>>
>>>>   selftests/exec: Check if the syscall exists and bail if not
>>>> (2015-02-04 10:17:35 -0700)
>>>>
>>>> ----------------------------------------------------------------
>>>> Kselftest updates for 3.20-rc1
>>>>
>>>> This update adds:
>>>> - Kselftest install target feature
>>>> - Fix for selftests/exec test
>>>>
>>>> ----------------------------------------------------------------
>>>> Michael Ellerman (1):
>>>>       selftests/exec: Check if the syscall exists and bail if not
>>>>
>>>> Shuah Khan (20):
>>>>       selftests/breakpoints: add install target to enable test install
>>>>       selftests/cpu-hotplug: add install target to enable test install
>>>>       selftests/efivarfs: add install target to enable test install
>>>>       selftests/firmware: add install target to enable test install
>>>>       selftests/ftrace: add install target to enable test install
>>>>       selftests/ipc: add install target to enable test install
>>>>       selftests/kcmp: add install target to enable test install
>>>>       selftests/memfd: add install target to enable test install
>>>>       selftests/memory-hotplug: add install target to enable test install
>>>>       selftests/mount: add install target to enable test install
>>>>       selftests/mqueue: add install target to enable test install
>>>>       selftests/net: add install target to enable test install
>>>>       selftests/ptrace: add install target to enable test install
>>>>       selftests/size: add install target to enable test install
>>>>       selftests/sysctl: add install target to enable test install
>>>>       selftests/timers: add install target to enable test install
>>>>       selftests/user: add install target to enable test install
>>>>       selftests/vm: add install target to enable test install
>>>>       selftests: add install target to enable test install
>>>>       kbuild: add a new kselftest_install make target to install selftests
>>>
>>>
>>> I don't understand why you insist on merging this series with the logic copied
>>> 18 times.
>>>
>>> I'm happy to tweak my series that uses an include file, but I don't see the
>>> point of merging this series first when almost every line will be removed when
>>> my series goes in.
>>
>> Please work on the suggestions I made and rework the patches
>> and resend. As I mentioned earlier, I want to enable this work
>> and them make improvements.
> 
> Yes I would like install to work to. I'd also like it to work for the powerpc
> tests you ignored. But I don't want it to involve copying the same logic into
> every Makefile in the tree.

Michael,

powerpc tests aren't ignored. They are in the list to do as
the next step.

> 
> My series was sent over a month ago, with plenty of time for you to merge it
> instead of this cut-and-paste solution.

I asked you to re-work the patches based on my suggestions
and resend. I didn't see any patches from you that addressed
the comments. I can't merge the patches you sent without
addressing the comments.

I want to get this feature implemented in this series as the
first step and then make improvements that are isolated to the
selftests makefile hierarchy. This series I am requesting to be
pulled in has been in progress for a while now and the series is
v4.

Please plan upon re-working resending the patches for the next
release.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Michael Ellerman]

On Mon, 2015-02-09 at 18:02 -0700, Shuah Khan wrote:
> On 02/09/2015 05:43 PM, Michael Ellerman wrote:
> > On Mon, 2015-02-09 at 17:36 -0700, Shuah Khan wrote:
> >> On 02/09/2015 05:30 PM, Michael Ellerman wrote:
> >>> On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
> >>>> Hi Linus,
> >>>>
> >>>> Please pull the following Kselftest updates for 3.20-rc1
> >>>>
> >>>> thanks,
> >>>> -- Shuah
> >>>>
> >>>> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
> >>>>
> >>>>   Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
> >>>>
> >>>> are available in the git repository at:
> >>>>
> >>>>   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> >>>> tags/linux-kselftest-3.20-rc1
> >>>>
> >>>> for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:
> >>>>
> >>>>   selftests/exec: Check if the syscall exists and bail if not
> >>>> (2015-02-04 10:17:35 -0700)
> >>>>
> >>>> ----------------------------------------------------------------
> >>>> Kselftest updates for 3.20-rc1
> >>>>
> >>>> This update adds:
> >>>> - Kselftest install target feature
> >>>> - Fix for selftests/exec test
> >>>>
> >>>> ----------------------------------------------------------------
> >>>> Michael Ellerman (1):
> >>>>       selftests/exec: Check if the syscall exists and bail if not
> >>>>
> >>>> Shuah Khan (20):
> >>>>       selftests/breakpoints: add install target to enable test install
> >>>>       selftests/cpu-hotplug: add install target to enable test install
> >>>>       selftests/efivarfs: add install target to enable test install
> >>>>       selftests/firmware: add install target to enable test install
> >>>>       selftests/ftrace: add install target to enable test install
> >>>>       selftests/ipc: add install target to enable test install
> >>>>       selftests/kcmp: add install target to enable test install
> >>>>       selftests/memfd: add install target to enable test install
> >>>>       selftests/memory-hotplug: add install target to enable test install
> >>>>       selftests/mount: add install target to enable test install
> >>>>       selftests/mqueue: add install target to enable test install
> >>>>       selftests/net: add install target to enable test install
> >>>>       selftests/ptrace: add install target to enable test install
> >>>>       selftests/size: add install target to enable test install
> >>>>       selftests/sysctl: add install target to enable test install
> >>>>       selftests/timers: add install target to enable test install
> >>>>       selftests/user: add install target to enable test install
> >>>>       selftests/vm: add install target to enable test install
> >>>>       selftests: add install target to enable test install
> >>>>       kbuild: add a new kselftest_install make target to install selftests
> >>>
> >>>
> >>> I don't understand why you insist on merging this series with the logic copied
> >>> 18 times.
> >>>
> >>> I'm happy to tweak my series that uses an include file, but I don't see the
> >>> point of merging this series first when almost every line will be removed when
> >>> my series goes in.
> >>
> >> Please work on the suggestions I made and rework the patches
> >> and resend. As I mentioned earlier, I want to enable this work
> >> and them make improvements.
> > 
> > Yes I would like install to work to. I'd also like it to work for the powerpc
> > tests you ignored. But I don't want it to involve copying the same logic into
> > every Makefile in the tree.
> 
> Michael,
> 
> powerpc tests aren't ignored. They are in the list to do as
> the next step.

They are ignored by this series, unlike my series.

> > My series was sent over a month ago, with plenty of time for you to merge it
> > instead of this cut-and-paste solution.
> 
> I asked you to re-work the patches based on my suggestions
> and resend. I didn't see any patches from you that addressed
> the comments. I can't merge the patches you sent without
> addressing the comments.

Your comments were "please rebase on my series", and as I explained that is
pointless because my series replaces your series.

cheers

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Dave Jones]

On Tue, Feb 10, 2015 at 02:16:05PM +1100, Michael Ellerman wrote:
 
 > > On 02/09/2015 05:43 PM, Michael Ellerman wrote:
 > > > On Mon, 2015-02-09 at 17:36 -0700, Shuah Khan wrote:
 > > >> On 02/09/2015 05:30 PM, Michael Ellerman wrote:
 > > >>> On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
 > > >>>> Hi Linus,
 > > >>>>
 > > >>>> Please pull the following Kselftest updates for 3.20-rc1
 > > >>>>
 > > >>>> thanks,
 > > >>>> -- Shuah
 > > >>>>
 > > >>> ...
 > > >>>
 > > >>> I don't understand why you insist on merging this series with the logic copied
 > > >>> 18 times.
 > > >>>
 > > >>> I'm happy to tweak my series that uses an include file, but I don't see the
 > > >>> point of merging this series first when almost every line will be removed when
 > > >>> my series goes in.
 > > >>
 > > >> Please work on the suggestions I made and rework the patches
 > > >> and resend. As I mentioned earlier, I want to enable this work
 > > >> and them make improvements.
 > > > 
 > > > Yes I would like install to work to. I'd also like it to work for the powerpc
 > > > tests you ignored. But I don't want it to involve copying the same logic into
 > > > every Makefile in the tree.
 > > 
 > > > My series was sent over a month ago, with plenty of time for you to merge it
 > > > instead of this cut-and-paste solution.
 > > 
 > > I asked you to re-work the patches based on my suggestions
 > > and resend. I didn't see any patches from you that addressed
 > > the comments. I can't merge the patches you sent without
 > > addressing the comments.
 > 
 > Your comments were "please rebase on my series", and as I explained that is
 > pointless because my series replaces your series.

Michael's series also has a bunch of features this pull doesn't.
I had started implementing some of these features myself before realizing
this stuff was in limbo. (Especially the ability to install to a
different directory: our use case involves packaging up the latest
selftests for use to be run against a long-term stable kernel).

What needs to happen to unblock this, given that nothing has been
merged so far.

Working on selftests is sort of frustrating with all this stuff pending
given the potential conflicts.

	Dave

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Shuah Khan]

On 03/02/2015 02:19 PM, Dave Jones wrote:
> On Tue, Feb 10, 2015 at 02:16:05PM +1100, Michael Ellerman wrote:
>  
>  > > On 02/09/2015 05:43 PM, Michael Ellerman wrote:
>  > > > On Mon, 2015-02-09 at 17:36 -0700, Shuah Khan wrote:
>  > > >> On 02/09/2015 05:30 PM, Michael Ellerman wrote:
>  > > >>> On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
>  > > >>>> Hi Linus,
>  > > >>>>
>  > > >>>> Please pull the following Kselftest updates for 3.20-rc1
>  > > >>>>
>  > > >>>> thanks,
>  > > >>>> -- Shuah
>  > > >>>>
>  > > >>> ...
>  > > >>>
>  > > >>> I don't understand why you insist on merging this series with the logic copied
>  > > >>> 18 times.
>  > > >>>
>  > > >>> I'm happy to tweak my series that uses an include file, but I don't see the
>  > > >>> point of merging this series first when almost every line will be removed when
>  > > >>> my series goes in.
>  > > >>
>  > > >> Please work on the suggestions I made and rework the patches
>  > > >> and resend. As I mentioned earlier, I want to enable this work
>  > > >> and them make improvements.
>  > > > 
>  > > > Yes I would like install to work to. I'd also like it to work for the powerpc
>  > > > tests you ignored. But I don't want it to involve copying the same logic into
>  > > > every Makefile in the tree.
>  > > 
>  > > > My series was sent over a month ago, with plenty of time for you to merge it
>  > > > instead of this cut-and-paste solution.
>  > > 
>  > > I asked you to re-work the patches based on my suggestions
>  > > and resend. I didn't see any patches from you that addressed
>  > > the comments. I can't merge the patches you sent without
>  > > addressing the comments.
>  > 
>  > Your comments were "please rebase on my series", and as I explained that is
>  > pointless because my series replaces your series.
> 
> Michael's series also has a bunch of features this pull doesn't.
> I had started implementing some of these features myself before realizing
> this stuff was in limbo. (Especially the ability to install to a
> different directory: our use case involves packaging up the latest
> selftests for use to be run against a long-term stable kernel).
> 
> What needs to happen to unblock this, given that nothing has been
> merged so far.
> 
> Working on selftests is sort of frustrating with all this stuff pending
> given the potential conflicts.
> 

Dave,

At the moment I am working on an approach that doesn't require
changes to Makefiles. This pull request being in limbo game me
a chance to regroup and come up with a simpler approach. Michael's
work is based on Makefile changes as well.

Please give me couple of days and I will send out patches that add
install, packaging support. I am handling this as tools at the top
level that don't depend on any existing Makefiles targets.

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Michael Ellerman]

On Mon, 2015-03-02 at 16:19 -0500, Dave Jones wrote:
> On Tue, Feb 10, 2015 at 02:16:05PM +1100, Michael Ellerman wrote:
>  
>  > > On 02/09/2015 05:43 PM, Michael Ellerman wrote:
>  > > > On Mon, 2015-02-09 at 17:36 -0700, Shuah Khan wrote:
>  > > >> On 02/09/2015 05:30 PM, Michael Ellerman wrote:
>  > > >>> On Mon, 2015-02-09 at 11:36 -0700, Shuah Khan wrote:
>  > > >>>> Hi Linus,
>  > > >>>>
>  > > >>>> Please pull the following Kselftest updates for 3.20-rc1
>  > > >>>>
>  > > >>>> thanks,
>  > > >>>> -- Shuah
>  > > >>>>
>  > > >>> ...
>  > > >>>
>  > > >>> I don't understand why you insist on merging this series with the logic copied
>  > > >>> 18 times.
>  > > >>>
>  > > >>> I'm happy to tweak my series that uses an include file, but I don't see the
>  > > >>> point of merging this series first when almost every line will be removed when
>  > > >>> my series goes in.
>  > > >>
>  > > >> Please work on the suggestions I made and rework the patches
>  > > >> and resend. As I mentioned earlier, I want to enable this work
>  > > >> and them make improvements.
>  > > > 
>  > > > Yes I would like install to work to. I'd also like it to work for the powerpc
>  > > > tests you ignored. But I don't want it to involve copying the same logic into
>  > > > every Makefile in the tree.
>  > > 
>  > > > My series was sent over a month ago, with plenty of time for you to merge it
>  > > > instead of this cut-and-paste solution.
>  > > 
>  > > I asked you to re-work the patches based on my suggestions
>  > > and resend. I didn't see any patches from you that addressed
>  > > the comments. I can't merge the patches you sent without
>  > > addressing the comments.
>  > 
>  > Your comments were "please rebase on my series", and as I explained that is
>  > pointless because my series replaces your series.
> 
> Michael's series also has a bunch of features this pull doesn't.
> I had started implementing some of these features myself before realizing
> this stuff was in limbo. (Especially the ability to install to a
> different directory: our use case involves packaging up the latest
> selftests for use to be run against a long-term stable kernel).
> 
> What needs to happen to unblock this, given that nothing has been
> merged so far.
> 
> Working on selftests is sort of frustrating with all this stuff pending
> given the potential conflicts.

Thanks for chiming in Dave, and sorry that this has gotten into such a mess.

I'll post a rebased version of my series and we can discuss the merits of each
approach.

cheers

Re: [GIT PULL] Kselftest updates for 3.20-rc1

[Shuah Khan]

On 02/09/2015 11:36 AM, Shuah Khan wrote:
> Hi Linus,
>
> Please pull the following Kselftest updates for 3.20-rc1
>
> thanks,
> -- Shuah

Hi Linus,

Hope this work is on the list to be pulled in for 3.20. Please let
me know if there are any problems.

thanks,
-- Shuah
>
> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
>
>    Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
>
> are available in the git repository at:
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux-kselftest-3.20-rc1
>
> for you to fetch changes up to 6ddf898c23d62c974e148efd9e509731324a167a:
>
>    selftests/exec: Check if the syscall exists and bail if not
> (2015-02-04 10:17:35 -0700)
>
> ----------------------------------------------------------------
> Kselftest updates for 3.20-rc1
>
> This update adds:
> - Kselftest install target feature
> - Fix for selftests/exec test
>
> ----------------------------------------------------------------
> Michael Ellerman (1):
>        selftests/exec: Check if the syscall exists and bail if not
>
> Shuah Khan (20):
>        selftests/breakpoints: add install target to enable test install
>        selftests/cpu-hotplug: add install target to enable test install
>        selftests/efivarfs: add install target to enable test install
>        selftests/firmware: add install target to enable test install
>        selftests/ftrace: add install target to enable test install
>        selftests/ipc: add install target to enable test install
>        selftests/kcmp: add install target to enable test install
>        selftests/memfd: add install target to enable test install
>        selftests/memory-hotplug: add install target to enable test install
>        selftests/mount: add install target to enable test install
>        selftests/mqueue: add install target to enable test install
>        selftests/net: add install target to enable test install
>        selftests/ptrace: add install target to enable test install
>        selftests/size: add install target to enable test install
>        selftests/sysctl: add install target to enable test install
>        selftests/timers: add install target to enable test install
>        selftests/user: add install target to enable test install
>        selftests/vm: add install target to enable test install
>        selftests: add install target to enable test install
>        kbuild: add a new kselftest_install make target to install selftests
>
>   Makefile                                           | 14 +++++-
>   tools/testing/selftests/Makefile                   | 54
> +++++++++++++++++++++-
>   tools/testing/selftests/breakpoints/Makefile       | 19 +++++++-
>   tools/testing/selftests/cpu-hotplug/Makefile       | 14 +++++-
>   .../{on-off-test.sh => cpu-on-off-test.sh}         |  0
>   tools/testing/selftests/efivarfs/Makefile          | 16 ++++++-
>   tools/testing/selftests/exec/execveat.c            | 10 +++-
>   tools/testing/selftests/firmware/Makefile          | 43 ++++++++++-------
>   tools/testing/selftests/ftrace/Makefile            | 13 +++++-
>   tools/testing/selftests/ipc/Makefile               | 19 +++++++-
>   tools/testing/selftests/kcmp/Makefile              | 13 +++++-
>   tools/testing/selftests/memfd/Makefile             | 17 +++++--
>   tools/testing/selftests/memory-hotplug/Makefile    | 14 +++++-
>   .../{on-off-test.sh => mem-on-off-test.sh}         |  0
>   tools/testing/selftests/mount/Makefile             | 12 ++++-
>   tools/testing/selftests/mqueue/Makefile            | 18 ++++++--
>   tools/testing/selftests/net/Makefile               | 20 ++++++--
>   tools/testing/selftests/ptrace/Makefile            | 16 +++++--
>   tools/testing/selftests/size/Makefile              | 12 ++++-
>   tools/testing/selftests/sysctl/Makefile            | 17 ++++++-
>   tools/testing/selftests/timers/Makefile            | 12 ++++-
>   tools/testing/selftests/user/Makefile              | 12 ++++-
>   tools/testing/selftests/vm/Makefile                | 11 ++++-
>   23 files changed, 326 insertions(+), 50 deletions(-)
>   rename tools/testing/selftests/cpu-hotplug/{on-off-test.sh =>
> cpu-on-off-test.sh} (100%)
>   rename tools/testing/selftests/memory-hotplug/{on-off-test.sh =>
> mem-on-off-test.sh} (100%)
>


-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978