From: Krzysztof Opasiak <k.opasiak@samsung.com>
To: balbi@ti.com, gregkh@linuxfoundation.org, jlbec@evilplan.org
Cc: andrzej.p@samsung.com, m.szyprowski@samsung.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Krzysztof Opasiak <k.opasiak@samsung.com>
Subject: [PATCH v2 0/4] Ensure that lun ids are contiguous
Date: Wed, 08 Apr 2015 14:06:44 +0200 [thread overview]
Message-ID: <1428494808-12566-1-git-send-email-k.opasiak@samsung.com> (raw)
Dear list,
This series fix configfs interface for mass storage function.
According to mass storage specification[1]:
"Logical Unit Numbers on the device shall be numbered contiguously
starting from LUN 0 to a maximum LUN of 15 (Fh)."
Currently configfs interface allows to create LUNs with
arbitrary ids what causes problems with some host side
mass storage drivers.
This patch extends configfs interface with unlocked version
of configfs_depend_item() which should be used only in configfs
callbacks. This allows to protect from
removing lun directory from the middle of id space.
Example:
as is:
$ mkdir mass_storage.name
$ mkdir lun.3
$ mkdir lun.5
$ rmdir lun.3
After this series:
$ mkdir mass_storage.name
$ mkdir lun.3
mkdir: cannot create directory 'lun.3': Invalid argument
$ mkdir lun.1
$ mkdir lun.2
$ rmdir lun.1
rmdir: failed to remove 'lun.1': Device or resource busy
$ rmdir lun.2
$ rmdir lun.1
--
Best regards,
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
---
Changes since v1:
- drop incorrect typo fix
("iff" is not a typo but shorten version of "if and only if")
Krzysztof Opasiak (4):
fs: configfs: Add unlocked version of configfs_depend_item()
usb: gadget: mass_storage: Store lun_opts in fsg_opts
usb: gadget: mass_storage: Ensure that lun ids are contiguous
Documentation: ABI: Fix documentation for mass_storage function
.../ABI/testing/configfs-usb-gadget-mass-storage | 7 +++-
drivers/usb/gadget/function/f_mass_storage.c | 40 ++++++++++++++++++--
drivers/usb/gadget/function/f_mass_storage.h | 1 +
fs/configfs/dir.c | 29 ++++++++++++++
include/linux/configfs.h | 9 +++++
5 files changed, 81 insertions(+), 5 deletions(-)
--
1.7.9.5
next reply other threads:[~2015-04-08 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 12:06 Krzysztof Opasiak [this message]
2015-04-08 12:06 ` [PATCH v2 1/4] fs: configfs: Add unlocked version of configfs_depend_item() Krzysztof Opasiak
2015-04-08 12:06 ` [PATCH v2 2/4] usb: gadget: mass_storage: Store lun_opts in fsg_opts Krzysztof Opasiak
[not found] ` <1428494808-12566-3-git-send-email-k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-08 14:15 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1504081012240.1384-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-04-08 14:56 ` Krzysztof Opasiak
2015-04-08 12:06 ` [PATCH v2 3/4] usb: gadget: mass_storage: Ensure that lun ids are contiguous Krzysztof Opasiak
[not found] ` <1428494808-12566-1-git-send-email-k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-08 12:06 ` [PATCH v2 4/4] Documentation: ABI: Fix documentation for mass_storage function Krzysztof Opasiak
2015-04-09 8:32 ` Tal Shorer
2015-04-09 9:20 ` Krzysztof Opasiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428494808-12566-1-git-send-email-k.opasiak@samsung.com \
--to=k.opasiak@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlbec@evilplan.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox