From: Octavian Purdila <octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Octavian Purdila
<octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [RFC PATCH 3/3] iio: derive the mounting matrix from ACPI _PLD objects
Date: Mon, 27 Apr 2015 18:01:48 +0300 [thread overview]
Message-ID: <1430146908-27919-4-git-send-email-octavian.purdila@intel.com> (raw)
In-Reply-To: <1430146908-27919-1-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
This patch derives the mounting matrix for a particular IIO device
based ont the ACPI _PLD information. Note that if mounting matrix is
defined in the device properties it overrieds the _PLD information.
Signed-off-by: Octavian Purdila <octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/iio/industrialio-core.c | 51 +++++++++++++++++++++++++++++++++++++++++
include/linux/iio/iio.h | 46 +++++++++++++++++++++++++++++++++++++
2 files changed, 97 insertions(+)
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 9000c53..90ee58a 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -31,6 +31,7 @@
#include <linux/iio/sysfs.h>
#include <linux/iio/events.h>
#include <linux/iio/buffer.h>
+#include <linux/acpi.h>
/* IDA to assign each registered device a unique id */
static DEFINE_IDA(iio_ida);
@@ -871,6 +872,53 @@ static ssize_t iio_show_dev_name(struct device *dev,
static DEVICE_ATTR(name, S_IRUGO, iio_show_dev_name, NULL);
+#if IS_ENABLED(CONFIG_ACPI)
+static bool iio_get_mounting_matrix_acpi(struct iio_dev *indio_dev)
+{
+ acpi_handle h = ACPI_HANDLE(indio_dev->dev.parent);
+ struct acpi_pld_info *info;
+
+ if (ACPI_SUCCESS(acpi_get_physical_device_location(h, &info))) {
+ IIO_MM_SET(indio_dev->mounting_matrix, X, X, 1, 0);
+ IIO_MM_SET(indio_dev->mounting_matrix, Y, Y, 1, 0);
+ IIO_MM_SET(indio_dev->mounting_matrix, Z, Z, 1, 0);
+
+ /* Chip placed on the back panel ; negate x and z */
+ if (info->panel == ACPI_PLD_PANEL_BACK) {
+ IIO_MM_MUL(indio_dev->mounting_matrix, X, X, -1, 0);
+ IIO_MM_MUL(indio_dev->mounting_matrix, Z, Z, -1, 0);
+ }
+
+ switch (info->rotation) {
+ case 2:
+ /* 90 deg clockwise: negate y then swap x,y */
+ IIO_MM_MUL(indio_dev->mounting_matrix, Y, Y, -1, 0);
+ IIO_MM_SWAP(indio_dev->mounting_matrix, X, Y);
+ break;
+ case 4:
+ /* Upside down: negate x and y */
+ IIO_MM_MUL(indio_dev->mounting_matrix, X, X, -1, 0);
+ IIO_MM_MUL(indio_dev->mounting_matrix, Y, Y, -1, 0);
+ break;
+ case 6:
+ /* 90 deg counter clockwise: negate x then swap x,y */
+ IIO_MM_MUL(indio_dev->mounting_matrix, X, X, -1, 0);
+ IIO_MM_SWAP(indio_dev->mounting_matrix, X, Y);
+ break;
+ }
+
+ return true;
+ }
+
+ return false;
+}
+#else
+static bool iio_get_mounting_matrix_acpi(struct iio_dev *indio_dev)
+{
+ return false;
+}
+#endif
+
static bool iio_get_mounting_matrix(struct iio_dev *indio_dev)
{
int i, err;
@@ -888,6 +936,9 @@ static bool iio_get_mounting_matrix(struct iio_dev *indio_dev)
return true;
}
+ if (ACPI_HANDLE(indio_dev->dev.parent))
+ return iio_get_mounting_matrix_acpi(indio_dev);
+
return false;
}
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index c1fa852..feb7813 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -436,6 +436,52 @@ struct iio_buffer_setup_ops {
#define IIO_MM_SIZE 18
+enum {
+ IIO_MM_XX0,
+ IIO_MM_XX1,
+ IIO_MM_XY0,
+ IIO_MM_XY1,
+ IIO_MM_XZ0,
+ IIO_MM_XZ1,
+ IIO_MM_YX0,
+ IIO_MM_YX1,
+ IIO_MM_YY0,
+ IIO_MM_YY1,
+ IIO_MM_YZ0,
+ IIO_MM_YZ1,
+ IIO_MM_ZX0,
+ IIO_MM_ZX1,
+ IIO_MM_ZY0,
+ IIO_MM_ZY1,
+ IIO_MM_ZZ0,
+ IIO_MM_ZZ1,
+};
+
+#define IIO_MM_SET(mm, a, b, val0, val1) \
+ do { \
+ mm[IIO_MM_##a##b##0] = val0; \
+ mm[IIO_MM_##a##b##1] = val1; \
+ } while (0) \
+
+#define IIO_MM_MUL(mm, a, b, val0, val1) \
+ do { \
+ mm[IIO_MM_##a##b##0] *= val0; \
+ mm[IIO_MM_##a##b##0] *= val1; \
+ } while (0) \
+
+#define IIO_MM_SWAP(mm, x, y) \
+ do { \
+ int tmp; \
+ \
+ tmp = mm[IIO_MM_##x##x##0]; \
+ mm[IIO_MM_##x##x##0] = mm[IIO_MM_##y##y##0]; \
+ mm[IIO_MM_##y##y##0] = tmp; \
+ \
+ tmp = mm[IIO_MM_##x##x##1]; \
+ mm[IIO_MM_##x##x##1] = mm[IIO_MM_##y##y##1]; \
+ mm[IIO_MM_##y##y##1] = tmp; \
+ } while (0) \
+
/**
* struct iio_dev - industrial I/O device
* @id: [INTERN] used to identify device internally
--
1.9.1
next prev parent reply other threads:[~2015-04-27 15:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 15:01 [RFC PATCH 0/3] iio: export mounting matrix Octavian Purdila
2015-04-27 15:01 ` [RFC PATCH 1/3] iio: export mounting matrix information Octavian Purdila
[not found] ` <1430146908-27919-2-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-04 11:25 ` Jonathan Cameron
[not found] ` <55475710.9050707-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-04 17:48 ` Octavian Purdila
[not found] ` <CAE1zot+X5RV7iexE4dUPY_YBGP4Zet1S1hSmauP8-e5P59nXRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-05 13:55 ` Jonathan Cameron
[not found] ` <1430146908-27919-1-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-04-27 15:01 ` [RFC PATCH 2/3] ACPICA: Add _PLD front and back panel constants Octavian Purdila
2015-04-27 15:01 ` Octavian Purdila [this message]
2015-04-27 15:42 ` [RFC PATCH 3/3] iio: derive the mounting matrix from ACPI _PLD objects Kuppuswamy Sathyanarayanan
[not found] ` <64714.10.254.87.235.1430149342.squirrel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-04-27 15:54 ` Octavian Purdila
2015-04-27 21:57 ` sathyanarayanan kuppuswamy
2015-04-28 2:23 ` Octavian Purdila
[not found] ` <CAE1zot+fusrvow+s2+CmoctcSD=c2BxoSyd2b=7MBv-pg68A+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 1:11 ` Sathyanarayanan Kuppuswamy
[not found] ` <5546C72E.2040101-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-05-04 8:21 ` Octavian Purdila
[not found] ` <CAE1zot+1qGPhquFH8+=MhiXNb-OoqKuiYJae3aATqntFO6Q-Jw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 15:23 ` Srinivas Pandruvada
2015-05-04 11:23 ` Jonathan Cameron
2015-05-04 11:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430146908-27919-4-git-send-email-octavian.purdila@intel.com \
--to=octavian.purdila-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).