From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Zviagintsev Subject: [PATCH v2 2/5] selftests/kdbus: drop useless assignment Date: Wed, 17 Jun 2015 19:33:25 +0300 Message-ID: <1434558808-16129-3-git-send-email-sergei@s15v.net> References: <1434558808-16129-1-git-send-email-sergei@s15v.net> Return-path: In-Reply-To: <1434558808-16129-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni Cc: Shuah Khan , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sergei Zviagintsev List-Id: linux-api@vger.kernel.org Assign returned file descriptor directly to `fd', without intermediate `ret' variable. Signed-off-by: Sergei Zviagintsev --- tools/testing/selftests/kdbus/kdbus-util.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/kdbus/kdbus-util.c b/tools/testing/selftests/kdbus/kdbus-util.c index a3e49b04f3a7..f9102264cfb9 100644 --- a/tools/testing/selftests/kdbus/kdbus-util.c +++ b/tools/testing/selftests/kdbus/kdbus-util.c @@ -408,11 +408,9 @@ int sys_memfd_create(const char *name, __u64 size) { int ret, fd; - ret = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); - if (ret < 0) - return ret; - - fd = ret; + fd = syscall(__NR_memfd_create, name, MFD_ALLOW_SEALING); + if (fd < 0) + return fd; ret = ftruncate(fd, size); if (ret < 0) { -- 1.8.3.1