From: Sergei Zviagintsev <sergei@s15v.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Mack <daniel@zonque.org>,
David Herrmann <dh.herrmann@googlemail.com>,
Djalal Harouni <tixxdz@opendz.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Sergei Zviagintsev <sergei@s15v.net>
Subject: [PATCH v2 4/5] selftests/kdbus: drop duplicated code from __kdbus_msg_send()
Date: Wed, 17 Jun 2015 19:33:27 +0300 [thread overview]
Message-ID: <1434558808-16129-5-git-send-email-sergei@s15v.net> (raw)
In-Reply-To: <1434558808-16129-1-git-send-email-sergei@s15v.net>
Set value of `size' in one step instead of four.
Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
---
tools/testing/selftests/kdbus/kdbus-util.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/testing/selftests/kdbus/kdbus-util.c b/tools/testing/selftests/kdbus/kdbus-util.c
index f9102264cfb9..ae81da63d810 100644
--- a/tools/testing/selftests/kdbus/kdbus-util.c
+++ b/tools/testing/selftests/kdbus/kdbus-util.c
@@ -462,10 +462,7 @@ static int __kdbus_msg_send(const struct kdbus_conn *conn,
int memfd = -1;
int ret;
- size = sizeof(*msg);
- size += KDBUS_ITEM_SIZE(sizeof(struct kdbus_vec));
- size += KDBUS_ITEM_SIZE(sizeof(struct kdbus_vec));
- size += KDBUS_ITEM_SIZE(sizeof(struct kdbus_vec));
+ size = sizeof(*msg) + 3 * KDBUS_ITEM_SIZE(sizeof(struct kdbus_vec));
if (dst_id == KDBUS_DST_ID_BROADCAST)
size += KDBUS_ITEM_SIZE(sizeof(struct kdbus_bloom_filter)) + 64;
--
1.8.3.1
next prev parent reply other threads:[~2015-06-17 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 16:33 [PATCH v2 0/5] selftests/kdbus: small fixes Sergei Zviagintsev
2015-06-17 16:33 ` [PATCH v2 1/5] selftests/kdbus: handle cap_get_proc() error properly Sergei Zviagintsev
2015-06-17 16:33 ` Sergei Zviagintsev [this message]
2015-06-17 16:33 ` [PATCH v2 5/5] selftests/kdbus: fix error paths in __kdbus_msg_send() Sergei Zviagintsev
[not found] ` <1434558808-16129-1-git-send-email-sergei-E844GTqJAzo@public.gmane.org>
2015-06-17 16:33 ` [PATCH v2 2/5] selftests/kdbus: drop useless assignment Sergei Zviagintsev
2015-06-17 16:33 ` [PATCH v2 3/5] selftests/kdbus: remove useless initializations from kdbus_clone_userns_test() Sergei Zviagintsev
2015-06-17 17:07 ` [PATCH v2 0/5] selftests/kdbus: small fixes Shuah Khan
[not found] ` <5581A962.3040601-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-06-17 19:11 ` Greg Kroah-Hartman
[not found] ` <20150617191130.GB3186-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-06-18 10:05 ` David Herrmann
2015-06-19 4:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434558808-16129-5-git-send-email-sergei@s15v.net \
--to=sergei@s15v.net \
--cc=daniel@zonque.org \
--cc=dh.herrmann@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=tixxdz@opendz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox