From: Manjeet Pawar <manjeet.p@samsung.com>
To: catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org
Cc: pankaj.m@samsung.com, Manjeet Pawar <manjeet.p@samsung.com>,
Akhilesh Kumar <akhilesh.k@samsung.com>,
Rohit Thapliyal <r.thapliyal@samsung.com>
Subject: [PATCHv3] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
Date: Fri, 09 Oct 2015 15:59:40 +0530 [thread overview]
Message-ID: <1444386580-10917-1-git-send-email-manjeet.p@samsung.com> (raw)
MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel.
This patch fixes this issue.
This issue is reported in LTP (testcase: sigaltstack02.c).
Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1"
Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel
it is set to 2048 so testcase gets failed.
Testcase Output:
sigaltstack02 1 TPASS : stgaltstack() fails, Invalid Flag value,errno:22
sigaltstack02 2 TFAIL : sigaltstack() returned 0, expected -1,errno:12
Reported Issue in Glibc Bugzilla:
Bugfix in Glibc-2.22: [Bug 16850]
https://sourceware.org/bugzilla/show_bug.cgi?id=16850
Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
Signed-off-by: Rohit Thapliyal <r.thapliyal@samsung.com>
---
v1 -> Changes in uapi overall header
v2 -> Changes done in arm64 headers
v3 -> Changes done in both uapi & arm64 headers
arch/arm64/include/uapi/asm/signal.h | 3 +++
include/uapi/asm-generic/signal.h | 2 ++
2 files changed, 5 insertions(+)
diff --git a/arch/arm64/include/uapi/asm/signal.h b/arch/arm64/include/uapi/asm/signal.h
index 8d1e723..991bf5d 100644
--- a/arch/arm64/include/uapi/asm/signal.h
+++ b/arch/arm64/include/uapi/asm/signal.h
@@ -19,6 +19,9 @@
/* Required for AArch32 compatibility. */
#define SA_RESTORER 0x04000000
+#define MINSIGSTKSZ 5120
+#define SIGSTKSZ 16384
+
#include <asm-generic/signal.h>
#endif
diff --git a/include/uapi/asm-generic/signal.h b/include/uapi/asm-generic/signal.h
index 9df61f1..b98b67b 100644
--- a/include/uapi/asm-generic/signal.h
+++ b/include/uapi/asm-generic/signal.h
@@ -80,8 +80,10 @@
* SA_RESTORER 0x04000000
*/
+#if !defined MINSIGSTKSZ || !defined SIGSTKSZ
#define MINSIGSTKSZ 2048
#define SIGSTKSZ 8192
+#endif
#ifndef __ASSEMBLY__
typedef struct {
--
1.7.9.5
next reply other threads:[~2015-10-09 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 10:29 Manjeet Pawar [this message]
[not found] ` <1444386580-10917-1-git-send-email-manjeet.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-09 10:33 ` [PATCHv3] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Will Deacon
[not found] ` <20151009103352.GK26278-5wv7dgnIgG8@public.gmane.org>
2015-10-09 10:52 ` Arnd Bergmann
2015-10-15 12:12 ` Szabolcs Nagy
2015-10-15 12:44 ` Arnd Bergmann
2015-10-15 12:47 ` Will Deacon
[not found] ` <20151015124756.GB27524-5wv7dgnIgG8@public.gmane.org>
2015-10-15 15:10 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444386580-10917-1-git-send-email-manjeet.p@samsung.com \
--to=manjeet.p@samsung.com \
--cc=akhilesh.k@samsung.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.m@samsung.com \
--cc=r.thapliyal@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).