linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
To: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH selftests 2/6] selftests: memfd: Stop unnecessary rebuilds
Date: Sat, 31 Oct 2015 23:37:03 +0000	[thread overview]
Message-ID: <1446334623.2595.15.camel@decadent.org.uk> (raw)
In-Reply-To: <1446334510.2595.13.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

Instead of explicitly running the compiler, add dependencies and take
advantage of implicit rules to build only as necessary.

Signed-off-by: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
---
 tools/testing/selftests/memfd/Makefile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/memfd/Makefile b/tools/testing/selftests/memfd/Makefile
index 3e7eb79..fd396ac 100644
--- a/tools/testing/selftests/memfd/Makefile
+++ b/tools/testing/selftests/memfd/Makefile
@@ -4,16 +4,16 @@ CFLAGS += -I../../../../include/uapi/
 CFLAGS += -I../../../../include/
 CFLAGS += -I../../../../usr/include/
 
-all:
-	$(CC) $(CFLAGS) memfd_test.c -o memfd_test
-
 TEST_PROGS := memfd_test
 
+all: $(TEST_PROGS)
+
 include ../lib.mk
 
-build_fuse:
-	$(CC) $(CFLAGS) fuse_mnt.c `pkg-config fuse --cflags --libs` -o fuse_mnt
-	$(CC) $(CFLAGS) fuse_test.c -o fuse_test
+build_fuse: fuse_mnt fuse_test
+
+fuse_mnt.o: CFLAGS += $(shell pkg-config fuse --cflags)
+fuse_mnt: LDFLAGS += $(shell pkg-config fuse --libs)
 
 run_fuse: build_fuse
 	@./run_fuse_test.sh || echo "fuse_test: [FAIL]"

-- 
Ben Hutchings
All extremists should be taken out and shot.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

  parent reply	other threads:[~2015-10-31 23:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-31 23:35 [PATCH selftests 0/6] Fix some broken tests Ben Hutchings
     [not found] ` <1446334510.2595.13.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2015-10-31 23:36   ` [PATCH selftests 1/6] selftests: Add missing #include directives Ben Hutchings
2015-10-31 23:37   ` Ben Hutchings [this message]
2015-10-31 23:37   ` [PATCH selftests 3/6] selftests: kprobe: Choose an always-defined function to probe Ben Hutchings
2015-10-31 23:37   ` [PATCH selftests 4/6] selftests: Make scripts executable Ben Hutchings
2015-10-31 23:39   ` [PATCH selftests 5/6] selftests: vm: Try harder to allocate huge pages Ben Hutchings
     [not found]     ` <1446334747.2595.19.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2015-11-10 20:01       ` David Rientjes
     [not found]         ` <alpine.DEB.2.10.1511101159480.29993-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2015-11-10 20:05           ` Shuah Khan
2015-11-10 21:48           ` Ben Hutchings
2015-11-11  1:11             ` David Rientjes
2015-10-31 23:39   ` [PATCH selftests 6/6] selftests: breakpoint: Actually build it Ben Hutchings
2015-11-02 12:15   ` [PATCH selftests 0/6] Fix some broken tests Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446334623.2595.15.camel@decadent.org.uk \
    --to=ben-/+tvbiectbitmtq+vha3yw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).